From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 4CB00384DD3D for ; Tue, 21 Feb 2023 12:04:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CB00384DD3D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x431.google.com with SMTP id l1so3886245wry.10 for ; Tue, 21 Feb 2023 04:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=i9xkM9ea5e6EmRQaVJzdKZ3ladU8rRb31u8pdwTtQPk=; b=Et42iL+NzAFCKDtzqoNF56x2YmgAzXeDJqYwGZ2sym5jUdXxZDWRKl+Fw4yZg6zJdL ZM1SYqr0gRU+Rg9yRMUtE7Ytp62IU5dLF+9LfyoDmXcUT/vmy4T63NLWp0pKog9K9/4U wWZc17bNWyIa/mI9T2pedE6nHlVrB4B1GAjZXMtaLkDUt4GcP+51aBm8EVsesaDKvPm1 9CWURKiwsMIPqLZK2nnkVipQZqGwjQZ0my4DaCr1/+As5vYYD7NlA4VM3EhdkkWUES/g k2jYOgV/fUC+W5hVA645Ncu6/I51Ls8lP1VvxcWj/Qk6A/SF5ob3FgabruGQBWIc7deB ZmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i9xkM9ea5e6EmRQaVJzdKZ3ladU8rRb31u8pdwTtQPk=; b=sY+lRUZAgsH+Ch/NRDuM+670zynaoB3H1t37kjCnl/svpyzPEuu1iHKMc4Hi+0Tygl yKZFMtDtqnp0+uvfKqTRUcZ4oI3FwiX5tFIeHh3d48M6K7JRbHEnLxpMCnqTnmifkZl5 VouqcoEASNQSUsoKXHWjtZXq0uozYx7BhDCmZ1Z7BD24Qnk+ruWYXY+D1oSBI9cDfl+u /lViP4CISV/1SXwBV0hjewzdNLHLHA18dQPgoelGc64Of8vOw9ABBdJde6a3jVavzm5h zHhcuXgDrzE56kcrOSmc7XvwS3otkks0drdn9PaQ8uU3stmfYvNdnzuLp6w82Q8OVMYv DSPA== X-Gm-Message-State: AO0yUKU6ubFrVxobxJROHcaCq7rykAo2VXx4E1CJkzB6swxypp+uCAcE +BuVGzkyKteJCuZY4O1iChz9 X-Google-Smtp-Source: AK7set/an2I8j2IJ3mqnhBHE6GyumvgvMdtV8SmDDqtXK7O0ebS1ZSQFzBzkFvM9DQ/k73NZXApwMA== X-Received: by 2002:a5d:5486:0:b0:2be:c41:4758 with SMTP id h6-20020a5d5486000000b002be0c414758mr2396543wrv.38.1676981042894; Tue, 21 Feb 2023 04:04:02 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id c15-20020adffb4f000000b002c55b0e6ef1sm5013811wrs.4.2023.02.21.04.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 04:04:02 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Philip Herron Subject: [committed 048/103] gccrs: Add closures to lints and error checking Date: Tue, 21 Feb 2023 13:01:38 +0100 Message-Id: <20230221120230.596966-49-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230221120230.596966-1-arthur.cohen@embecosm.com> References: <20230221120230.596966-1-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Philip Herron gcc/rust/ChangeLog: * checks/errors/rust-const-checker.cc (ConstChecker::visit): Visit closures properly. * checks/errors/rust-unsafe-checker.cc (UnsafeChecker::visit): Likewise. * checks/lints/rust-lint-marklive.h: Likewise. --- gcc/rust/checks/errors/rust-const-checker.cc | 4 +++- gcc/rust/checks/errors/rust-unsafe-checker.cc | 4 +++- gcc/rust/checks/lints/rust-lint-marklive.h | 5 +++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/gcc/rust/checks/errors/rust-const-checker.cc b/gcc/rust/checks/errors/rust-const-checker.cc index 01dc2620767..9161fa1ea2a 100644 --- a/gcc/rust/checks/errors/rust-const-checker.cc +++ b/gcc/rust/checks/errors/rust-const-checker.cc @@ -383,7 +383,9 @@ ConstChecker::visit (FieldAccessExpr &expr) void ConstChecker::visit (ClosureExpr &expr) -{} +{ + expr.get_expr ()->accept_vis (*this); +} void ConstChecker::visit (BlockExpr &expr) diff --git a/gcc/rust/checks/errors/rust-unsafe-checker.cc b/gcc/rust/checks/errors/rust-unsafe-checker.cc index 02868794cbc..3d534743eeb 100644 --- a/gcc/rust/checks/errors/rust-unsafe-checker.cc +++ b/gcc/rust/checks/errors/rust-unsafe-checker.cc @@ -454,7 +454,9 @@ UnsafeChecker::visit (FieldAccessExpr &expr) void UnsafeChecker::visit (ClosureExpr &expr) -{} +{ + expr.get_expr ()->accept_vis (*this); +} void UnsafeChecker::visit (BlockExpr &expr) diff --git a/gcc/rust/checks/lints/rust-lint-marklive.h b/gcc/rust/checks/lints/rust-lint-marklive.h index 4caf18ce186..dcc625d0b9d 100644 --- a/gcc/rust/checks/lints/rust-lint-marklive.h +++ b/gcc/rust/checks/lints/rust-lint-marklive.h @@ -285,6 +285,11 @@ public: item->accept_vis (*this); } + void visit (HIR::ClosureExpr &expr) override + { + expr.get_expr ()->accept_vis (*this); + } + private: std::vector worklist; std::set liveSymbols; -- 2.39.1