From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id B1F3F3833030 for ; Wed, 5 Apr 2023 14:06:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1F3F3833030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x329.google.com with SMTP id d11-20020a05600c3acb00b003ef6e6754c5so18372078wms.5 for ; Wed, 05 Apr 2023 07:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1680703566; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=PGjpvYFX4Kl/wH2pKgg62ebXRthGcemGu+cRhKKQn2U=; b=M3J8ghysnJzBHbw0ltuPPfpa8BeLrtVX6JoaY6HTEFsnrUOwtns7ICttNcFe5joegS N9mJyYHyPiosSZ2pgrs3MJhM4HwVWpmeb07RK1OERP7y4bHvFnCvA6u314N2exhGTrbc hwydkZEitz10lDzrrC7ZdCRbeqdUI728JD6vTBBBGf8awrWVQi3mSIZciAewX6bj4aTx PdEaXuh9G9HgCXujyxAQM0BuvVv15dfsZsn74AsZ/sRTu7zy34Tk1lBhOcLHzrl4brtj pLR0h4ja7u4IPTNih+EpHfKvlwRt/LanZSMKYLrOUwNaYcaXtbPf0ZV3fPK0PFO/rlsc 7k9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680703566; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PGjpvYFX4Kl/wH2pKgg62ebXRthGcemGu+cRhKKQn2U=; b=GqcoWhWTdDZ+/FT5buQ/4K0W8yn8SD+7hUuaTONMDV6unKn4UIdYunpU8ZhOYuGwSe +TmLeEM8M7q/ezWJcSTXz79QL1e9w7fcC/brviMBW/v5gcsXIZdLU9goAmu8Eekx85j9 jftUMlM1Pze/g2ujRe7cwmnI6MK6euDL2p9pMoEVSf1HQdD5EIlWeP/rIU5cRYk42jVx 5VJTBrfH2+9vHVI69emJO0pgFYxBMQeLhVwMAkufQMN1UCdWp7tFsn5RUg7PgWJW/Mb4 +YfC6Ge6T9Hgs5MPLRdVVcmzpygX4W3uqJr6ipkHMoqJb4e34pi4JCUnDEx2WPgN6uxA oO2A== X-Gm-Message-State: AAQBX9fWi2Jv9zpJBXi3E6pLiR2XI31HpjvU7e/Y28AA3/Irqe3j1OQ0 ecOI7RwwbIOilAuTYYnZfBUs X-Google-Smtp-Source: AKy350YNHO+FPUSVCLhtvct4aVAotpiHpE2xVN47qV1fPU3QJmOaTjss5eqXPgXudb4f/aQdh29uVw== X-Received: by 2002:a7b:c4d3:0:b0:3ed:551b:b78f with SMTP id g19-20020a7bc4d3000000b003ed551bb78fmr4674244wmk.4.1680703566304; Wed, 05 Apr 2023 07:06:06 -0700 (PDT) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id ay8-20020a05600c1e0800b003edddae1068sm2330150wmb.9.2023.04.05.07.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 07:06:05 -0700 (PDT) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Philip Herron Subject: [committed 54/88] gccrs: Remove bad error message on checking function arguments Date: Wed, 5 Apr 2023 16:03:38 +0200 Message-Id: <20230405140411.3016563-55-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230405140411.3016563-1-arthur.cohen@embecosm.com> References: <20230405140411.3016563-1-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Philip Herron Signed-off-by: Philip Herron gcc/rust/ChangeLog: * typecheck/rust-tyty-call.cc (TypeCheckCallExpr::visit): remove error message gcc/testsuite/ChangeLog: * rust/compile/func3.rs: update test case --- gcc/rust/typecheck/rust-tyty-call.cc | 5 ----- gcc/testsuite/rust/compile/func3.rs | 1 - 2 files changed, 6 deletions(-) diff --git a/gcc/rust/typecheck/rust-tyty-call.cc b/gcc/rust/typecheck/rust-tyty-call.cc index 4c6442e2d82..67e2866cbce 100644 --- a/gcc/rust/typecheck/rust-tyty-call.cc +++ b/gcc/rust/typecheck/rust-tyty-call.cc @@ -140,8 +140,6 @@ TypeCheckCallExpr::visit (FnType &type) argument->get_locus ()); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (argument->get_locus (), - "Type Resolution failure on parameter"); return; } } @@ -193,8 +191,6 @@ TypeCheckCallExpr::visit (FnPtr &type) TyWithLocation (argument_expr_tyty, arg_locus), argument->get_locus ()); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (argument->get_locus (), - "Type Resolution failure on parameter"); return; } @@ -301,7 +297,6 @@ TypeCheckMethodCallExpr::check (FnType &type) TyWithLocation (argument_expr_tyty, arg_locus), arg_locus); if (resolved_argument_type->get_kind () == TyTy::TypeKind::ERROR) { - rust_error_at (arg_locus, "Type Resolution failure on parameter"); return new ErrorType (type.get_ref ()); } diff --git a/gcc/testsuite/rust/compile/func3.rs b/gcc/testsuite/rust/compile/func3.rs index 2a329476118..002e5c90ab5 100644 --- a/gcc/testsuite/rust/compile/func3.rs +++ b/gcc/testsuite/rust/compile/func3.rs @@ -5,5 +5,4 @@ fn test(a: i32, b: i32) -> i32 { fn main() { let a = test(1, true); // { dg-error "expected .i32. got .bool." "" { target *-*-* } .-1 } - // { dg-error "Type Resolution failure on parameter" "" { target *-*-* } .-2 } } -- 2.40.0