From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D49773858D20 for ; Fri, 20 Oct 2023 17:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D49773858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D49773858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697823399; cv=none; b=nLIL54BZXrh8xjJX9BFOq+EbbnfgyTD9HOlTM9iUHFowj9QtwEPNTURy/hBP+4JzOk3sOYHpPPvLp4frWneznKmn87Sqt+vQeibuxOWR8JG+x+BV7v8ubspUGKXrn6/sh82VgxYBmcfgCMnS0fuVI9bI1qa2KcmIcMrSwGA4rKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697823399; c=relaxed/simple; bh=y/kta2LpWGbbUaIgthGrx8Cmcw0weG601VzWxYYqelY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TgIdZCN8EAc/WcZ53/RodZ9Ge4aLKAyQVgridHF0fVqqqwut1UVkzBw65Aw+2mT37AOOkrjuyo/DAzk8CTqU/bZSQaw2EJ3NYk7ky50QKUwM6BawjtmytqT7NqiZia5qYjYlGiDwmLdQIjuxKXuB1tBUQheErXnC3gEb68PR3f4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697823397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ld3YIg4uht75DzcnutgKhg0XciKZiP4SXL6KxT8nR7M=; b=BSJA317Z+qiqMn7yTVWjkxngjyPONDtgBqcFe2xdmA8FSWXH6k3N2hL6E+Tdg3fd28lYQy 8sc2rPNbKpAIOshdA4F0aXM9inemobtcdmZQJArbnOkPHgZyGsDbQVoBarcqeLuhMl6DrN va+rI2UG8MkJPuEUUEmESSvDyZKvhC8= Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-giU9Ff6hM1yImJZ5h29IPQ-1; Fri, 20 Oct 2023 13:36:36 -0400 X-MC-Unique: giU9Ff6hM1yImJZ5h29IPQ-1 Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-1d66b019a27so1598981fac.0 for ; Fri, 20 Oct 2023 10:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697823395; x=1698428195; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ld3YIg4uht75DzcnutgKhg0XciKZiP4SXL6KxT8nR7M=; b=jpuLN0pqOGidisH96dEMC0+5YnA5NRpRWtslu1P+MmEpI6WKR8wLpuz4V4hCaxik5Z 3ql17TuSIIwhg7IcToC+ZzbRtUcFMXrMebzPlN8bcOkvWgYxusuIyM7lhX5qwNNtugIE ZJIFfShCv0e0ZpdpipHcdHrPfmZWr1lnRLAG0RCHonhOddN2PVCDWchpI/SfYp7gEhGM NKesQOZl4QAyFe9llIH3TJ/E2ZTcBIIONTfYJnxPGku70E0amJ2kKAtEuIA9hweoVsb8 omgsuCAeF88ybGkNguHG4/6YNrcfReqFRqv62EVQpr8COx+OD7i6xd6gxmwzBNyRzfDi xItw== X-Gm-Message-State: AOJu0YzGtLxw7qmIOIs1C9j/f0wY04Ppc5i5V1zm2+n2qn3vlbTXhgOe 3Pgjm2uhLHQua1FsgBYOv7LS/GJMpqU5uhUHj/8HgdmedUZaDUHwMobIlkWQOC5kiAU3BK4it5Z 7Tq4KpHWvhi6H0Q== X-Received: by 2002:a05:6870:1707:b0:1bb:84af:bf8f with SMTP id h7-20020a056870170700b001bb84afbf8fmr2747831oae.58.1697823395398; Fri, 20 Oct 2023 10:36:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEv09KEcntYNR50SroLXEOtTLE/RnsKjJZkbTpJ+wKQ4MR9XfX1+Y4l5bP7de6EmV5N75rbDA== X-Received: by 2002:a05:6870:1707:b0:1bb:84af:bf8f with SMTP id h7-20020a056870170700b001bb84afbf8fmr2747818oae.58.1697823395145; Fri, 20 Oct 2023 10:36:35 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id m11-20020ad44b6b000000b0066cf4fa7b47sm858280qvx.4.2023.10.20.10.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 10:36:34 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, gcc-rust@gcc.gnu.org, Patrick Palka Subject: [PATCH] rust: build failure after NON_DEPENDENT_EXPR removal [PR111899] Date: Fri, 20 Oct 2023 13:36:30 -0400 Message-ID: <20231020173630.2328347-1-ppalka@redhat.com> X-Mailer: git-send-email 2.42.0.411.g813d9a9188 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Built on x86_64-pc-linux-gnu, pushed to trunk as obvious (hopefully). -- >8 -- This patch removes stray NON_DEPENDENT_EXPR checks following the removal of this tree code from the C++ FE. (Since this restores the build I supppose it means the Rust FE never creates NON_DEPENDENT_EXPR trees in the first place, so no further analysis is needed.) PR rust/111899 gcc/rust/ChangeLog: * backend/rust-constexpr.cc (potential_constant_expression_1): Remove NON_DEPENDENT_EXPR handling. * backend/rust-tree.cc (mark_exp_read): Likewise. (mark_use): Likewise. (lvalue_kind): Likewise. --- gcc/rust/backend/rust-constexpr.cc | 1 - gcc/rust/backend/rust-tree.cc | 3 --- 2 files changed, 4 deletions(-) diff --git a/gcc/rust/backend/rust-constexpr.cc b/gcc/rust/backend/rust-constexpr.cc index b28fa27b2d0..a7ae4166ea0 100644 --- a/gcc/rust/backend/rust-constexpr.cc +++ b/gcc/rust/backend/rust-constexpr.cc @@ -6151,7 +6151,6 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, case CLEANUP_POINT_EXPR: case EXPR_STMT: case PAREN_EXPR: - case NON_DEPENDENT_EXPR: /* For convenience. */ case LOOP_EXPR: case EXIT_EXPR: diff --git a/gcc/rust/backend/rust-tree.cc b/gcc/rust/backend/rust-tree.cc index 66e859cd70c..7040c75f825 100644 --- a/gcc/rust/backend/rust-tree.cc +++ b/gcc/rust/backend/rust-tree.cc @@ -72,7 +72,6 @@ mark_exp_read (tree exp) case ADDR_EXPR: case INDIRECT_REF: case FLOAT_EXPR: - case NON_DEPENDENT_EXPR: case VIEW_CONVERT_EXPR: mark_exp_read (TREE_OPERAND (exp, 0)); break; @@ -128,7 +127,6 @@ mark_use (tree expr, bool rvalue_p, bool read_p, switch (TREE_CODE (expr)) { case COMPONENT_REF: - case NON_DEPENDENT_EXPR: recurse_op[0] = true; break; case COMPOUND_EXPR: @@ -4520,7 +4518,6 @@ lvalue_kind (const_tree ref) lvalues. */ return (DECL_NONSTATIC_MEMBER_FUNCTION_P (ref) ? clk_none : clk_ordinary); - case NON_DEPENDENT_EXPR: case PAREN_EXPR: return lvalue_kind (TREE_OPERAND (ref, 0)); -- 2.42.0.411.g813d9a9188