From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 559E43858284 for ; Tue, 30 Jan 2024 12:11:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 559E43858284 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 559E43858284 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616672; cv=none; b=X7QgVlBAmkEuEAd1mH0ICeG5e6uktNv+Vh9VA32c+bZMun9/clmdEHoOaKQ7Ro8CaJxox6IuJZXfU7CzujQ2W819gPF+sEpAOiKi1/6ILvDDuvi0aGVxQlt93dgkF0MkZzL2woP6Ro7JCWNjZ3YDGL1Ug/2ML2N70QGXGsRZ464= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616672; c=relaxed/simple; bh=f/eweAY8QY1x3Z3GLRKbV18bHJaX+5nlabgR0C4BgMY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ivxZ+xiQcQScCSCNQIzgfzigPZ3fo5mmwARHoQdteDbQHJVaDBXOMrWZTezOAZnza00VP4WcLvYBVFJJJMODxSmhY05dHQqfBlL3wqn8gAAZJapBqRwDi5tq5cLQHqVYjkbf2tI3qiOQqoJtUupefTX++lSa2iBcVPRnSRXHFa4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-33ae3154cf8so1920286f8f.3 for ; Tue, 30 Jan 2024 04:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616662; x=1707221462; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JlNvBoB9Z/n9/WwzWrOvY19COsZ5wSmxkFc1drcPtbI=; b=Qp4hDwi2+vMXlO3SoA1oe/Bg4kxczq27a/qkFOi3c8M+QaChfvyIN5TjRWM87uWRWj 18RYG8Rr91hkDLEOKMMs77r0LIq2QQHLFIj5hoxm/XI8Mi/EYSTLzzc0tk8IvHKhQfj8 yKg6JTT6pM890vaIzctLxquDVnZROmSlU+OM2j69oV+/1j0YAdnyWMvsWJRImCgYP9ZH q5yj6j/M2rmVySKh1gP0YevSI9PexTJRsWikWc9zxXxF4UIpY/obv1la75H7jOBvw8R4 r/BcQyXpgiA8mrvwazVviQrdGVe39S4nWrB5G+vUgzcz/1xzjxawHbSzyYqIm91vB+9Q n6lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616662; x=1707221462; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JlNvBoB9Z/n9/WwzWrOvY19COsZ5wSmxkFc1drcPtbI=; b=l6cCdukZAmydx+k3JtKei+R91951lYePKRqFGHDiOxSNb6eDezJRf8CItI1Xoomfz6 wYwc8tNwrixMrOx2SBvy2ZdLMBdqPmEkifu1frj93+hIu2K1RKQ8N86jGesFuv81nktY D01iWbYJ9jE7TIHvfbOWGm8MLYnqFxSi4UHkW9H5/jHSIZ0Gqli0+BTgYqmESvPhp5FD 6/7EQrFvQyiTbzVWKzfi7mYsXvBCnQBfeDdEK1gYtXRDYFdtGfI3H0hkmqGtQSHmA9BA HC5n/yE3EKbyClled/yhMI5gih6mjucOYEE+gFbTeGm6LZC5YNnCYkLGaKDoRE+eMgdn z6wg== X-Gm-Message-State: AOJu0YxzKNZ8YIzrTVXywJlBc/xJEPtbhyBHAnxh/E3qTEtIOQUSCJZW CSlnepNVFsYNm0fXGiPKuJdLP8admj7uwbCVc7gyzZxfOovQb0jawOtfI6TdpSPS8941jvy7s0m VYQ== X-Google-Smtp-Source: AGHT+IEcXzTYN7pPWaq5wYi1UWW+c/03xL8y1To/x1B3bG2a8T91Bg17eAItBvEWfNWr7vrpdxIOQQ== X-Received: by 2002:a5d:51ca:0:b0:33a:ee39:5b4a with SMTP id n10-20020a5d51ca000000b0033aee395b4amr4103305wrv.36.1706616662181; Tue, 30 Jan 2024 04:11:02 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:01 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: [COMMITTED 016/101] gccrs: Reject auto traits with generic parameters Date: Tue, 30 Jan 2024 13:06:32 +0100 Message-ID: <20240130121026.807464-19-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Pierre-Emmanuel Patry Generic parameters are not allowed on auto traits, the compiler should emit an error. gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add check for generics on auto traits. * checks/errors/rust-ast-validation.h: Add visit function prototype. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/checks/errors/rust-ast-validation.cc | 14 ++++++++++++++ gcc/rust/checks/errors/rust-ast-validation.h | 1 + 2 files changed, 15 insertions(+) diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index f6ce45eacca..37d3668a9e0 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -96,4 +96,18 @@ ASTValidation::visit (AST::Function &function) AST::ContextualASTVisitor::visit (function); } +void +ASTValidation::visit (AST::Trait &trait) +{ + if (trait.is_auto ()) + { + if (trait.has_generics ()) + rust_error_at (trait.get_generic_params ()[0]->get_locus (), + ErrorCode::E0567, + "auto traits cannot have generic parameters"); + } + + AST::ContextualASTVisitor::visit (trait); +} + } // namespace Rust diff --git a/gcc/rust/checks/errors/rust-ast-validation.h b/gcc/rust/checks/errors/rust-ast-validation.h index 44995eb1fbc..49133ee0c3d 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.h +++ b/gcc/rust/checks/errors/rust-ast-validation.h @@ -38,6 +38,7 @@ public: virtual void visit (AST::LoopLabel &label); virtual void visit (AST::ExternalFunctionItem &item); virtual void visit (AST::Function &function); + virtual void visit (AST::Trait &trait); }; } // namespace Rust -- 2.42.1