From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 1C6563857C52 for ; Tue, 30 Jan 2024 12:11:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C6563857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C6563857C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616724; cv=none; b=Rm9uInBauQKBJyxhQ/PnTndJzBWIj8DYSsJvKryvHA3EUsgDkqkWb8phCG2hH/W/gcIsHmKy7kfIfD7tju1Nf+V1Iu7vi3tRzfML6JCGsCVPurcUNlpCEss8SQXGoAhAe2UktgBNHA4+VbJ0eOcC7feSL/e8F0AarlHYILZa5+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616724; c=relaxed/simple; bh=fCJ+dW56/eRjZRX3mdZZWthnOSE8tDh/d3d1gJzSSsQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pkc18qQgAuTq0trjo+oCBStBdcnL8tacJnGzzhpd/FaamqeMXwB3USgiouqnUTprTZDtx6H3VhCwixSGsWBxPoy9ZZ9NdgHz07q23srPlpX9C9/eDELGy67lsyJzrDgCBNUw0E3O3/GM5bHOvuyh5uwNhHVYZFSdD25wmuObSk8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-33ae3cc8a6aso2153198f8f.2 for ; Tue, 30 Jan 2024 04:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616691; x=1707221491; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=l6q8oLIWHaJf3t7j5fmWON5mJxrap4cF6WFh9DxU2ss=; b=UBtk281JBqcyOfrYSqTWjMHtvxQbEd/S70lDKDvQ+lf1WoHqqUxYrkRedoBBxiMmCE zdaSzb8h4dBSoek5jOq20Ks380N8kqDycVcPuS8KPngle+SgOs2ohoDuyibemz/qZHWL oYk2EXvbJbgyvmZZrOJy3lKU8r0hRUibBot4MjxsiUChaYKjvjwYU8bapsmjJ2Aief3v pSF5vv9KLW9uTBzYG4gm9fhVXk9jRrtRzjCxrYF9z1u0uuqdwH4/1I+Mwk+1sofOFDdA /zgLKtyGBlPiT0DekuOrxKT3+NWplfWm7xY6qqr9/Fczj991jM1+kakNHj4u1JEWkeu8 Ikkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616691; x=1707221491; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l6q8oLIWHaJf3t7j5fmWON5mJxrap4cF6WFh9DxU2ss=; b=H8YL1o6z5GFxGQoFHef4oXamW+DRQ2CbMc7401l/hsfsW2sWsUcVoW2l/RbqjtImnz UJcIlBXByy0lRgCJGdCrmWuKMVGznhSjbGOxwsniQ5gt2LNnBb6EeuBeIBwVrHUuMw5d D2ItyxXpdyaFEHU1Wjl3zWaPhe4lJMO4zrGdMleZsymN6bwn3otiK+Er2BtqaJqEz9I5 CKsDV9/OgMM6qT+dp39F8UnAQyN9B2Qgnd+dMPak/iv6N2K0YS3USkgz/VeU9jSZD6Sa YmUxVBMhf35W8qR0ZCJHXOL92EOYuxmhuVv9SLZ8zi3lSoZ1MYtJb+6EXtC/cHL3j2EP zcMQ== X-Gm-Message-State: AOJu0YwBczYteOanMh1ow+pp+Jn7RMr2Bkv7B+ni94P/O+zgWFnsrAnN R4HC8zpphu3vEJuQd7DGIz1TcuWwJ4Y5dnXnwSKBToCk55xb5qb1yaxl//gdGMrbcje5Gs251Ye AyQ== X-Google-Smtp-Source: AGHT+IGcGfJvSCP3bq6Ltorz3H8N+OPKDmiHTuMrV4BXya6Ipz07syAXrWlgTQ7qT/4uZxbVDzE+nw== X-Received: by 2002:adf:ea51:0:b0:33a:e89f:1dc5 with SMTP id j17-20020adfea51000000b0033ae89f1dc5mr4753581wrn.23.1706616690779; Tue, 30 Jan 2024 04:11:30 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:30 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: [COMMITTED 055/101] gccrs: Add AST validation check for const in trait Date: Tue, 30 Jan 2024 13:07:11 +0100 Message-ID: <20240130121026.807464-58-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Pierre-Emmanuel Patry Add a new check in AST validation pass that checks that no function declaration in traits are declared const. gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add const check. * checks/errors/rust-ast-validation.h: Add visit function prototype. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/checks/errors/rust-ast-validation.cc | 10 ++++++++++ gcc/rust/checks/errors/rust-ast-validation.h | 1 + 2 files changed, 11 insertions(+) diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index 54276e8fd59..2743eb0ca29 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -117,6 +117,16 @@ ASTValidation::visit (AST::Function &function) AST::ContextualASTVisitor::visit (function); } +void +ASTValidation::visit (AST::TraitFunctionDecl &decl) +{ + const auto &qualifiers = decl.get_qualifiers (); + + if (context.back () == Context::TRAIT && qualifiers.is_const ()) + rust_error_at (decl.get_identifier ().get_locus (), ErrorCode::E0379, + "functions in traits cannot be declared const"); +} + void ASTValidation::visit (AST::Trait &trait) { diff --git a/gcc/rust/checks/errors/rust-ast-validation.h b/gcc/rust/checks/errors/rust-ast-validation.h index 01d923ceff3..963357f86cd 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.h +++ b/gcc/rust/checks/errors/rust-ast-validation.h @@ -42,6 +42,7 @@ public: virtual void visit (AST::Union &item); virtual void visit (AST::Function &function); virtual void visit (AST::Trait &trait); + virtual void visit (AST::TraitFunctionDecl &decl); }; } // namespace Rust -- 2.42.1