From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 169F738582A6 for ; Tue, 30 Jan 2024 12:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 169F738582A6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 169F738582A6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616657; cv=none; b=Vo0s4dQkC4Ac8cdXumLqi8IQKe/r9qzatO/Wlx2COH5STyZAwaw2MVlB+Jnn+yIQ65xXiRCeKuCHlUYjhWzZed1lFQGIZyFMbWNTQcnPZcABCeXY0ss3EcrgbyZUYbdFbbYNMtagMCZJXRi1pvod1+O6C5ExRlIwGnLClcVnMFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616657; c=relaxed/simple; bh=rkkQtLfG9Cc8vbbSITDgLNbuoKQIi8V40f1u5tvuEH4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=I85vnKojKpTP8UJ4RUp8ePdg8RPGDMwsZK1CSyeRNAagZ8ODJ9p09kK4Ktqd4VvigadzI+yVzORmRWD7RsyudVXQTmIMEDjWAZnBCvpJobp0HKHPIugQkYIFcndIpBG1lp0+T0FDz7lDuerhdugKXihAiW9jJujfGz06kB3WB04= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2cf206e4d56so41755231fa.3 for ; Tue, 30 Jan 2024 04:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616651; x=1707221451; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=RsFUMNZGNUmy6CpSPO7EBBkfBGnB+T1WGXUzR7rBCcY=; b=S0vfTewhdaoPdRoqiEGrQPLIHnPaFcdAarrJzPs9FWqY/vSoqnvBMCDEXVgDZeaHOe vv8fJBrtSg4FFZbt8PfV9KSPu+IuC5DRJgOGTVmqLN/cdQOxKXmRzYbk+Q7O457SAWSG x7ACZ0rNuNXSrSYe5LJWOzFDRzkPTIbwsF3u8M15cLYKe3X5YfkhUpz25Tcbc0vaXOvY t10N7FvBllxdSpdxzni+lEAae9fA90rPzgivaOfYfqJkAukN082srRtsbJjTYQvlEuNU ex5Wl4sMPIf4z4zpaLs55Obpra+SjovqIhtheg7upSMVKd+x4gjvKY3MIcEZmj+UVJlJ rqAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616651; x=1707221451; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RsFUMNZGNUmy6CpSPO7EBBkfBGnB+T1WGXUzR7rBCcY=; b=jTF9s42VG9BHFyDjO0spd6+cslbyMg6QrJ7zGcserulq0ho2kDGHYqUjsCEXqVX4DM bt5+mXcT3jCziqQJiFCkkxbABqgUeNqq8NNwoXkEwCcJS2FbBIhhCay2tvcWXlG+nEsu +EN8BZSBD4I9snM4DC5LpHVSK0axOcEqUrGlyP409o/0UGOV/GUdN7aYxrIBPFG4WW2B kh3IZGtYp0QotQoiKC+e6C3ETXPAtKtZKVARYrT71twoi6cRNJ40GGISFkHcOYIt7Oyp aktlzZ0pSRmZV/xAAl+imf1teY7S81rzrgX6PEQ4vIizSDlYT7N2hHEEOpbGyu/1kEkb mJUw== X-Gm-Message-State: AOJu0Yx1cZu4gTsg8GOs4KBC/WfsVwwCt4Yo85zAKwfBt19z2e8Bashb X1ZHXoZ6roi0SFubAC3J2OBvIcV3EmRIl6A5Lcm7+I2XJnC52c0XdeBvXbSSSw== X-Google-Smtp-Source: AGHT+IHGYWoHnSytoG+hB9KrOLPt87LrLH5IUaeTb2FxtUX6tihkKAUvGbGLdm3KVbQLYxtuHU0Fsg== X-Received: by 2002:a05:651c:104f:b0:2d0:480b:8d76 with SMTP id x15-20020a05651c104f00b002d0480b8d76mr4143404ljm.47.1706616651509; Tue, 30 Jan 2024 04:10:51 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:10:51 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Subject: [COMMITTED 003/101] gccrs: Fix error emission for self pointers Date: Tue, 30 Jan 2024 13:06:19 +0100 Message-ID: <20240130121026.807464-6-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Pierre-Emmanuel Patry Self pointer checking loop condition was inverted, the latter was therefore never executed. gcc/rust/ChangeLog: * parse/rust-parse-impl.h (Parser::parse_self_param): Fix the loop exit condition. Signed-off-by: Pierre-Emmanuel Patry --- gcc/rust/parse/rust-parse-impl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/rust/parse/rust-parse-impl.h b/gcc/rust/parse/rust-parse-impl.h index 0ae89dc3907..1ebe1ed442c 100644 --- a/gcc/rust/parse/rust-parse-impl.h +++ b/gcc/rust/parse/rust-parse-impl.h @@ -7129,7 +7129,7 @@ Parser::parse_self_param () for (auto &s : ptrs) { size_t i = 0; - for (i = 0; i > s.size (); i++) + for (i = 0; i < s.size (); i++) if (lexer.peek_token (i)->get_id () != s[i]) break; if (i == s.size ()) -- 2.42.1