From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 341E53857828 for ; Tue, 30 Jan 2024 12:11:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 341E53857828 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 341E53857828 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616745; cv=none; b=u7qhDo0Bk4N/OLjR56eaalRnVDG4fqjFmemIUb9NVPGDXkYDQQkM5OxXaoFZMVZPb/izq7a2oc+4S3h4ttTnkHXgZ7LP4NaVIIiOVPHBaE5pOiwibVJ+JdVfQzdJPza4ClGdqjMKUrmSncvQyA046BPR9mxX56K2EooMubzFLNA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706616745; c=relaxed/simple; bh=RGk69GUgqWBGj6naMDjZCTGTN3doxnH6LyRz1tyB8e8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iWIYvaTMmJx/89WZm3LR22EaDnd8np2kCMUjSMEgGNn8cZRoiymY3BQ/rVQYDIHdQNfSeaRAFoaMUNJgVl3jazC7/N7qbXP7JBSTpsUaw+DmDV1SG10LMaUY8KcHdAHxSvX3Ru272dcq9/njuW0mRakmfNbaqIuXOxVBKlQb/mw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3392b045e0aso2833595f8f.2 for ; Tue, 30 Jan 2024 04:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706616704; x=1707221504; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=nHOOgBmNlsLC5XTuJaLvTqwZfi6D0yvLIM3UiV9Oo4Q=; b=Lj725FSALJVYH29DtYdMxB6bbY5XVxj71eBpT8Y8olanV3OpYIV1Lvakuu1WagpbBj t/gckKW44I7xEnYOPYlVnbHfpoLsjDtORdMPT7MyxPKt+fBmArNsO5PvHHx4Ejy+6uLS d4LPYZ/LJGhjCV6wX4NNtOaeIRbUISgPpc67Ge+zzYfwJczPdiGy3FaaAy72jcLY5hQ1 kMjo3xl0D+Ut1hRHXER40OJIPfDZLTLm+h7OVh44d1HtpVrm5J4Dwcqfz6aaOi1n+/UN MCfHYPl4y+Of8olBLCFp2tPuWhhmg73PNZ4G1ZB2R6nmx1VmSt9RITiWOJew5CtB4kAs SsSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616704; x=1707221504; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nHOOgBmNlsLC5XTuJaLvTqwZfi6D0yvLIM3UiV9Oo4Q=; b=AiwePVtkRx+fHvrM+QsFCDwKt60ub/NzswkRqI8flp4XLZRlJY3ahddYcKHop4kA4k FbBmS3ZuyVekh640stW90xNAK5GmD25wPEtTkNLw65/2q3yCS7Usyx0VwhDVR5iafSd+ aLm7yCC5VvhOiJyOTHF3HKSm8HPPqVv/T0KYtsOMaNca0DFrvHe7jrI6ZVGGTfD1/hru THDNk+DtRZWiZQTpAnjUB+RLT94DJDSy83UGSZ1J8UG9CHfeykN5VQf0hey32no7LeaC yJwz5niRijzSYmHu7o7FLATH8unbSdcM9Sm9DbFRNlT4/P7hlzxw3gffd6O7yVmDxLm/ Z+rg== X-Gm-Message-State: AOJu0YyobwllxMphKYf42YF2xfLHqYQGHYvpNiI2J7hOCOTSxt2fetkd ZYJGMAKJqVLfJ45VHn+Ftd5UMpBohR3lAJTwIzbMltctJk9gsTH0vrUbcNYtvqH+Jn7Ing1md8h tNA== X-Google-Smtp-Source: AGHT+IF2B7SsAAnfqyNNhFoCaERRYk8xnaZ/+PDiyUKd+I2/T6dvCsEfkKZwbtkFwuprRv/lgCdflw== X-Received: by 2002:a05:6000:184d:b0:33a:f27d:c05 with SMTP id c13-20020a056000184d00b0033af27d0c05mr4037486wri.15.1706616704668; Tue, 30 Jan 2024 04:11:44 -0800 (PST) Received: from platypus.localdomain ([62.23.166.218]) by smtp.gmail.com with ESMTPSA id f9-20020a056000036900b00339307d9d31sm10569894wrf.112.2024.01.30.04.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:11:43 -0800 (PST) From: arthur.cohen@embecosm.com To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Jakub Dupak Subject: [COMMITTED 074/101] gccrs: BIR: Fix missed nodiscard Date: Tue, 30 Jan 2024 13:07:30 +0100 Message-ID: <20240130121026.807464-77-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240130121026.807464-2-arthur.cohen@embecosm.com> References: <20240130121026.807464-2-arthur.cohen@embecosm.com> Reply-To: arthur.cohen@embecosm.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Jakub Dupak gcc/rust/ChangeLog: * checks/errors/borrowck/rust-bir-builder-internal.h: Replace nodiscard. * checks/errors/borrowck/rust-bir-place.h: Replace nodiscard. Signed-off-by: Jakub Dupak --- gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h | 4 ++-- gcc/rust/checks/errors/borrowck/rust-bir-place.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h b/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h index f33eb075244..cd611514776 100644 --- a/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h +++ b/gcc/rust/checks/errors/borrowck/rust-bir-builder-internal.h @@ -261,12 +261,12 @@ protected: // CFG helpers protected: // HIR resolution helpers template - [[nodiscard]] TyTy::BaseType *lookup_type (T &hir_node) const + WARN_UNUSED_RESULT TyTy::BaseType *lookup_type (T &hir_node) const { return lookup_type (hir_node.get_mappings ().get_hirid ()); } - [[nodiscard]] TyTy::BaseType *lookup_type (HirId hirid) const + WARN_UNUSED_RESULT TyTy::BaseType *lookup_type (HirId hirid) const { TyTy::BaseType *type = nullptr; bool ok = ctx.tyctx.lookup_type (hirid, &type); diff --git a/gcc/rust/checks/errors/borrowck/rust-bir-place.h b/gcc/rust/checks/errors/borrowck/rust-bir-place.h index 66b131dee1a..8c2df47c11d 100644 --- a/gcc/rust/checks/errors/borrowck/rust-bir-place.h +++ b/gcc/rust/checks/errors/borrowck/rust-bir-place.h @@ -148,9 +148,9 @@ public: 0); } - [[nodiscard]] PlaceId lookup_or_add_path (Place::Kind kind, - TyTy::BaseType *tyty, - PlaceId parent, size_t id = 0) + WARN_UNUSED_RESULT PlaceId lookup_or_add_path (Place::Kind kind, + TyTy::BaseType *tyty, + PlaceId parent, size_t id = 0) { PlaceId current = 0; if (parent < places.size ()) -- 2.42.1