public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Arthur Cohen <arthur.cohen@embecosm.com>
To: Thomas Schwinge <tschwinge@baylibre.com>,
	Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>,
	gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Subject: Re: build: Use of cargo not yet supported here in Canadian cross configurations
Date: Tue, 16 Apr 2024 10:55:23 +0200	[thread overview]
Message-ID: <2520a162-2e19-454f-ac39-46644da02e74@embecosm.com> (raw)
In-Reply-To: <87wmoylrrg.fsf@euler.schwinge.ddns.net>

Hi Thomas,

On 4/15/24 14:44, Thomas Schwinge wrote:
> Hi!
> 
> On 2024-04-15T13:14:42+0200, I wrote:
>> On 2024-04-08T18:33:38+0200, pierre-emmanuel.patry@embecosm.com wrote:
>>> The rust frontend requires cargo to build some of it's components,
>>
>> In GCC upstream still: 's%requires%is going to require'.  ;-)
>>
>>> it's presence was not checked during configuration.
>>
>> After confirming the desired semantics/diagnostics, I've now pushed this
>> to trunk branch in commit 3e1e73fc99584440e5967577f2049573eeaf4596
>> "build: Check for cargo when building rust language".
> 
> On top of that, OK to push the attached
> "build: Use of cargo not yet supported here in Canadian cross configurations"?

Patch looks good, thanks :) Do you want me to propagate the change to 
our development repo or would you like to open a pull-request yourself?

Best,

Arthur

> 
> 
> Grüße
>   Thomas
> 
> 

  parent reply	other threads:[~2024-04-16  8:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 16:33 [PATCH] build: Check for cargo when building rust language pierre-emmanuel.patry
2024-04-09  7:42 ` Richard Biener
2024-04-09  7:47 ` John Paul Adrian Glaubitz
2024-04-09  8:00   ` Jakub Jelinek
2024-04-09  8:29     ` John Paul Adrian Glaubitz
2024-04-09 10:40   ` Arthur Cohen
2024-04-09  8:55     ` Iain Sandoe
2024-04-09 12:01       ` Arthur Cohen
2024-04-09 10:09         ` Iain Sandoe
2024-04-09 13:53           ` Arthur Cohen
2024-04-09 14:12 ` Andrew Pinski
2024-04-09 14:25   ` Arthur Cohen
2024-04-15 11:14 ` Thomas Schwinge
2024-04-15 11:50   ` build: Don't check for host-prefixed 'cargo' program (was: [PATCH] build: Check for cargo when building rust language) Thomas Schwinge
2024-04-15 12:18     ` build: Don't check for host-prefixed 'cargo' program Pierre-Emmanuel Patry
2024-04-15 12:44   ` build: Use of cargo not yet supported here in Canadian cross configurations (was: [PATCH] build: Check for cargo when building rust language) Thomas Schwinge
2024-04-15 16:36     ` build: Use of cargo not yet supported here in Canadian cross configurations Pierre-Emmanuel Patry
2024-04-16  8:55     ` Arthur Cohen [this message]
2024-04-16 20:34 ` [PATCH] build: Check for cargo when building rust language Andrew Pinski
2024-04-17  8:13   ` Rainer Orth
2024-04-17 14:54     ` Arthur Cohen
2024-04-23  8:52       ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2520a162-2e19-454f-ac39-46644da02e74@embecosm.com \
    --to=arthur.cohen@embecosm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=pierre-emmanuel.patry@embecosm.com \
    --cc=tschwinge@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).