From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 111443858416 for ; Thu, 14 Sep 2023 13:40:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 111443858416 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-404732a0700so5517605e9.0 for ; Thu, 14 Sep 2023 06:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1694698854; x=1695303654; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wa2TWYWuJ8Yl+EDx2CiOoCaEmoUkEvoge+ljp3vFV54=; b=IsLNCkJEzxsHEqkRk58T5VBNJJHxyJYDJrOhw981HH+HIrrwusDldfc5yiCmVC67iE lEqD+WPSxLQlLlAXeVvvS1SZdsCYoib7fLzmJv8rHJTWiy2BjnLEzfSQa4iAQ16EcMzD ZY53c4Qm9QB7nbqQ2aB3XigjSTBkfX2rareyF+weluzHRmhkgv6DqEenWkzzb5cf655M Z6loJ7mtR0+uQAq+8OvrQVPg0FWptLe9q/yVpCXXwpa5yNxpRAt5rmQszk0c0nRfoj/U F+tj8sQpDEmFT5BQA+xRybagGcy7i5jtV7suCxoyLUxdtMmEoLNmgb2HQkQmdrEWrtPf Vh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694698854; x=1695303654; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wa2TWYWuJ8Yl+EDx2CiOoCaEmoUkEvoge+ljp3vFV54=; b=O6fHCCQu96mIr4ijx4UIKfwhElz8ig6BaEqvL//WeH3XDyq0DBMlhdHS09YCjqfv6h b+gN8+pLtGx2SgbzR1f6lkTSUILH1DGU26KfrZ86DJt/dskjtkgyjrVt0P3Cpv5a1Dz7 HtCVl9XKva7H/r5RIveV53+O4W/+vDyqoSF7s/dibatjWd4nhW7htb2mcxpDjAfPR8NV XJnhUMAGVveo8uhjOHrsoegMpeEWN8q0YI7GsgO/zf3O7t9SweNyHqj/woX4Uqb/Jdep Acfdq0Otkf+olCEohoO2JKf5kNubxbkXMZlrM0wjl1emg/+pHmcuaeVr0fsDbpSe4mfw rz5g== X-Gm-Message-State: AOJu0YxdIgpF/sCyQgtC/OrW45+/6sDrzQgFCFDIaN4FA0S+lT1aL/25 kUeImXEgJNIpAM7be2YVQsJh X-Google-Smtp-Source: AGHT+IG/88+oXlHKQJoUJz657RlbxuvA/HEXIpaF1Y3g8xgyVncfGZQp40V+8liuB0R5WfpRS6Retg== X-Received: by 2002:adf:ecc8:0:b0:319:7b66:7800 with SMTP id s8-20020adfecc8000000b003197b667800mr4710595wro.55.1694698853377; Thu, 14 Sep 2023 06:40:53 -0700 (PDT) Received: from ?IPV6:2001:861:5e4c:3bb0:b31f:44c6:4645:f155? ([2001:861:5e4c:3bb0:b31f:44c6:4645:f155]) by smtp.gmail.com with ESMTPSA id c1-20020a5d4141000000b0031f300a4c26sm1801638wrq.93.2023.09.14.06.40.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 06:40:53 -0700 (PDT) Message-ID: <284d026b-fdfd-db78-fdcf-48154e628f5c@embecosm.com> Date: Thu, 14 Sep 2023 15:44:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCHSET] Reintroduce targetrustm hooks To: Richard Biener , Iain Buclaw Cc: gcc-patches@gcc.gnu.org, "gcc-rust@gcc.gnu.org" References: <606cbf6f-1c99-9beb-1e98-809cb57df1c6@embecosm.com> <1694634574.b90urzerf1.astroid@pulse.none> Content-Language: en-US From: Arthur Cohen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/14/23 12:12, Richard Biener wrote: > On Wed, Sep 13, 2023 at 10:14 PM Iain Buclaw via Gcc-patches > wrote: >> >> Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm: >>> Alright, was not expecting to mess up this patchset so bad so here we go: >>> >>> This patchset reintroduces proper targetrustm hooks without the old >>> problematic mess of macros we had, which had been removed for the first >>> merge of gccrs upstream. >>> >>> Tested on x86-64 GNU Linux, and has also been present in our development >>> repository for a long time - added by this pull-request from Iain [1] >>> which was merged in October 2022. >>> >>> Ok for trunk? >>> >>> [PATCH 01/14] rust: Add skeleton support and documentation for >>> [PATCH 02/14] rust: Reintroduce TARGET_RUST_CPU_INFO hook >>> [PATCH 03/14] rust: Reintroduce TARGET_RUST_OS_INFO hook >>> [PATCH 04/14] rust: Implement TARGET_RUST_CPU_INFO for i[34567]86-*-* >>> [PATCH 05/14] rust: Implement TARGET_RUST_OS_INFO for *-*-darwin* >>> [PATCH 06/14] rust: Implement TARGET_RUST_OS_INFO for *-*-freebsd* >>> [PATCH 07/14] rust: Implement TARGET_RUST_OS_INFO for *-*-netbsd* >>> [PATCH 08/14] rust: Implement TARGET_RUST_OS_INFO for *-*-openbsd* >>> [PATCH 09/14] rust: Implement TARGET_RUST_OS_INFO for *-*-solaris2*. >>> [PATCH 10/14] rust: Implement TARGET_RUST_OS_INFO for *-*-dragonfly* >>> [PATCH 11/14] rust: Implement TARGET_RUST_OS_INFO for *-*-vxworks* >>> [PATCH 12/14] rust: Implement TARGET_RUST_OS_INFO for *-*-fuchsia*. >>> [PATCH 13/14] rust: Implement TARGET_RUST_OS_INFO for >>> [PATCH 14/14] rust: Implement TARGET_RUST_OS_INFO for *-*-*linux*. >>> >> >> Thanks for eventually getting round to this. >> >> As the co-author of this patch series, I'm not going to look at it. >> >> FWIW, these being Rust-specific target changes isolated to just >> Rust-specific files, you should have the automony to commit without >> needing any request for review - at least this is my understanding when >> have made D-specific target changes in the past that have not touched >> common back-end headers. Yes, the reason I sent them in is that they still touch common GCC folders even if the changes are Rust specific - so I did not want to overuse my write rights. >> I'll let someone else confirm and check over the shared parts touched by >> the patch however. > > I confirm. I briefly went over the shared parts and they look OK. Thanks for the review Richard! And thank you Iain for the patches. I will commit them upstream tomorrow. All the best, Arthur > Thanks, > Richard. > >> For reviewers, this is pretty much a mirror of the D front-end's CPU and >> OS-specific target hooks (D has built-in version identifiers, not >> built-in attributes, but both Rust and D are otherwise the same in the >> kind of information exposed by them). >> >>> [1]: https://github.com/Rust-GCC/gccrs/pull/1543 >>> >> >> The other GitHub pull request that added these is here. >> >> https://github.com/Rust-GCC/gccrs/pull/1596 >> >> Regards, >> Iain.