From: Philip Herron <philip.herron@embecosm.com>
To: gcc-rust@gcc.gnu.org
Subject: Re: Using unsafe blocks in let expressions
Date: Fri, 23 Jul 2021 12:23:38 +0100 [thread overview]
Message-ID: <36a1be0c-7c7c-ffe4-c7a7-ebde08d33af0@embecosm.com> (raw)
In-Reply-To: <YPipMlAPpAVpwmhY@wildebeest.org>
[-- Attachment #1.1: Type: text/plain, Size: 1001 bytes --]
On 22/07/2021 00:09, Mark Wielaard wrote:
> On Wed, Jul 21, 2021 at 11:09:38PM +0200, Mark Wielaard wrote:
>> + Location locus;
>> + if (!pratt_parse)
>> + {
>> + Location locus = lexer.peek_token ()->get_locus ();
> Oops, shadowed locus. Fixed patch attached, and also at
> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=let-unsafe
>
>
>
This was merged yesterday https://github.com/Rust-GCC/gccrs/pull/582
I also merged a simple test case to show the parser is working
https://github.com/Rust-GCC/gccrs/pull/587
The final PR relating to this was:
https://github.com/Rust-GCC/gccrs/pull/589 in the type checker assumed
all dereference expressions were going to be for ReferenceTypes but this
extended it to support pointers. Some work is needed to ensure
derferences and union access outside of match expressions will emit an
error but this is a fairly simple change to make I will update a guide
on how to do this later.
Thanks again
--Phil
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]
prev parent reply other threads:[~2021-07-23 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 21:09 Mark Wielaard
2021-07-21 23:09 ` Mark Wielaard
2021-07-23 11:23 ` Philip Herron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a1be0c-7c7c-ffe4-c7a7-ebde08d33af0@embecosm.com \
--to=philip.herron@embecosm.com \
--cc=gcc-rust@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).