From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 442A53858C78 for ; Tue, 16 Apr 2024 08:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 442A53858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 442A53858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713257893; cv=none; b=MdKTqot2knoZzxFbeNMpbSqjiYHZRFY6ip7cTS/12cupYDuHl4V5HpniT1TTTfIukUK5f690MBRVJuAErkGwl2pncoBrLXzYsgR9fnypLKyXlBIEByBu24lvuYfQa4vZ8NjsuGBzd2XcotKJmyq0Q6ScnKp+JMihXpAZ7IlKhJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713257893; c=relaxed/simple; bh=rjGzr4+zRIXv4y9YrM5IXkvxOfbncyRuRsb2NjgO1xM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ebetjU8ojabmCxImGfgCNEIxQ6gcVDU/fJNYDs9TF1N68YX0aZauTmqinkjO9hyTtaQKbVD55iTpDNHLDaj5F93f27u1NMMauLyhAMkzhnwu1DuAp7UY32SPxyb9ySGOE4gmWWqoRSnFTS9ztB6ExEdKegD9a9BUTdjgbs37c4o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-57042f84cabso602831a12.2 for ; Tue, 16 Apr 2024 01:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1713257889; x=1713862689; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rQiJj5CM8ow/qkhCnXmdqqZ016kXyEUPe+3XQ5AeZPw=; b=IWckpJoALym4Thvx5OOPySSrs/be2C0DafhR8+jad7ckImZG7DDKarBYnAKwUnIB6+ x660+bC5q4gKp92paXMksgSLMKEPYEBX+RjM4aNgLwVeMLCp/ehNk0j1hGCJ9ao+Bfsp 7LakYCeEI5BUNQeNbtEA8gJNNBShkPlvgrw3oPGboCGUm78IGFl60KpLstF5fDn2vJT8 ao1ymjwHph5aGKdMp9EOKTSX1koI3ykMApr2n6wV1vhqmu2M39JeAOfvl69mregAIqMz 5saWYyt2IZyRdjxvUD1wY+Gd0NZqkxRMiJwOWYjjlEtBxPUieiim+EtxSOY3lg80uM0q MZjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713257889; x=1713862689; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQiJj5CM8ow/qkhCnXmdqqZ016kXyEUPe+3XQ5AeZPw=; b=Dh1LHOsFek7Q8fSEXhUTF1LCI2LlzzTuyaHxLS6W4N6IJEpXec8YMqGJTO3qRYy/Rn WMEVa7KkWc6dEJeIYXaMn5up/+oluFyEF2t0h1bv7WhDhUmYllZAfa7HdRvNcLcDlluF eTpwE79InJe9Gl3xtopscjWwx+WSfo0PROuHjw/pxu87E/82nDOOgxXe4jc0y+I+rzRX rqbaZvXrb8PJj7d0nrfCuWiBNugu0qVjvSkcw0kDKRbk8DbgXUOC9d9zsvAdrLHq7F4P UPYn5+KQSfmCyY9Y4476pbEe/h2IMOFtn3LHbRELkl85CCCnGTP+J4fNhF5AePX5Inq0 CEbw== X-Forwarded-Encrypted: i=1; AJvYcCVvyz02F/XJiGd3htzmTao/2gBYmfS+t6+WjNjo+ZVBBs8gHgAKk+CX/MYhGvKwf0/hRb+B4iMGQjXq33gb7iiY+YzlJw== X-Gm-Message-State: AOJu0YwH1HOPyY+lEwsX/XUART0r8EjydadZ2BYsNcN6E4Vh/XKhlJpM /BKnMyDw5zroFLJxT/NqtFgko7Gy7Iv9Y4PMkKRVRyHqL4R3eBlLfNx4Ore2fw== X-Google-Smtp-Source: AGHT+IFubjkRMXSeTLbltZKIu1MjurCVugL6Aa1hrJACWHWQDBn/StPi4ugnW8KiI7jYxtdQGPxa0Q== X-Received: by 2002:a50:9f08:0:b0:56c:2f3a:13a7 with SMTP id b8-20020a509f08000000b0056c2f3a13a7mr8103410edf.25.1713257888959; Tue, 16 Apr 2024 01:58:08 -0700 (PDT) Received: from ?IPV6:2a04:cec2:25:1912:48e9:e366:cc1:fe0d? ([2a04:cec2:25:1912:48e9:e366:cc1:fe0d]) by smtp.gmail.com with ESMTPSA id dc3-20020a056402310300b0056e672573e5sm5857409edb.88.2024.04.16.01.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 01:58:08 -0700 (PDT) Message-ID: <72f2b604-fd78-4504-96f7-54a1dcdd2f08@embecosm.com> Date: Tue, 16 Apr 2024 10:58:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gcc r14-7544] gccrs: libproc_macro: Build statically Content-Language: en-US To: Thomas Schwinge , gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry References: <20240116174310.2CC5A3858439@sourceware.org> <87h6g2evei.fsf@euler.schwinge.ddns.net> From: Arthur Cohen In-Reply-To: <87h6g2evei.fsf@euler.schwinge.ddns.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_LOTSOFHASH,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Morning Thomas, On 4/15/24 13:07, Thomas Schwinge wrote: > Hi! > > On 2024-01-16T17:43:10+0000, Arthur Cohen via Gcc-cvs wrote: >> https://gcc.gnu.org/g:71180a9eed367667e7b2c3f6aea1ee1bba15e9b3 >> >> commit r14-7544-g71180a9eed367667e7b2c3f6aea1ee1bba15e9b3 >> Author: Pierre-Emmanuel Patry >> Date: Wed Apr 26 10:31:35 2023 +0200 >> >> gccrs: libproc_macro: Build statically >> >> We do not need dynamic linking, all use case of this library cover can >> be done statically hence the change. >> >> gcc/rust/ChangeLog: >> >> * Make-lang.in: Link against the static libproc_macro. > >> --- a/gcc/rust/Make-lang.in >> +++ b/gcc/rust/Make-lang.in >> @@ -182,11 +182,14 @@ RUST_ALL_OBJS = $(GRS_OBJS) $(RUST_TARGET_OBJS) >> >> rust_OBJS = $(RUST_ALL_OBJS) rust/rustspec.o >> >> +RUST_LDFLAGS = $(LDFLAGS) -L./../libgrust/libproc_macro >> +RUST_LIBDEPS = $(LIBDEPS) ../libgrust/libproc_macro/libproc_macro.a >> + >> # The compiler itself is called crab1 >> -crab1$(exeext): $(RUST_ALL_OBJS) attribs.o $(BACKEND) $(LIBDEPS) $(rust.prev) >> +crab1$(exeext): $(RUST_ALL_OBJS) attribs.o $(BACKEND) $(RUST_LIBDEPS) $(rust.prev) >> @$(call LINK_PROGRESS,$(INDEX.rust),start) >> - +$(LLINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \ >> - $(RUST_ALL_OBJS) attribs.o $(BACKEND) $(LIBS) $(BACKENDLIBS) >> + +$(LLINKER) $(ALL_LINKERFLAGS) $(RUST_LDFLAGS) -o $@ \ >> + $(RUST_ALL_OBJS) attribs.o $(BACKEND) $(LIBS) ../libgrust/libproc_macro/libproc_macro.a $(BACKENDLIBS) >> @$(call LINK_PROGRESS,$(INDEX.rust),end) > > The 'crab1' compiler is (at least potentially) just one of several > executables that 'gcc/rust/Make-lang.in' may build, which may all have > different library dependencies, etc. Instead of via generic 'RUST_[...]' > variables, those dependencies etc. should therefore be specified as they > are individually necessary. > > I've pushed to trunk branch the following clean-up commits, see attached: > > - commit cb70a49b30f0a22ec7a1b7df29c3ab370d603f90 "Remove 'libgrust/libproc_macro_internal' from 'gcc/rust/Make-lang.in:RUST_LDFLAGS'" > - commit f7c8fa7280c85cbdea45be9c09f36123ff16a78a "Inline 'gcc/rust/Make-lang.in:RUST_LDFLAGS' into single user" > - commit 24d92f65f9ed9b3c730c59f700ce2f5c038c8207 "Add 'gcc/rust/Make-lang.in:LIBPROC_MACRO_INTERNAL'" > - commit e3fda76af4f342ad1ba8bd901a72d811e8357e99 "Inline 'gcc/rust/Make-lang.in:RUST_LIBDEPS' into single user" Thanks, that looks good :) Same question as on the other thread: do you want me to open a PR for these on github or do you want to do it yourself? Kindly, Arthur > > > Grüße > Thomas > >