From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 5B6613836E82; Mon, 20 Nov 2023 14:55:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B6613836E82 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B6613836E82 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700492152; cv=none; b=MUwKEYMrYxwcBHebI/IZfyoLcGDGA2ZTe98YqLpMJRXFEyX/hPejdSqSlRt4nSccH7StqSn1lTlZTvLszqhxQDmij94fkL0K22PeoZyogKNaoQPouSCgZ4FFm6jTo6iAM2yHluqv1O2rha6FQA1Zw4anr+jaiRf6dyKN+1uut1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700492152; c=relaxed/simple; bh=fnZWE0+mUgaij14wbNT7bcmJssu50BeYcVGZdefkAos=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=wB9v+9vfT5TuyJtaQEpxdY+nQOSzrs6sm7B+DeQrAt7itZ00E8Qzr45z9+SCp8gql3jcim18mu6iybfdk57Hpe1XzXPQS/UX46oLNIiahxStMCciAT4WFGsNFeQM+It7Hr3alCrf9eoKxQCuoLPM7Q8FdJYOC54dLPKziCcsvN8= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 8PiToxDwRy+Va8HZVQXxfg== X-CSE-MsgGUID: hiLDF52MSwyF6eCAEZkD9Q== X-IronPort-AV: E=Sophos;i="6.04,214,1695715200"; d="scan'208";a="26285656" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 20 Nov 2023 06:55:49 -0800 IronPort-SDR: jSufLUrgAfxwbVnkN65MJiTMotjfJVI7oRP+ySEY+IqOegGSbsL9CDrFYYHrPlp8E1M9GWIKHG 08lBL/uuXHHXD9AmztvsezdCmEsAzJMDj7hSENDjcuN5w3Mn0TJBI1yKQsoA8CfYKWBY2mcqn/ YnVESOFdmyc4fiHqELDJUfq/xnqEDbOow3V62hO/+xvY0QPdXMWFHgs9o3ivtN4sTKo2wQXY3i 5q5Vt+A9TBjqQ6ykQZskl3a25hQ8tOe0FP6rn2bOcSDtgCXHEn+cVrv8jT8VMRoHDZgq3/Jr0P wWs= From: Thomas Schwinge To: Arthur Cohen , Pierre-Emmanuel Patry CC: , Subject: GCC/Rust libgrust-v2/to-submit branch (was: [PATCH 2/3] build: Add libgrust as compilation modules) In-Reply-To: <87wmv7ztkf.fsf@euler.schwinge.homeip.net> References: <20230920120311.14892-1-arthur.cohen@embecosm.com> <20230920120311.14892-3-arthur.cohen@embecosm.com> <871qek608j.fsf@euler.schwinge.homeip.net> <87wmv7ztkf.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Mon, 20 Nov 2023 15:55:42 +0100 Message-ID: <871qcktqxd.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! Arthur and Pierre-Emmanuel have prepared a GCC/Rust libgrust-v2/to-submit branch: . In that one, most of the issues raised have been addressed, and which I've now successfully "tested" in my different GCC configurations, requiring just one additional change (see end of this email). I'm using "tested" in quotes here, as libgrust currently is still missing its eventual content, and still is without actual users, so we may still be up for surprises later on. ;-) On 2023-10-27T22:41:52+0200, I wrote: > On 2023-09-27T00:25:16+0200, I wrote: >> don't we also directly need to >> incorporate here a few GCC/Rust master branch follow-on commits, like: >> >> - commit 171ea4e2b3e202067c50f9c206974fbe1da691c0 "fixup: Fix bootstra= p build" >> - commit 61cbe201029658c32e5c360823b9a1a17d21b03c "fixup: Fix missing = build dependency" > > I've not yet run into the need for these two. Let's please leave these > out of the upstream submission for now, until we understand what exactly > these are necessary for. (Still the same.) > However: > >> - commit 6a8b207b9ef7f9038e0cae7766117428783825d8 "libgrust: Add depen= dency to libstdc++" > > ... this one definitely is necessary right now; see discussion in > > "Disable target libgrust if we're not building target libstdc++". This one still isn't in the GCC/Rust libgrust-v2/to-submit branch -- but having now tested that branch, I'm now no longer seeing the respective build failure. Isn't that change "libgrust: Add dependency to libstdc++" still necessary, conceptually? (Maybe we're just lucky, currently?) I'll be sure to re-test in my different GCC configurations once libgrust gains actual content and use. (..., which might then re-expose the original problem?) > And: > >> (Not sure if all of these are necessary and/or if that's the complete >> list; haven't looked up the corresponding GCC/Rust GitHub PRs.) >> >>> --- a/gcc/rust/config-lang.in >>> +++ b/gcc/rust/config-lang.in >> >>> +target_libs=3D"target-libffi target-libbacktrace target-libgrust" >> >> Please don't add back 'target-libffi' and 'target-libbacktrace' here; >> just 'target-libgrust'. (As is present in GCC/Rust master branch, and >> per commit 7411eca498beb13729cc2acec77e68250940aa81 >> "Rust: Don't depend on unused 'target-libffi', 'target-libbacktrace'".) > > ... that change is necessary, too. That's still unchanged in the GCC/Rust libgrust-v2/to-submit branch; please apply to 'gcc/rust/config-lang.in': -target_libs=3D"target-libffi target-libbacktrace target-libgrust" +target_libs=3Dtarget-libgrust Then, still should re-order the commits so that (re)generation of auto-generated files comes before use of libgrust (so that later bisection doesn't break), and move the 'contrib/gcc_update' update into the commit that adds the auto-generated files. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955