From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id ACE403850432 for ; Tue, 13 Jul 2021 13:30:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACE403850432 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: NWkTrh4IokqaXbO4JpKpBg5vlLypxa9gRblPXTXnJREtrr0kMx6vsm2DTz4qX9B9mWRDmxdhOZ 2+jYFQHW+67LT4rgYQFCIf5fyw9hGRe4MH8gcqp/Yyr6XWat2HdCgWP5BQdhHN7etdslADk5Ft Yo0XZ18OtD76lcE1xx39ldMyoqq29mYGWEnYQorEUgHn40HsC3DD366rWnov8qahYl3iZou2k6 J7zYnTMcvmN4Qjxe3JDHdF1w5/y9bKQ06MYzSMLRDZB9NuOqM6XkVDcAB61MfxHRfKsh+yGaXj PDI= X-IronPort-AV: E=Sophos;i="5.84,236,1620720000"; d="scan'208";a="63466523" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 13 Jul 2021 05:30:14 -0800 IronPort-SDR: 6ZPa5HCFDsgSLGML+I0woi1l6gueHX68rj2qzRikg4Uz0FPAyX69TxaJhsvljF1Fb3mMA3ZhQv c4LIGLnb/1OvRUR84sU9duIKiXm2HPwlXx24djhZyZ2FFMqlSpFFOndKoJ9La9JvcMNlSaHdQ2 lfUKvSOJaPb2dFttGXI5CdOydAlFpiwyEVll/fM3r86+obDVeAIuoFm9fm7MHWVNrFG/pZXR2T XDnG4gSMyVvuUAcVH92hwvkH4LFtQPKvMXIecXDfuzBtalaeUB6RHLIcVJ8imz2Y0gFmsTmABy Mvg= From: Thomas Schwinge To: Mark Wielaard , Philip Herron , Subject: Re: New contributor tasks In-Reply-To: References: <20210711201018.389798-1-mark@klomp.org> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Tue, 13 Jul 2021 15:30:06 +0200 Message-ID: <871r829w9t.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 13:30:17 -0000 Hi! On 2021-07-13T00:44:13+0200, Mark Wielaard wrote: > On Mon, Jul 12, 2021 at 11:06:01AM +0100, Philip Herron wrote: >> The main one that sticks out in my mind is the AST, HIR dumps which are >> a bit of a mess at the moment. > > The AST dump (--rust-dump-parse) was actually useful for checking the > comment doc strings, but it could certainly be improved. Ideally it > would be structured in a way that can easily be used in tests. Right. Already a while ago, I had run into the same (for a lexer-level thing), and have early-stages WIP changes to implement dumps for the several GCC/Rust front end stages using the (more or less) standard '-fdump-lang-[...]' flag. These dump files may then be scanned using the usual GCC/DejaGnu testsuite idioms. I plan to complete that work at some later point in time, hopefully not too far out. (Mark, I then actually had planned to add some testcases fore your recent lexer changes.) (My work there is independent of/orthogonal to the S-expression dump format discussed elsewhere.) Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955