public inbox for
 help / color / mirror / Atom feed
From: "Marc Poulhiès" <>
To: David Faust via Gcc-rust <>
Subject: Re: [PATCH] Remove lambda iterators in various HIR classes
Date: Fri, 08 Oct 2021 20:48:15 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (David Faust via Gcc-rust's message of "Fri, 8 Oct 2021 10:49:13 -0700")

David Faust via Gcc-rust <> writes:

> On 10/8/21 10:45, David Faust via Gcc-rust wrote:
>> This patch removes the lambda iterators used in various HIR objects.
>> These iterators make interacting with the IR for static analysis more
>> difficult. Instead, get_X () helpers are added for accessing elements,
>> and uses of the iterators replaced with for loops.
>> The following objects are adjusted in this patch:
>> - HIR::TupleExpr
>> - HIR::StructExprField
>> - HIR::StructStruct
>> - HIR::TupleStruct
>> Fixes: #704, #705, #706, #707
> This also adjusts HIR::ArrayElemsValues, fixing #703.
> Must have lost those lines in the patch prep, sorry.

Hi David,

Thank you for this patch !

As gccrs is relying on github, feel free to open a pull request directly
(if you can/want).

I took care of it (and added the #703 while I was at it), and you can
see that there are some small issues with the indentation:

You need to be logged-in to see the results. If you don't have an
account, you can still apply clang-format by hand :)


      reply	other threads:[~2021-10-08 18:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 17:45 David Faust
2021-10-08 17:49 ` David Faust
2021-10-08 18:48   ` Marc Poulhiès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).