Re: [PATCH] Remove lambda iterators in various HIR classes

["Marc Poulhiès" <dkm+gcc@kataplop.net>]

David Faust via Gcc-rust <gcc-rust@gcc.gnu.org> writes:

> On 10/8/21 10:45, David Faust via Gcc-rust wrote:
>> This patch removes the lambda iterators used in various HIR objects.
>> These iterators make interacting with the IR for static analysis more
>> difficult. Instead, get_X () helpers are added for accessing elements,
>> and uses of the iterators replaced with for loops.
>> The following objects are adjusted in this patch:
>> - HIR::TupleExpr
>> - HIR::StructExprField
>> - HIR::StructStruct
>> - HIR::TupleStruct
>> Fixes: #704, #705, #706, #707
>
> This also adjusts HIR::ArrayElemsValues, fixing #703.
> Must have lost those lines in the patch prep, sorry.

Hi David,

Thank you for this patch !

As gccrs is relying on github, feel free to open a pull request directly
(if you can/want).

I took care of it (and added the #703 while I was at it), and you can
see that there are some small issues with the indentation:

https://github.com/Rust-GCC/gccrs/pull/726/checks?check_run_id=3841896345

You need to be logged-in to see the results. If you don't have an
account, you can still apply clang-format by hand :)

Marc