From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dkm+gcc@kataplop.net>
Received: from gandi.kataplop.net (gandi.kataplop.net [46.226.111.114])
 by sourceware.org (Postfix) with ESMTPS id 2978C3858006
 for <gcc-rust@gcc.gnu.org>; Fri,  8 Oct 2021 18:48:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2978C3858006
Received: from [176.191.105.132] (helo=arrakis)
 by gandi.kataplop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <dkm+gcc@kataplop.net>)
 id 1mYuut-0001uv-4b; Fri, 08 Oct 2021 20:48:23 +0200
From: Marc =?utf-8?Q?Poulhi=C3=A8s?= <dkm+gcc@kataplop.net>
To: David Faust via Gcc-rust <gcc-rust@gcc.gnu.org>
Subject: Re: [PATCH] Remove lambda iterators in various HIR classes
References: <20211008174507.10534-1-david.faust@oracle.com>
 <883ae628-cbbe-946f-a5f0-32ed2e951975@oracle.com>
Date: Fri, 08 Oct 2021 20:48:15 +0200
In-Reply-To: <883ae628-cbbe-946f-a5f0-32ed2e951975@oracle.com> (David Faust
 via Gcc-rust's message of "Fri, 8 Oct 2021 10:49:13 -0700")
Message-ID: <87mtnjjqts.fsf@arrakis.kataplop.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_score: -1.0
X-Spam_bar: -
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-rust@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: gcc-rust mailing list <gcc-rust.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-rust>,
 <mailto:gcc-rust-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-rust/>
List-Post: <mailto:gcc-rust@gcc.gnu.org>
List-Help: <mailto:gcc-rust-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-rust>,
 <mailto:gcc-rust-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Oct 2021 18:48:27 -0000


David Faust via Gcc-rust <gcc-rust@gcc.gnu.org> writes:

> On 10/8/21 10:45, David Faust via Gcc-rust wrote:
>> This patch removes the lambda iterators used in various HIR objects.
>> These iterators make interacting with the IR for static analysis more
>> difficult. Instead, get_X () helpers are added for accessing elements,
>> and uses of the iterators replaced with for loops.
>> The following objects are adjusted in this patch:
>> - HIR::TupleExpr
>> - HIR::StructExprField
>> - HIR::StructStruct
>> - HIR::TupleStruct
>> Fixes: #704, #705, #706, #707
>
> This also adjusts HIR::ArrayElemsValues, fixing #703.
> Must have lost those lines in the patch prep, sorry.

Hi David,

Thank you for this patch !

As gccrs is relying on github, feel free to open a pull request directly
(if you can/want).

I took care of it (and added the #703 while I was at it), and you can
see that there are some small issues with the indentation:

https://github.com/Rust-GCC/gccrs/pull/726/checks?check_run_id=3841896345

You need to be logged-in to see the results. If you don't have an
account, you can still apply clang-format by hand :)

Marc