From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dkm@kataplop.net>
Received: from gandi.kataplop.net (gandi.kataplop.net [46.226.111.114])
 by sourceware.org (Postfix) with ESMTPS id BC6E03855025
 for <gcc-rust@gcc.gnu.org>; Sun, 27 Jun 2021 19:17:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC6E03855025
Received: from [176.191.105.132] (helo=arrakis)
 by gandi.kataplop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <dkm@kataplop.net>)
 id 1lxaHB-0006Ap-6Y; Sun, 27 Jun 2021 21:17:05 +0200
From: Marc <dkm@kataplop.net>
To: Mark Wielaard <mark@klomp.org>
Cc: gcc-rust@gcc.gnu.org,  tom@tromey.com
Subject: Re: [PATCH] Fix inner attribute parsing
References: <20210627151202.238046-1-mark@klomp.org>
Date: Sun, 27 Jun 2021 21:17:04 +0200
In-Reply-To: <20210627151202.238046-1-mark@klomp.org> (Mark Wielaard's message
 of "Sun, 27 Jun 2021 17:12:02 +0200")
Message-ID: <87pmw73yof.fsf@arrakis.kataplop.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_score: -1.0
X-Spam_bar: -
X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-rust@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: gcc-rust mailing list <gcc-rust.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-rust>,
 <mailto:gcc-rust-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-rust/>
List-Post: <mailto:gcc-rust@gcc.gnu.org>
List-Help: <mailto:gcc-rust-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-rust>,
 <mailto:gcc-rust-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jun 2021 19:17:09 -0000

Mark Wielaard <mark@klomp.org> writes:

> parse_inner_attribute tried to skip the right square token twice. This caused odd error
> messages in case there were multiple inner attributes. This bug masked another bug in
> parse_attr_input where when the (optional) attr input was an assignment to a literal
> the parser failed to skip the literal.
>
> The existing top_attr.rs testcase relied on the two bugs cancelling each other out.
> Add a new testcase inner_attributes.rs for the first bug.
>
> Resolves: https://github.com/Rust-GCC/gccrs/issues/510

Hi Mark,

Sent to GH: https://github.com/Rust-GCC/gccrs/pull/530

Thanks :)
Marc