From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id CF179385703A; Wed, 25 Oct 2023 21:40:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF179385703A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF179385703A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.141.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698270052; cv=none; b=b3G0RIwNqwBb0OWYHZZ3+qFR7iEmsvGtv/qwGJ/UXQskQc7zYszAj/eLGQucAwKDAq8CArlgsYrqWj2hgM+WIW+Bp5NFDbAwXQIzRlHdWZC/hdf+SiLl3aEXJ+3Q0Yb6EZ3WKxh3apAQUQ268S58l+uNWbbxJrN1HkNP0d5GZRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698270052; c=relaxed/simple; bh=HmCz8Zpj+XtOUMoPUccVx8L1n7Y1mpnAQRLMnv63fq0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ana2/8uyd+XMMhg7CbyGaCuYsV1+aC1Idn0ifFtiO8/tQ7Y7qyYpP59FAJuVL/4CBe90blebGJdkrYoWG7CoSrD1BiKtomJp63Fy/GN4wWsYrKnevnCS9q0mjF7d/pxEA0d/kB0hVfVK/VPT+LxfpoNIJWvpR0uSPw7eG4vAFfc= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: ypIYPV82RL2EMcMVTryWTw== X-CSE-MsgGUID: F2aqb85KTYaBypdFmpiReQ== X-IronPort-AV: E=Sophos;i="6.03,250,1694764800"; d="scan'208";a="23286264" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 25 Oct 2023 13:40:48 -0800 IronPort-SDR: C+pEMCP5jXfA1hnjNis/dJ7g2Sc1k2XdfGQbE7SRh2RE2CwWYmiQ5h/bRkRpsLG+9oxWrj/YCM rJqy+gbi6ZCQiySjRxnLcGP9hMgViVthW7xoFhv5aMfo+D8bYYjSuSZWxY9/gu0RUzi0cVu3Ni pSjnbcAag75G/n+lHROZy2BxY40k8Egyau3XQpIpRfvxWm/PGdN6rffHMkjc9bgWkS79aOdNz6 XWX73i0R+1o9rVEvFfg1wFhj1Lt8W1/javQntliq2SX6i+v/LtGnfPJ8OSNcq87aQlAUBaJtSS lj8= From: Thomas Schwinge To: Arthur Cohen , Pierre-Emmanuel Patry CC: , , Richard Biener Subject: Re: [PATCH v2 3/4] build: Add libgrust as compilation modules In-Reply-To: <20231025110658.1232737-5-arthur.cohen@embecosm.com> References: <20231025110658.1232737-1-arthur.cohen@embecosm.com> <20231025110658.1232737-5-arthur.cohen@embecosm.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Wed, 25 Oct 2023 23:40:40 +0200 Message-ID: <87sf5y1iuf.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-10-25T13:06:48+0200, Arthur Cohen wrote= : > From: Pierre-Emmanuel Patry > > Define the libgrust directory as a host compilation module as well as > for targets. I don't see a response to Richard's comments: . Re "doesn't build libgrust if [Rust is not enabled]", I suppose (but have not checked) this works for the *target* libgrust module via 'gcc/rust/config-lang.in:target_libs' requesting 'target-libgrust' only if the Rust language is enabled? I don't know what enables/disables the *host* libgrust build? My comments: don't seem to have been addressed? Also, don't you first have to get in "build: Regenerate build files" before the 'gcc/rust/config-lang.in:target_libs' change, to avoid breaking bisection? Maybe, after all, don't have a separate "build: Regenerate build files" commit, but instead do the regeneration as part of the commits adding the source files, in usual GCC style? And then, the 'contrib/gcc_update' change that's currently in "libgrust: Add entry for maintainers and stub changelog file" should be part of the commit that actually adds the files referenced therein. Gr=C3=BC=C3=9Fe Thomas > ChangeLog: > > * Makefile.def: Add libgrust as host & target module. > * configure.ac: Add libgrust to host tools list. > > gcc/rust/ChangeLog: > > * config-lang.in: Add libgrust as a target module for the rust > language. > > Signed-off-by: Pierre-Emmanuel Patry > --- > Makefile.def | 2 ++ > configure.ac | 3 ++- > gcc/rust/config-lang.in | 2 ++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Makefile.def b/Makefile.def > index 15c068e4ac4..929a6f0a08e 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -149,6 +149,7 @@ host_modules=3D { module=3D libcc1; extra_configure_f= lags=3D--enable-shared; }; > host_modules=3D { module=3D gotools; }; > host_modules=3D { module=3D libctf; bootstrap=3Dtrue; }; > host_modules=3D { module=3D libsframe; bootstrap=3Dtrue; }; > +host_modules=3D { module=3D libgrust; }; > > target_modules =3D { module=3D libstdc++-v3; > bootstrap=3Dtrue; > @@ -192,6 +193,7 @@ target_modules =3D { module=3D libgm2; lib_path=3D.li= bs; }; > target_modules =3D { module=3D libgomp; bootstrap=3D true; lib_path=3D.l= ibs; }; > target_modules =3D { module=3D libitm; lib_path=3D.libs; }; > target_modules =3D { module=3D libatomic; bootstrap=3Dtrue; lib_path=3D.= libs; }; > +target_modules =3D { module=3D libgrust; }; > > // These are (some of) the make targets to be done in each subdirectory. > // Not all; these are the ones which don't have special options. > diff --git a/configure.ac b/configure.ac > index 692dc716343..b2a5511bab1 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -133,7 +133,7 @@ build_tools=3D"build-texinfo build-flex build-bison b= uild-m4 build-fixincludes" > > # these libraries are used by various programs built for the host enviro= nment > #f > -host_libs=3D"intl libiberty opcodes bfd readline tcl tk itcl libgui zlib= libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf = libsframe" > +host_libs=3D"intl libiberty opcodes bfd readline tcl tk itcl libgui zlib= libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf = libsframe libgrust " > > # these tools are built for the host environment > # Note, the powerpc-eabi build depends on sim occurring before gdb in or= der to > @@ -164,6 +164,7 @@ target_libraries=3D"target-libgcc \ > target-libada \ > target-libgm2 \ > target-libgo \ > + target-libgrust \ > target-libphobos \ > target-zlib" > > diff --git a/gcc/rust/config-lang.in b/gcc/rust/config-lang.in > index aac66c9b962..8f071dcb0bf 100644 > --- a/gcc/rust/config-lang.in > +++ b/gcc/rust/config-lang.in > @@ -29,4 +29,6 @@ compilers=3D"rust1\$(exeext)" > > build_by_default=3D"no" > > +target_libs=3D"target-libffi target-libbacktrace target-libgrust" > + > gtfiles=3D"\$(srcdir)/rust/rust-lang.cc" > -- > 2.42.0 ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955