From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 67E9E3858D35 for ; Mon, 15 Apr 2024 12:44:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67E9E3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67E9E3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185080; cv=none; b=ntFxzrTIK20ZxSvOuYO8k9zDPuujzIKp2jwBglDlYuGojZ3VVW2TDclUOofaUomD459hnnie+qfWoy0vs2hV8l8YjqG9NWcM+kton2RzzCNhVKVsbS6nMEkr2VuWY9ZA+yfIIc51btmRm+O/X35p+B1t5aPbf/EwxNvvA9t+0TE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185080; c=relaxed/simple; bh=kdPv7DFwtHYZgVwOKewWCHKlI+w/m6Jk3oZ7Rczr/4Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ukJZqG/nyrx8WWt+23g3NV2PwLocrYbmXi6UoFXbl40Mpyl/uyborMtAlxjpQp/7XmY9rmvDlY44PLVH1qhT7+hO5py15cOadgVVHu/FOvOPGJGuiC4Kl/dtsM2qol/jx3x67rAFEb91j0qf+t/Khrn/1R1wS7V7dSJSKFMNFms= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-343eb6cc46bso2210495f8f.2 for ; Mon, 15 Apr 2024 05:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1713185077; x=1713789877; darn=gcc.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=p/0QU8oZtelvyFjqbRDSP6x+dfvJ2BMnE/QgpoGJvOM=; b=MmGxpwIkE7MfHmb4yXkNcR83ing8svtV5nTLH+6sgPkTOiJJ8wSKgp2rMeYFRBEhLj vPeG2+0WSIBzT6yqRA5+JDwvmCWM+GY6OdBD4NyAJbkFXhXfAK1FxYVeJPbntGxa6OJ5 V30dyFit2nWK6nA4xZokrGtaQPi3PGoNeM1cmT9xrw7z2KZ95JUdvSygM1vSKEe3oIgo meoJX6lRoWnJ3KlZRz8Z6P5/1NBexriob365r2Fmq1m3y3GTC9YXBEA5D6+s/dBEyDqL ye93FehRM5Trb9z0A/jnsFBPF8I8hhzdjLSU7pPm3HjhhQLeLuBKssLbJK5SCohLXPky 9sCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713185077; x=1713789877; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p/0QU8oZtelvyFjqbRDSP6x+dfvJ2BMnE/QgpoGJvOM=; b=NQnzuhuzCbBU6ET4yx0kgesL5IvdNfd3Ozq27WzJQEWqZk8R9BPBzpXMmqo7CIorzW cjK2oh1csMSudorabfBbUQVxygHOvNkEdzNvQ8j3zTVOTJN2kyRAmal0zyATNWaERG01 ufXk1i6SCF2wE/P0N+HcaIDIPSh+0F5F+cTbOO1q79EboRg0lieBXQtUiP1DPdBGgUDF YqPvR/4mCgUk4QvRZ/ey1+c8q+mFAl3e+MZogXn5mzCzHuNHUgWQ1S3LVNPiFA1AgNrQ mYpx3OAPgfOimD6cM40Ff+0Nj1Zoh+5nfbKhzZ0gZ9SbrWC0pqOfrToWpizNV9OXNOZT BubA== X-Forwarded-Encrypted: i=1; AJvYcCWoLBLEBOop0WH7kLCum0BJhZBhjff8+LKk4jaJopR0BDxLrSWRxZPB9SsavEBkjn09XZrU00nahtH1DuIM9bAVoSYF/w== X-Gm-Message-State: AOJu0YymGadgLB0770jBIvNgixcEGkjBMG3quHF1j79jx6AedVvp9p29 HfLZmoCo32jdUfi8qNTxv2YDqz+H/reNTrLjTzdFPpJ1Vl4mP5cTBl+KjjMCIZE= X-Google-Smtp-Source: AGHT+IGN2HFqfBHuv6eDdA5XuftKhED6tm8gBtBvftlOCJ3lRXd4z97R7ciD5xziG3Zct/uZqsMADg== X-Received: by 2002:adf:ef8e:0:b0:33e:cf4d:c581 with SMTP id d14-20020adfef8e000000b0033ecf4dc581mr6589358wro.41.1713185077058; Mon, 15 Apr 2024 05:44:37 -0700 (PDT) Received: from euler.schwinge.homeip.net (p200300c8b70ce600fbf8323f8abe0da4.dip0.t-ipconnect.de. [2003:c8:b70c:e600:fbf8:323f:8abe:da4]) by smtp.gmail.com with ESMTPSA id l15-20020a5d560f000000b0033ea499c645sm12080115wrv.4.2024.04.15.05.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 05:44:36 -0700 (PDT) From: Thomas Schwinge To: Pierre-Emmanuel Patry , gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Cc: Arthur Cohen Subject: build: Use of cargo not yet supported here in Canadian cross configurations (was: [PATCH] build: Check for cargo when building rust language) In-Reply-To: <87edb6ev31.fsf@euler.schwinge.ddns.net> References: <20240408163337.303317-2-pierre-emmanuel.patry@embecosm.com> <87edb6ev31.fsf@euler.schwinge.ddns.net> User-Agent: Notmuch/0.30+8~g47a4bad (https://notmuchmail.org) Emacs/29.2 (x86_64-pc-linux-gnu) Date: Mon, 15 Apr 2024 14:44:35 +0200 Message-ID: <87wmoylrrg.fsf@euler.schwinge.ddns.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! On 2024-04-15T13:14:42+0200, I wrote: > On 2024-04-08T18:33:38+0200, pierre-emmanuel.patry@embecosm.com wrote: >> The rust frontend requires cargo to build some of it's components, > > In GCC upstream still: 's%requires%is going to require'. ;-) > >> it's presence was not checked during configuration. > > After confirming the desired semantics/diagnostics, I've now pushed this > to trunk branch in commit 3e1e73fc99584440e5967577f2049573eeaf4596 > "build: Check for cargo when building rust language". On top of that, OK to push the attached "build: Use of cargo not yet supported here in Canadian cross configuration= s"? Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-build-Use-of-cargo-not-yet-supported-here-in-Canadia.patch >From eb38990b4147951dd21f19def43072368f782af5 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 15 Apr 2024 14:27:45 +0200 Subject: [PATCH] build: Use of cargo not yet supported here in Canadian cross configurations ..., until "'cargo' should build for the host system" is resolved. Follow-up to commit 3e1e73fc99584440e5967577f2049573eeaf4596 "build: Check for cargo when building rust language". * configure.ac (have_cargo): Force to "no" in Canadian cross configurations * configure: Regenerate. --- configure | 13 +++++++++++++ configure.ac | 12 ++++++++++++ 2 files changed, 25 insertions(+) diff --git a/configure b/configure index e254aa132b5..e59a870b2bd 100755 --- a/configure +++ b/configure @@ -9179,6 +9179,19 @@ $as_echo "$as_me: WARNING: --enable-host-shared required to build $language" >&2 ;; esac + # Pre-conditions to consider whether cargo being supported. + if test x"$have_cargo" = xyes \ + && test x"$build" != x"$host"; then + # Until + # "'cargo' should build for the host system" is resolved: + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: use of cargo not yet supported here in Canadian cross configurations" >&5 +$as_echo "$as_me: WARNING: use of cargo not yet supported here in Canadian cross configurations" >&2;} + have_cargo=no + else + # Assume that cargo-produced object files are compatible with what + # we're going to build here. + : + fi # Disable Rust if cargo is unavailable. case ${add_this_lang}:${language}:${have_cargo} in yes:rust:no) diff --git a/configure.ac b/configure.ac index 87205d0ac1f..4ab54431475 100644 --- a/configure.ac +++ b/configure.ac @@ -2306,6 +2306,18 @@ directories, to avoid imposing the performance cost of ;; esac + # Pre-conditions to consider whether cargo being supported. + if test x"$have_cargo" = xyes \ + && test x"$build" != x"$host"; then + # Until + # "'cargo' should build for the host system" is resolved: + AC_MSG_WARN([use of cargo not yet supported here in Canadian cross configurations]) + have_cargo=no + else + # Assume that cargo-produced object files are compatible with what + # we're going to build here. + : + fi # Disable Rust if cargo is unavailable. case ${add_this_lang}:${language}:${have_cargo} in yes:rust:no) -- 2.34.1 --=-=-=--