From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6BB143858409 for ; Wed, 6 Sep 2023 14:19:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BB143858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694009970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DvzO8KtS9Y3okStxN4HxnBfrEk8BR0VVHF1QCwmrzKA=; b=Z2J2r/3qjPHeis0eJ2KwgV2PfUIHk1uVAtLS2et9zUUCb+QvLTHHByPEWzUsQObCBAXKLH ytocgFk0Cy4KWVUTR061fixEq38CcpolcjsJ1Mfrm5rvEiIC9naSjCaL83OPl8DQqy5xZ6 iYKe5rmWawbbLQw9YG9ZDeuZndsKXag= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-CCDeg77FOZOp03hk69zDDg-1; Wed, 06 Sep 2023 10:19:28 -0400 X-MC-Unique: CCDeg77FOZOp03hk69zDDg-1 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-48d12558d8aso1105476e0c.0 for ; Wed, 06 Sep 2023 07:19:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694009968; x=1694614768; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DvzO8KtS9Y3okStxN4HxnBfrEk8BR0VVHF1QCwmrzKA=; b=Sw0XBErAvxTqyE221m5cEbjUcMxiMrLHH56jvWodrNPMYcQdTo1MjTLHMWdvctyX9R 3DZJWwlqLXudZYjxNZIZEMnAD6VcBMn41xIV0VKyV7t/D+8fhAqtO/nf8n4g7m8ni+Q0 mDa+UWRQemWdfYjzGcazylmgjx1f3UcP8L4oFzxJ6fqyf2gestweP5zZPEEAeJMI4jPm nULmDUhfD6L93Q82ms7NGuwHGI9RySmT3UOrQgcRXcFHoXSA3DtWk7ItBXs54nx83VWQ kOUTQGsUIk794Eq9GRiVxN72Ps1423YnlJtGlnmslBbEYXrk6hF2UQ/1+7vAj1OGClfD Bojg== X-Gm-Message-State: AOJu0YyE/nfHnxdXY1CLBdhJ3yqyblefYNuUMtQKfW33xahCp5r8PHnH 4X35o7rGPUeEiwrYrjIgR7pyDc18qTHRE37Npo+komL5u3hcScUkjI3hlfm8Ehpddky0T9Zghak xoYPvq9rMHCCKkw== X-Received: by 2002:a1f:e141:0:b0:48d:1ad:c896 with SMTP id y62-20020a1fe141000000b0048d01adc896mr3100405vkg.4.1694009968213; Wed, 06 Sep 2023 07:19:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsPjS8RSm/mttooOxHTtaYgnQlhGH99hkZyPshOIdizBgVZN2v/OZ5gDnoD7myf7n59ilEFA== X-Received: by 2002:a1f:e141:0:b0:48d:1ad:c896 with SMTP id y62-20020a1fe141000000b0048d01adc896mr3100384vkg.4.1694009967937; Wed, 06 Sep 2023 07:19:27 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id v6-20020ac87286000000b00401f7f23ab6sm5332457qto.85.2023.09.06.07.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 07:19:27 -0700 (PDT) Message-ID: <8ec322161f314e3cbf3fa50a1ed3accc0c1dccc3.camel@redhat.com> Subject: Re: [PATCH 2/2] Experiment with adding an error code to an error From: David Malcolm To: Arthur Cohen , gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org Date: Wed, 06 Sep 2023 10:19:26 -0400 In-Reply-To: <20230906135303.3643659-3-arthur.cohen@embecosm.com> References: <20230906135303.3643659-1-arthur.cohen@embecosm.com> <20230906135303.3643659-3-arthur.cohen@embecosm.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-09-06 at 15:53 +0200, Arthur Cohen wrote: > From: David Malcolm This is probably something for the gcc-rust maintainers to review (rather than me self-reviewing with my "diagnostics maintainer" hat on). Doesn't have a ChangeLog entry, FWIW. Doesn't have a signed-off-by, so here's one: Signed-off-by: David Malcolm [...snip...] > diff --git a/gcc/rust/rust-gcc-diagnostics.cc b/gcc/rust/rust-gcc- > diagnostics.cc > index 72d2c068541..58c0a5654ea 100644 > --- a/gcc/rust/rust-gcc-diagnostics.cc > +++ b/gcc/rust/rust-gcc-diagnostics.cc [...snip...] > +void > +rust_be_error_at (const RichLocation &location, const ErrorCode > code, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 const std::string &errmsg) > +{ > +=C2=A0 /* TODO: 'error_at' would like a non-'const' 'rich_location *'.= =C2=A0 The above comment should refer to "error_meta", rather than "error_at"... > */ > +=C2=A0 rich_location &gcc_loc =3D const_cast (location.= get > ()); > +=C2=A0 diagnostic_metadata m; > +=C2=A0 rust_error_code_rule rule (code); > +=C2=A0 m.add_rule (rule); > +=C2=A0 error_meta (&gcc_loc, m, "%s", errmsg.c_str ()); ... to match this call. [...snip...] Otherwise, LGTM, but as I said, this is more in the gcc-rust maintainers' area. Dave