From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id A2BD43858D3C; Thu, 23 Feb 2023 01:01:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2BD43858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 6703433E59; Wed, 22 Feb 2023 20:01:05 -0500 (EST) Received: from naga.localdomain (188-23-63-229.adsl.highway.telekom.at [188.23.63.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id BD54E33E56; Wed, 22 Feb 2023 20:01:04 -0500 (EST) Date: Thu, 23 Feb 2023 02:01:03 +0100 (CET) From: Gerald Pfeifer To: Arthur Cohen cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Subject: Re: [committed 034/103] gccrs: dump: Emit visibility when dumping items In-Reply-To: <20230221120230.596966-35-arthur.cohen@embecosm.com> Message-ID: <9186fa87-a545-39c8-ac71-3d4d7abb6446@pfeifer.com> References: <20230221120230.596966-1-arthur.cohen@embecosm.com> <20230221120230.596966-35-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.10 on 209.68.5.143 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Just noticed this by chance: How does this patch constitute a functional change (that matches the ChangeLog)? It looks it only adds an empty line to the source code? Gerald On Tue, 21 Feb 2023, arthur.cohen@embecosm.com wrote: > From: Arthur Cohen > > gcc/rust/ChangeLog: > > * ast/rust-ast-dump.cc: Emit visibility when dumping items. > --- > gcc/rust/ast/rust-ast-dump.cc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/rust/ast/rust-ast-dump.cc b/gcc/rust/ast/rust-ast-dump.cc > index fdcd97561bb..b7557bdee0c 100644 > --- a/gcc/rust/ast/rust-ast-dump.cc > +++ b/gcc/rust/ast/rust-ast-dump.cc > @@ -835,6 +835,7 @@ void > Dump::visit (Function &function) > { > emit_visibility (function.get_visibility ()); > + > stream << "fn " << function.get_function_name (); > if (function.has_generics ()) > emit_generic_params (function.get_generic_params ());