From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 3ADC83858D37; Fri, 23 Jun 2023 00:04:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3ADC83858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MNeoEU004747; Fri, 23 Jun 2023 00:04:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Ixv0L1QZPBSWF7VpYTi3zngmBBCJoDt5HUlPCdbN1Ms=; b=YEIhQmdy5O/AP8FcziiUY/9z/bgKhFYOnTMGSDgn6sNNx4FAaXVzNjLuiRMEMfzXqc4T IPGYOUQqIHum3WvwDnwSN8yabObicwqMGbf4UtyhnN7DjE6R5oJHW8llyb60cMC5sO80 fpg/0NnqJL7BpPy3YksYAS+Byu05+VTMIfZ+1PkGfHSkWBFeEWmkog1tguAODrFxGG27 ike9sH9fROz+YIxwZd2cHBmFHZMx/ElRSyZ0A9M5Bj7N++eXKuSTfbGOepyBvbW9Usek /zCMIrUKmr9c3y+SmHG5zKYMotvDmpR2NEjAw9Xu+qq7TBFmo4+CWP59JYWs26ZxvRrS mw== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcw94mh66-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 00:04:43 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35MJo29d016703; Thu, 22 Jun 2023 23:38:38 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3r94f6c3n8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:38:38 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MNcbPn4784680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 23:38:37 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9113158056; Thu, 22 Jun 2023 23:38:37 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4C1575803F; Thu, 22 Jun 2023 23:38:37 +0000 (GMT) Received: from [9.61.29.17] (unknown [9.61.29.17]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 23:38:37 +0000 (GMT) Message-ID: <92dc77af-6187-13d4-2d3b-25efb0c87084@linux.ibm.com> Date: Thu, 22 Jun 2023 18:38:36 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/2] rust: update usage of TARGET_AIX to TARGET_AIX_OS Content-Language: en-US To: Paul E Murphy , Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org References: <20230616160002.1854983-1-murphyp@linux.ibm.com> <20230616160002.1854983-2-murphyp@linux.ibm.com> <87a5wv3kxd.fsf@euler.schwinge.homeip.net> <517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com> From: Peter Bergner In-Reply-To: <517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: x479wa8WR_sC_lwn7XOxsSIAt0Ertg20 X-Proofpoint-GUID: x479wa8WR_sC_lwn7XOxsSIAt0Ertg20 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_17,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220203 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/21/23 11:20 AM, Paul E Murphy via Gcc-patches wrote: > > > On 6/19/23 3:39 AM, Thomas Schwinge wrote: >> Hi Paul! >> >> On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" wrote: >>> This was noticed when fixing the gccgo usage of the macro, the >>> rust usage is very similar. >>> >>> TARGET_AIX is defined as a non-zero value on linux/powerpc64le >>> which may cause unexpected behavior.  TARGET_AIX_OS should be >>> used to toggle AIX specific behavior. >>> >>> gcc/rust/ChangeLog: >>> >>>        * rust-object-export.cc [TARGET_AIX]: Rename and update >>>        usage to TARGET_AIX_OS. >> >> I don't have rights to formally approve this GCC/Rust change, but I'll >> note that it follows "as obvious" (see >> , "Obvious fixes") to the >> corresponding GCC/Go change, which has been approved: >> , >> and which is where this GCC/Rust code has been copied from, so I suggest >> you push both patches at once. >> >> >> Grüße >>   Thomas > > Hi Thomas, > > Thank you for reviewing.  I do not have commit access, so I cannot push this myself.  If this is OK, could one of the rust maintainers push this patch? > > Thanks, > Paul I pushed this to trunk for Paul. Peter