From: Jason Merrill <jason@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>,
Patrick Palka <ppalka@redhat.com>,
gcc-patches@gcc.gnu.org
Cc: gcc-rust@gcc.gnu.org, Faisal Abbas <90.abbasfaisal@gmail.com>
Subject: Re: [PATCH] rust: build failure after NON_DEPENDENT_EXPR removal [PR111899]
Date: Mon, 23 Oct 2023 11:28:13 -0400 [thread overview]
Message-ID: <9bcff148-b828-4b91-8398-1885f1469b3b@redhat.com> (raw)
In-Reply-To: <87msw93dsd.fsf@euler.schwinge.homeip.net>
On 10/23/23 05:10, Thomas Schwinge wrote:
> Hi Patrick!
>
> On 2023-10-20T13:36:30-0400, Patrick Palka <ppalka@redhat.com> wrote:
>> Built on x86_64-pc-linux-gnu, pushed to trunk as obvious (hopefully).
>>
>> -- >8 --
>>
>> This patch removes stray NON_DEPENDENT_EXPR checks following the removal
>> of this tree code from the C++ FE. (Since this restores the build I
>> supppose it means the Rust FE never creates NON_DEPENDENT_EXPR trees in
>> the first place, so no further analysis is needed.)
>
> ACK, thanks!
>
>
> For context: indeed, a non-trivial amount of C++ front end 'constexpr'
> code was copied into the Rust front end, for implementing related Rust
> functionality, mostly as part of the 2022 GSoC project
> "Support for Constant Folding in Rust Frontend" (Faisal Abbas),
> <https://gcc.gnu.org/wiki/SummerOfCode#A2022>.
>
> Yes, this should eventually be cleaned up (and merged with the original
> C++ front end code, as much as feasible -- which I don't know whether or
> to which extent it is).
It would be nice to move a lot of the constexpr code into the
middle-end, but I expect that would be a significant project.
Jason
prev parent reply other threads:[~2023-10-23 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:36 Patrick Palka
2023-10-23 9:10 ` Thomas Schwinge
2023-10-23 15:28 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bcff148-b828-4b91-8398-1885f1469b3b@redhat.com \
--to=jason@redhat.com \
--cc=90.abbasfaisal@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=ppalka@redhat.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).