From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 2BECC3858D37; Tue, 16 Apr 2024 20:34:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BECC3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BECC3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1032 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713299661; cv=none; b=orHB29JYefwg0axII1Hy6N2deI4MceQTMPjgOIzC8Ld9PqVaU4O3tGKHC0Nw18K7G8XmnLtkM0hBFzoqi+RoWXuDngn7MY8GayS03FYV00az+pgTuyHCraywZNCtBRwTBxl7M+onGFnqqAG4lXoLG3nll/k5MrvBZ2lldy/mZgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713299661; c=relaxed/simple; bh=YlnG5ttLd94yVfOPOB3UUYVJP0qkws5casQS1DkBD14=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=N5jFClVfoKp2Hf3zaorkxb6zJ+yb2/vQRxQiPf8yyYZMAoPtIN8Wkt08LzqIUAG6QfssttkqN08FdHCG2yifOS1Th8nZJ3aqhtSWqI9G9b/fLXdc0/oeaVMcEm5w+k21VeNDJ4OD9qabg8v5DDp8j96ThUcX9pP1gj+dn1L3UJU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2a53b331400so2946838a91.1; Tue, 16 Apr 2024 13:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713299652; x=1713904452; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hxMiWCq5Nz7HbVXtlBEuRk1IUgRC/L2IYLHCz/+3LgA=; b=iDib4mp8l+3LuY1lMPidcCWLgwT2GUTiGfdUopbJgUygo30LknBVIDh6I8zWo+Dq0K i35iNrTM/L5Icaq6vgx+nFxXrW5rU6lfpKafrdNqYLHf3An8czQkZW+XolFOst+P8dPU tKXIiOFBA5wkJzsFBOJFi33IIUCwztfHPIi57w02L/99hH6D98bR7TDIuRQoJrxJUoZa 1Mv+SnptTqhPLTEaFPfPlBK75C8CRxkojPFIRpdQHprVjHMyMQHTc626ueo5XQwkb4Zf W3vhLkwM5FGC09BBMZasdmQvoetjVsDRzwqV38NZh8mYT9I1ObwvO8bfcN9HlpanLItH uXbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713299652; x=1713904452; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hxMiWCq5Nz7HbVXtlBEuRk1IUgRC/L2IYLHCz/+3LgA=; b=EkH9P4LFjP+RqvAtW45sJWuK9aXFeqUI2Kzo89IJJ4bUN3p2vjIZ06OFGqoOvWdw2j hD3ZQk4lk0W1+1bdWwbIw73uWNyD9A/i0SmwjyOzG01VJVwJGpWIcskBDPHU+BO8to3s dQS5gnel64xzNO0aMfqc7Q1IjMb43FtlTnGeTo9z1aqBgd44asIodo9PaxPUbfbe6P8U xllJ8qBFIXpvC39OXtAxxlmuN0Z98q9K3JDuzH9Oxukask7Mwn2FCs1Jvxg6USsCMPmi oC5JjTE5lwZHS9QTydElKee2Egix+LBSZi0QdXGE3g3PkJc2ZiJIPEsfG4mLdoOtvSMX 2rHA== X-Forwarded-Encrypted: i=1; AJvYcCVQQuE33UYg+EACd7vI4BhsxQhA0XgT7HNw6nARuySTy42oQc92bxKGBe+ZJJlQpz+U7W0SpQg8lTAkE4J4dM7vjnPwpw== X-Gm-Message-State: AOJu0YzVQjqoaNklAL7LUDTt1Cf5+UTiktXWdX6SapMdemqs1KKrqaFc in0Vnlx4VofJwBhhYBpBxwePb6pqAVWDZ10QDJ/TSgEtJetz2IgInzpnkcl1MPqAyQ8Q8jptKsX 2t25mmV1hp6a+AFeCLOQdfQW4M6Pgxw== X-Google-Smtp-Source: AGHT+IHKkR7UzZ924RFMgEDAGuktvimBz2oz7t9ammwXuygMFV8ea8KlXTuWKOU0e0Y4cReyA+18ck7fiwf8JOLWqP4= X-Received: by 2002:a17:90b:4d91:b0:2a5:457a:8263 with SMTP id oj17-20020a17090b4d9100b002a5457a8263mr10394799pjb.19.1713299652018; Tue, 16 Apr 2024 13:34:12 -0700 (PDT) MIME-Version: 1.0 References: <20240408163337.303317-2-pierre-emmanuel.patry@embecosm.com> In-Reply-To: <20240408163337.303317-2-pierre-emmanuel.patry@embecosm.com> From: Andrew Pinski Date: Tue, 16 Apr 2024 13:34:00 -0700 Message-ID: Subject: Re: [PATCH] build: Check for cargo when building rust language To: pierre-emmanuel.patry@embecosm.com Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 8, 2024 at 9:39=E2=80=AFAM = wrote: > > From: Pierre-Emmanuel Patry > > Hello, > > The rust frontend requires cargo to build some of it's components, > it's presence was not checked during configuration. WHY did this go in right before the release of GCC 14? I don't get why this is considered temporary and it goes in right before a release. That seems broken to me. Thanks, Andrew > > Best regards, > Pierre-Emmanuel > > ---------- > > Prevent rust language from building when cargo is > missing. > > config/ChangeLog: > > * acx.m4: Add a macro to check for rust > components. > > ChangeLog: > > * configure: Regenerate. > * configure.ac: Emit an error message when cargo > is missing. > > Signed-off-by: Pierre-Emmanuel Patry > --- > config/acx.m4 | 11 +++++ > configure | 117 ++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 18 ++++++++ > 3 files changed, 146 insertions(+) > > diff --git a/config/acx.m4 b/config/acx.m4 > index 7efe98aaf96..3c5fe67342e 100644 > --- a/config/acx.m4 > +++ b/config/acx.m4 > @@ -424,6 +424,17 @@ else > fi > ]) > > +# Test for Rust > +# We require cargo and rustc for some parts of the rust compiler. > +AC_DEFUN([ACX_PROG_CARGO], > +[AC_REQUIRE([AC_CHECK_TOOL_PREFIX]) > +AC_CHECK_TOOL(CARGO, cargo, no) > +if test "x$CARGO" !=3D xno; then > + have_cargo=3Dyes > +else > + have_cargo=3Dno > +fi]) > + > # Test for D. > AC_DEFUN([ACX_PROG_GDC], > [AC_REQUIRE([AC_CHECK_TOOL_PREFIX]) > diff --git a/configure b/configure > index 874966fb9f0..46e66e20197 100755 > --- a/configure > +++ b/configure > @@ -714,6 +714,7 @@ PGO_BUILD_GEN_CFLAGS > HAVE_CXX11_FOR_BUILD > HAVE_CXX11 > do_compare > +CARGO > GDC > GNATMAKE > GNATBIND > @@ -5786,6 +5787,104 @@ else > have_gdc=3Dno > fi > > + > +if test -n "$ac_tool_prefix"; then > + # Extract the first word of "${ac_tool_prefix}cargo", so it can be a p= rogram name with args. > +set dummy ${ac_tool_prefix}cargo; ac_word=3D$2 > +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > +$as_echo_n "checking for $ac_word... " >&6; } > +if ${ac_cv_prog_CARGO+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + if test -n "$CARGO"; then > + ac_cv_prog_CARGO=3D"$CARGO" # Let the user override the test. > +else > +as_save_IFS=3D$IFS; IFS=3D$PATH_SEPARATOR > +for as_dir in $PATH > +do > + IFS=3D$as_save_IFS > + test -z "$as_dir" && as_dir=3D. > + for ac_exec_ext in '' $ac_executable_extensions; do > + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > + ac_cv_prog_CARGO=3D"${ac_tool_prefix}cargo" > + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exe= c_ext" >&5 > + break 2 > + fi > +done > + done > +IFS=3D$as_save_IFS > + > +fi > +fi > +CARGO=3D$ac_cv_prog_CARGO > +if test -n "$CARGO"; then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $CARGO" >&5 > +$as_echo "$CARGO" >&6; } > +else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > + > + > +fi > +if test -z "$ac_cv_prog_CARGO"; then > + ac_ct_CARGO=3D$CARGO > + # Extract the first word of "cargo", so it can be a program name with = args. > +set dummy cargo; ac_word=3D$2 > +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > +$as_echo_n "checking for $ac_word... " >&6; } > +if ${ac_cv_prog_ac_ct_CARGO+:} false; then : > + $as_echo_n "(cached) " >&6 > +else > + if test -n "$ac_ct_CARGO"; then > + ac_cv_prog_ac_ct_CARGO=3D"$ac_ct_CARGO" # Let the user override the te= st. > +else > +as_save_IFS=3D$IFS; IFS=3D$PATH_SEPARATOR > +for as_dir in $PATH > +do > + IFS=3D$as_save_IFS > + test -z "$as_dir" && as_dir=3D. > + for ac_exec_ext in '' $ac_executable_extensions; do > + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > + ac_cv_prog_ac_ct_CARGO=3D"cargo" > + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exe= c_ext" >&5 > + break 2 > + fi > +done > + done > +IFS=3D$as_save_IFS > + > +fi > +fi > +ac_ct_CARGO=3D$ac_cv_prog_ac_ct_CARGO > +if test -n "$ac_ct_CARGO"; then > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_ct_CARGO" >&5 > +$as_echo "$ac_ct_CARGO" >&6; } > +else > + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > +$as_echo "no" >&6; } > +fi > + > + if test "x$ac_ct_CARGO" =3D x; then > + CARGO=3D"no" > + else > + case $cross_compiling:$ac_tool_warned in > +yes:) > +{ $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: using cross tools not = prefixed with host triplet" >&5 > +$as_echo "$as_me: WARNING: using cross tools not prefixed with host trip= let" >&2;} > +ac_tool_warned=3Dyes ;; > +esac > + CARGO=3D$ac_ct_CARGO > + fi > +else > + CARGO=3D"$ac_cv_prog_CARGO" > +fi > + > +if test "x$CARGO" !=3D xno; then > + have_cargo=3Dyes > +else > + have_cargo=3Dno > +fi > { $as_echo "$as_me:${as_lineno-$LINENO}: checking how to compare bootstr= apped objects" >&5 > $as_echo_n "checking how to compare bootstrapped objects... " >&6; } > if ${gcc_cv_prog_cmp_skip+:} false; then : > @@ -9099,6 +9198,24 @@ $as_echo "$as_me: WARNING: --enable-host-shared re= quired to build $language" >&2 > ;; > esac > > + # Disable Rust if cargo is unavailable. > + case ${add_this_lang}:${language}:${have_cargo} in > + yes:rust:no) > + # Specifically requested language; tell them. > + as_fn_error $? "cargo is required to build $language" "$LINE= NO" 5 > + ;; > + all:rust:no) > + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: cargo is r= equired to build $language" >&5 > +$as_echo "$as_me: WARNING: cargo is required to build $language" >&2;} > + add_this_lang=3Dunsupported > + ;; > + *:rust:no) > + # Silently disable. > + add_this_lang=3Dunsupported > + ;; > + esac > + > + > # Disable a language that is unsupported by the target. > case "${add_this_lang}: $unsupported_languages " in > no:*) ;; > diff --git a/configure.ac b/configure.ac > index 4f34004a072..8c33c89d02c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1411,6 +1411,7 @@ fi > > ACX_PROG_GNAT > ACX_PROG_GDC > +ACX_PROG_CARGO > ACX_PROG_CMP_IGNORE_INITIAL > > AC_ARG_ENABLE([bootstrap], > @@ -2305,6 +2306,23 @@ directories, to avoid imposing the performance cos= t of > ;; > esac > > + # Disable Rust if cargo is unavailable. > + case ${add_this_lang}:${language}:${have_cargo} in > + yes:rust:no) > + # Specifically requested language; tell them. > + AC_MSG_ERROR([cargo is required to build $language]) > + ;; > + all:rust:no) > + AC_MSG_WARN([cargo is required to build $language]) > + add_this_lang=3Dunsupported > + ;; > + *:rust:no) > + # Silently disable. > + add_this_lang=3Dunsupported > + ;; > + esac > + > + > # Disable a language that is unsupported by the target. > case "${add_this_lang}: $unsupported_languages " in > no:*) ;; > -- > 2.43.0 >