From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 7A3493858D1E for ; Mon, 11 Apr 2022 10:40:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A3493858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-ej1-x62b.google.com with SMTP id u15so11295740ejf.11 for ; Mon, 11 Apr 2022 03:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GZe16l4UCQH1wLNHwAmCtJWhwPGwFvBrVqwcY8FncqI=; b=TOOYrDBXCfDU1Fo7ydKnDwhV5NqhK0Q4yqL15wlJ4JXjUJH0rN28AqBT3LsAYZIQbi MS7+qefXihYq9wAAfYM3HyINGEMXiGpDW+rdSXnwhqSIsVHamv466vHOPaOg73amB3lp rsQHWya4kWO4s6DS7ibt9PFTjynS1wtUNOAr/5UirCOTeArSV5Jg9R8Md//vzU9IMCC2 yo3uh50SHFMGSilm80xbRnq9gBsG1qUznFbEtvhqViLnKplVxJrYCYp9KeSe2poVxqjY 3DaxT5RsOT+c6UTFeC2SbwbZc088YbX73t1vzMSKnMjyv2KUX6bLyjlASyvAP9O8uBhx wuBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GZe16l4UCQH1wLNHwAmCtJWhwPGwFvBrVqwcY8FncqI=; b=bftb/SsT+07nBpzRt1naf1e4u7OL082BUGAItf97qx7Ak29eg6qcE2JhOs2Sz1Jjem 12m1O6/VXR2USVxJZpH2KJFYvp1/OzgXW6a8JU1tAZh0+Ykm53WBmrFk/05dLG6ECD0/ JlbIc7WZkBecIguCpDwkyW2FDO1u4HA3yYpW+8IbBfxY9UzLCdO4AXzLezI65zkAftcQ 7BE/9FVy0nubHzj8LrpiTuxrNTwZBpVyp3wUmwTFlui8MRFVBVepKDjepLxQeZBzqPVI uqTuWlpfrCkOQPpq9Mza0faDEqM+N0ClOnIoBt3Mw3rfZ00ykdY9SpK+4b92B0h2oyll S/tA== X-Gm-Message-State: AOAM530qzAFkpJdFW6ZVo/qdlxnIuh1zLM7iHygn/5BKL7mq/RoXtzc+ 3mYrGxY+E4cjetYmC2YV+f4Fzdr0rhHQiKFFpSUlJHTTa/CAtQ== X-Google-Smtp-Source: ABdhPJzYbrlJk7/lsXoz2r7hVoTf6WmgfNWCQsJMFRF+eJBJLGEBC2ghoyWMHH+KJWJwoC1Fbo0ufqLAwTIIVxpOybo= X-Received: by 2002:a17:907:8a17:b0:6e8:67d0:b6ca with SMTP id sc23-20020a1709078a1700b006e867d0b6camr11374121ejc.23.1649673607972; Mon, 11 Apr 2022 03:40:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philip Herron Date: Mon, 11 Apr 2022 11:39:57 +0100 Message-ID: Subject: Re: Bad testcase To: gcc-rust@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 10:40:11 -0000 For reference we found that the testsuite does timeout the test-case and produces; ``` Running target unix Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target. Using /usr/share/dejagnu/config/unix.exp as generic interface file for target. Using /home/runner/work/gccrs/gccrs/gcc/testsuite/config/default.exp as tool-and-target-specific interface file. Running /home/runner/work/gccrs/gccrs/gcc/testsuite/rust/compile/compile.exp ... max length for a Tcl unicode value (2147483637 chars) exceeded /bin/bash: line 21: 92574 Aborted (core dumped) `if [ -f ${srcdir}/../dejagnu/runtest ] ; then echo ${srcdir}/../dejagnu/runtest ; else echo runtest; fi` --tool rust make[2]: Leaving directory '/home/runner/work/gccrs/gccrs/gccrs-build/gcc' make[1]: Leaving directory '/home/runner/work/gccrs/gccrs/gccrs-build/gcc' ``` It's a pity make check-rust does fail properly here but hopefully, someone knows of a nice way to handle this. Thanks --Phil On Mon, 11 Apr 2022 at 11:35, Philip Herron wrote: > > Hi everyone, > > We merged a new builtin macro recently and during the code review we > missed a case where the code produces an infinite loop and so we > raised: https://github.com/Rust-GCC/gccrs/issues/1102 > > The GitHub CI did not seem to catch this issue, I am assuming dejagnu > timeout the test case and our CI doesn't pick this up as a failure and > so I have pushed a patch directly to master to disable the offending > test case. I am raising this here just for transparency for why I > pushed to master and I hope the build farm is ok it might be worth > cancelling any existing builds and letting them pick up the next > merge's to master. For reference I pushed this patch to silence the > issue: 68458036c81d141a3899ac4e6ec6ddf0fdfde174 > > Hope everyone is having a great start of the week. > > --Phil