public inbox for
 help / color / mirror / Atom feed
From: Philip Herron <>
To: Mark Wielaard <>
Subject: Re: Cleanup some StructExpr related classes
Date: Mon, 6 Sep 2021 17:55:45 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hi Mark,

Well done on the new patches they are currently being merged. I imagine the
typechecking could be a bit more complex since correct me if I am wrong but
I feel like this might end up affecting the whole PathInExpression
resolution which is fairly complicated. There is a nullptr bug there if it
fails to resolve the root segment.

I imagine there might need to be a check in the resolve_segments for if the
tyseg which will be the type of the previous segment, if that is an ADTType
which is an enum then look for the name of the field within the struct but
i am not 100% sure if it does affect the PathInExpression stuff.

Let me know if there is anything I can do to help or review? I don't mind
checking out your branches to play with too.



[-- Attachment #2: Type: text/html, Size: 908 bytes --]

      reply	other threads:[~2021-09-06 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  0:15 Mark Wielaard
2021-09-01  0:15 ` [PATCH 1/3] StructExprTuple doesn't really exist Mark Wielaard
2021-09-01  0:15 ` [PATCH 2/3] StructExprUnit " Mark Wielaard
2021-09-01  0:15 ` [PATCH 3/3] Remove Enumaration Expression, EnumExpr, classes Mark Wielaard
2021-09-01 10:11 ` Cleanup some StructExpr related classes Philip Herron
2021-09-01 19:23   ` Mark Wielaard
2021-09-02 13:23     ` Philip Herron
2021-09-05 22:47       ` Mark Wielaard
2021-09-06 16:55         ` Philip Herron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).