From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 608733858408; Tue, 26 Sep 2023 11:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 608733858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5031426b626so13660335e87.3; Tue, 26 Sep 2023 04:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695728669; x=1696333469; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rRhBq2x/B3T68RvHJDIOsMV3WOHDpBhsX3mOhOiJ/OQ=; b=UnOyZpdRshHej5DnzBWqCSZa2MlY+a78ZqS1zbS4klYsn8o1WfiMemwjgMzlqVDqWF gVWDg2t4Qd52dgrzBh8yy23Xo9ZpBLek4oDcocStA6u8hdR9JBrMAGUvAJ3CkcoALcSR XDqSa8n6E9E9BHnafRGJnf+RpmGsaSVH+1MXk/iORoUB71QRN0wH5LMTEmzUScSW+Z/3 cfwyANtasHxMzpunDQzIllxpER19PCPrYLrLAbk9WiUxJXuXKCwxtRE4y7XqPt3h0vIP JhCuT1cTlU0uwLn7OGsoGm58x1MfteK7ex6eOg1JubBKOU7Hj+bI8Z1+R/0u2gqLLqHB vmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695728669; x=1696333469; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rRhBq2x/B3T68RvHJDIOsMV3WOHDpBhsX3mOhOiJ/OQ=; b=wXSMxM3iTe7XEbA5srdjgFAlHYwE8KonTgL+LrTTjW2AVBcK4VHGzb7/5HA//f4rNc TTfWC9bFg2uWSrO5ePOIJ0Tb2qWMkTW8ukU5R1YuQF7IhGNX8MOAjGVRmLEkL/8v6ThN /lo91cM3kEashkKpmQLjAihF3B7iGODmXIuIZXBNWaU3IIGyXq924jE4ipgLq858C64d dQ6t8LXtRfdi4l6mSGptucUS78nTSuWvUGhtXiCt/6OMYh0RCZbN9rnWuWU57c2cizxq V6nLgONA/AhWraExCwLZEaZJ1iDGlayvz8ACvFq20wqEH3NimC2kDYqYHwWuOwlVcFEm 9AsQ== X-Gm-Message-State: AOJu0YyxAlDXQwYXvb1bzZIrxYvLqHrW6rBCKSg0TzXX5T8Wo4+ujnXA Xqjh2GvriI/NcieurfcgVaw2VGBWRGMhdVOipnytO3NZ X-Google-Smtp-Source: AGHT+IHYDhCwKTmMx43yMmhiE1YGZ+bnV73OzkgAJvvZ5og2y9mLKhqO7WHVjd2lHq4OuOqG9lWcjvzkyjsAJbaROb4= X-Received: by 2002:ac2:46d2:0:b0:4fd:fd97:a77b with SMTP id p18-20020ac246d2000000b004fdfd97a77bmr7699835lfo.50.1695728668648; Tue, 26 Sep 2023 04:44:28 -0700 (PDT) MIME-Version: 1.0 References: <20230920120311.14892-1-arthur.cohen@embecosm.com> <20230920120311.14892-3-arthur.cohen@embecosm.com> In-Reply-To: <20230920120311.14892-3-arthur.cohen@embecosm.com> From: Richard Biener Date: Tue, 26 Sep 2023 13:42:06 +0200 Message-ID: Subject: Re: [PATCH 2/3] build: Add libgrust as compilation modules To: Arthur Cohen Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org, Pierre-Emmanuel Patry Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 20, 2023 at 2:04=E2=80=AFPM Arthur Cohen wrote: > > From: Pierre-Emmanuel Patry > > Define the libgrust directory as a host compilation module as well as > for targets. OK if you tested this doesn't break build when rust is enabled on trunk (and doesn't build libgrust if not). Richard. > ChangeLog: > > * Makefile.def: Add libgrust as host & target module. > * configure.ac: Add libgrust to host tools list. > > gcc/rust/ChangeLog: > > * config-lang.in: Add libgrust as a target module for the rust > language. > > Signed-off-by: Pierre-Emmanuel Patry > --- > Makefile.def | 2 ++ > configure.ac | 3 ++- > gcc/rust/config-lang.in | 2 ++ > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Makefile.def b/Makefile.def > index 870150183b9..3df3fc18d14 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -149,6 +149,7 @@ host_modules=3D { module=3D libcc1; extra_configure_f= lags=3D--enable-shared; }; > host_modules=3D { module=3D gotools; }; > host_modules=3D { module=3D libctf; bootstrap=3Dtrue; }; > host_modules=3D { module=3D libsframe; bootstrap=3Dtrue; }; > +host_modules=3D { module=3D libgrust; }; > > target_modules =3D { module=3D libstdc++-v3; > bootstrap=3Dtrue; > @@ -192,6 +193,7 @@ target_modules =3D { module=3D libgm2; lib_path=3D.li= bs; }; > target_modules =3D { module=3D libgomp; bootstrap=3D true; lib_path=3D.l= ibs; }; > target_modules =3D { module=3D libitm; lib_path=3D.libs; }; > target_modules =3D { module=3D libatomic; bootstrap=3Dtrue; lib_path=3D.= libs; }; > +target_modules =3D { module=3D libgrust; }; > > // These are (some of) the make targets to be done in each subdirectory. > // Not all; these are the ones which don't have special options. > diff --git a/configure.ac b/configure.ac > index 1d16530140a..036e5945905 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -133,7 +133,7 @@ build_tools=3D"build-texinfo build-flex build-bison b= uild-m4 build-fixincludes" > > # these libraries are used by various programs built for the host enviro= nment > #f > -host_libs=3D"intl libiberty opcodes bfd readline tcl tk itcl libgui zlib= libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf = libsframe" > +host_libs=3D"intl libiberty opcodes bfd readline tcl tk itcl libgui zlib= libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf = libsframe libgrust " > > # these tools are built for the host environment > # Note, the powerpc-eabi build depends on sim occurring before gdb in or= der to > @@ -164,6 +164,7 @@ target_libraries=3D"target-libgcc \ > target-libada \ > target-libgm2 \ > target-libgo \ > + target-libgrust \ > target-libphobos \ > target-zlib" > > diff --git a/gcc/rust/config-lang.in b/gcc/rust/config-lang.in > index aac66c9b962..8f071dcb0bf 100644 > --- a/gcc/rust/config-lang.in > +++ b/gcc/rust/config-lang.in > @@ -29,4 +29,6 @@ compilers=3D"rust1\$(exeext)" > > build_by_default=3D"no" > > +target_libs=3D"target-libffi target-libbacktrace target-libgrust" > + > gtfiles=3D"\$(srcdir)/rust/rust-lang.cc" > -- > 2.42.0 >