From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 09A6A384F030; Thu, 10 Nov 2022 10:52:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09A6A384F030 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id n12so3889619eja.11; Thu, 10 Nov 2022 02:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OdHx/zuf36iNz6vcEB7kVz4hwPRQk0g+Y0Golqn0evQ=; b=a/J/lhyO8VAvmuk1VVrlLGdlKD+yGW/0TbLXXywJIYdclJhkbYVA0WAkwFKKZsvkeW gGTiWmaJCkiZqcC4LrQ8i2Rto0+ejmz6RLSgCTHROoz8LVTd8LsND6VDwq/kf/ABiaN3 NnE3BUwauPJ5JyAp8iTli8VI0Tgz0KyKIpcEKVviTXvupoc4RUys/kwSkjYJU4LLyIeE HDIcRyBNjsMEa/UHmnwWxhoCC/jA8ttMakbzmSAuu047R+dDH0BMjzFI6FvGfXQkr5J0 YqXAU34KWDdIx/ThRFKaF2qj1pjjFqtojInpCuNjYnq/2J1O56Zg4lFdoUJ8i77vU1yQ 3uIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OdHx/zuf36iNz6vcEB7kVz4hwPRQk0g+Y0Golqn0evQ=; b=x+lRt7EtIbxvw62IxhE1wsoAsK6l63kqXzd9pw8+HxzVK68sZQ77Cl/mfJBW03ZVhB /CQJVhFzfu8gRByIdfvxNcuzawPOAGGEyHvoTqr1jNEWnxJ6a24PJUTCKfsJluhGmspf LBBP19sGki3JYszvsrK98m6d6F9huMjAaaWEc4C3FxMXYoE2wCCuKdXnoDXvH9wNOj9L Jytlj/eLoAwM0db9T9ZXKlzBMUsf7+SOCEqCkKIw8V89QiIw/DY/asgNNc8G8HeiSAYu Kmhevqtfjn5Ps7W9g/sWUekcMky9WW/94USuDOl79FpZSGqWd+5NLT/8DER3VjIL5i8o kp5A== X-Gm-Message-State: ACrzQf3KrskrFCpagMgk+i/ZzL9fHmDi9dRt5uMP+kAhcJlTwiU2J51i /fJic1MF0/GA3T+d8qJriOHQmfLmuj2nOZ7VLNHLjlWP X-Google-Smtp-Source: AMsMyM6+aB9XEVmlmxGTgAc6hFSYt8mIfJRklItdr8v5J0xky0+m1KZxpvuJVUMCOy6Bad3mPOkYva2zRfCTYAul8FQ= X-Received: by 2002:a17:907:971f:b0:7ad:e232:f115 with SMTP id jg31-20020a170907971f00b007ade232f115mr47294077ejc.754.1668077572837; Thu, 10 Nov 2022 02:52:52 -0800 (PST) MIME-Version: 1.0 References: <20221026081811.602573-1-arthur.cohen@embecosm.com> In-Reply-To: <20221026081811.602573-1-arthur.cohen@embecosm.com> From: Richard Biener Date: Thu, 10 Nov 2022 11:52:40 +0100 Message-ID: Subject: Re: Rust frontend patches v3 To: arthur.cohen@embecosm.com Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 26, 2022 at 10:16 AM wrote: > > This is the fixed version of our previous patch set for gccrs - We've adressed > the comments raised in our previous emails. > > This patch set does not contain any work that was not previously included, such > as closure support, the constant evaluator port, or the better implementation > of target hooks by Iain Buclaw. They will follow up in subsequent patch sets. > > Thanks again to Open Source Security, inc and Embecosm who have accompanied us > for this work. > > Many thanks to all of the contributors and our community, who made this > possible. > > A very special thanks to Philip Herron, without whose mentoring I would have > never been in a position to send these patches. > > You can see the current status of our work on our branch: > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master > > The patch set contains the following: Can you mark the patches that have been reviewed/approved? Can you maybe either split the series or organize it in a way to separate the pieces touching common parts of GCC from the gcc/rust/ parts? Can you separate testsuite infrastructure from actual tests, can you mark/separate target specific changes? And for those (then small) changes CC the appropriate maintainers? Thanks, Richard. > [PATCH Rust front-end v3 01/46] Use DW_ATE_UTF for the Rust 'char' > [PATCH Rust front-end v3 02/46] gccrs: Add nessecary hooks for a Rust > [PATCH Rust front-end v3 03/46] gccrs: Add Debug info testsuite > [PATCH Rust front-end v3 04/46] gccrs: Add link cases testsuite > [PATCH Rust front-end v3 05/46] gccrs: Add general compilation test > [PATCH Rust front-end v3 06/46] gccrs: Add execution test cases > [PATCH Rust front-end v3 07/46] gccrs: Add gcc-check-target > [PATCH Rust front-end v3 08/46] gccrs: Add Rust front-end base AST > [PATCH Rust front-end v3 09/46] gccrs: Add definitions of Rust Items > [PATCH Rust front-end v3 10/46] gccrs: Add full definitions of Rust > [PATCH Rust front-end v3 11/46] gccrs: Add Rust AST visitors > [PATCH Rust front-end v3 12/46] gccrs: Add Lexer for Rust front-end > [PATCH Rust front-end v3 13/46] gccrs: Add Parser for Rust front-end > [PATCH Rust front-end v3 14/46] gccrs: Add Parser for Rust front-end > [PATCH Rust front-end v3 15/46] gccrs: Add expansion pass for the > [PATCH Rust front-end v3 16/46] gccrs: Add name resolution pass to > [PATCH Rust front-end v3 17/46] gccrs: Add declarations for Rust HIR > [PATCH Rust front-end v3 18/46] gccrs: Add HIR definitions and > [PATCH Rust front-end v3 19/46] gccrs: Add AST to HIR lowering pass > [PATCH Rust front-end v3 20/46] gccrs: Add wrapper for make_unique > [PATCH Rust front-end v3 21/46] gccrs: Add port of FNV hash used > [PATCH Rust front-end v3 22/46] gccrs: Add Rust ABI enum helpers > [PATCH Rust front-end v3 23/46] gccrs: Add Base62 implementation > [PATCH Rust front-end v3 24/46] gccrs: Add implementation of Optional > [PATCH Rust front-end v3 25/46] gccrs: Add attributes checker > [PATCH Rust front-end v3 26/46] gccrs: Add helpers mappings canonical > [PATCH Rust front-end v3 27/46] gccrs: Add type resolution and trait > [PATCH Rust front-end v3 28/46] gccrs: Add Rust type information > [PATCH Rust front-end v3 29/46] gccrs: Add remaining type system > [PATCH Rust front-end v3 30/46] gccrs: Add unsafe checks for Rust > [PATCH Rust front-end v3 31/46] gccrs: Add const checker > [PATCH Rust front-end v3 32/46] gccrs: Add privacy checks > [PATCH Rust front-end v3 33/46] gccrs: Add dead code scan on HIR > [PATCH Rust front-end v3 34/46] gccrs: Add unused variable scan > [PATCH Rust front-end v3 35/46] gccrs: Add metadata ouptput pass > [PATCH Rust front-end v3 36/46] gccrs: Add base for HIR to GCC > [PATCH Rust front-end v3 37/46] gccrs: Add HIR to GCC GENERIC > [PATCH Rust front-end v3 38/46] gccrs: Add HIR to GCC GENERIC > [PATCH Rust front-end v3 39/46] gccrs: These are wrappers ported from > [PATCH Rust front-end v3 40/46] gccrs: Add GCC Rust front-end > [PATCH Rust front-end v3 41/46] gccrs: Add config-lang.in > [PATCH Rust front-end v3 42/46] gccrs: Add lang-spec.h > [PATCH Rust front-end v3 43/46] gccrs: Add lang.opt > [PATCH Rust front-end v3 44/46] gccrs: Add compiler driver > [PATCH Rust front-end v3 45/46] gccrs: Compiler proper interface > [PATCH Rust front-end v3 46/46] gccrs: Add README, CONTRIBUTING and >