From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id B9259384091B; Thu, 15 Dec 2022 07:53:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9259384091B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x230.google.com with SMTP id s25so9146260lji.2; Wed, 14 Dec 2022 23:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8Je7c/Huazs+EdBw2olKNLm8bowYVx1Cxy0Eafep2WQ=; b=nVv5/5YWyQLnsPHmKyaiG+ptTfNCmkXtQM+lQHO9C5ebmSGK8uFWyofew9zVlIzV7a XraYYSGLeOyugpg1k3HECrwEzJpLmaMJczQP6ioAaIw9Cigxk2T1a6zkk3pgXMa5MBsj KQHjVfbuTdZ85dQzcvvSiQ+hs8galBThi3aBItVt8sV5yVfPqkTOo+Tzx9cAFdfmqngv rIYd0DVc3m6f1cCzj5rEMQkRl3vqPOOJk4R8SSlRGflTMOt3ZR7wBDAKl/x7TGnjGXY6 T0X3kfZ5JnFZLPYaWA/f2lg4hXPr5/jhCUobEtdTLnI2VYzk3fc/8t86j/jcFJg3tT+i VZ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Je7c/Huazs+EdBw2olKNLm8bowYVx1Cxy0Eafep2WQ=; b=v6hjttBqKVqV9blY6iFw8OT1FGCCG/+p4CAKdTLoJbXW1/huok8ZKJLuBSg0NlMo1o byg0ng0JKwv6xONXR+YNeNouAl8B1LmLc3l/vXQR/rVQjd5xZc/3Wf1TKS9ofzlO+dRk v+faJtP7T8DZ1vukr9fG+rVifl3/dFFZ2tEe/JkN4TGIaMbIELldswOV/m3XBOAyKAPn 4q0ahC60cq2+qnSiCJzaznAif5Yn3ThJOr4uzGx7BfYxSJqt6NgLv1fceYp1H8uJLB0G GOuZLcyRpT8cfRIlYwAb/Axa7UUENRz9kUDpAwxQ6Xx/Ejz2bxhbI6/CsEfIKqoAC86o qxxg== X-Gm-Message-State: ANoB5pnniFeyjA8UpGvjM6FpF0uZhTI3nh6+smiTvvCGZo3ByczR5I11 HdyY3PjtNoDykr4PxXT4UC/iWfTrNMx68+tBLgA= X-Google-Smtp-Source: AA0mqf6pBc59KusJ5ScHDC55Ts+wfvu0YfzV7WxQioi0Sp1Ms07zBFN8u2HoGzMFuC2h6hvZd/IMJVt2KpQC7NH+RQ8= X-Received: by 2002:a05:651c:19ab:b0:276:66a4:47c3 with SMTP id bx43-20020a05651c19ab00b0027666a447c3mr25331207ljb.49.1671090806052; Wed, 14 Dec 2022 23:53:26 -0800 (PST) MIME-Version: 1.0 References: <20221206101417.778807-1-arthur.cohen@embecosm.com> <9d59ae0f-048f-dc32-6309-c8134467bbb7@embecosm.com> <87pmcla8yz.fsf@euler.schwinge.homeip.net> In-Reply-To: <87pmcla8yz.fsf@euler.schwinge.homeip.net> From: Richard Biener Date: Thu, 15 Dec 2022 08:53:13 +0100 Message-ID: Subject: Re: Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common' option (was: Rust front-end patches v4) To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, joseph@codesourcery.com, Arthur Cohen , gcc-rust@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 14, 2022 at 11:58 PM Thomas Schwinge wrote: > > Hi! > > On 2022-12-13T14:40:36+0100, Arthur Cohen wro= te: > > We've also added one more commit, which only affects files inside the > > Rust front-end folder. This commit adds an experimental flag, which > > blocks the compilation of Rust code when not used. > > (That's commit r13-4675-gb07ef39ffbf4e77a586605019c64e2e070915ac3 > "gccrs: Add fatal_error when experimental flag is not present".) > > I noticed that GCC/Rust recently lost all LTO variants in torture > testing -- due to this commit. :-O > > OK to push the attached > "Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common'= option", > or should this be done differently? Just add 'LTO' to the option in lang.opt, like frust-incomplete-and-experimental-compiler-do-not-use Rust LTO Var(flag_rust_experimental) Enable experimental compilation of Rust files at your own risk > > With that, we get back: > > PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O0 (te= st for excess errors) > PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O1 (te= st for excess errors) > PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O2 (te= st for excess errors) > +PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O2 -flt= o -fno-use-linker-plugin -flto-partition=3Dnone (test for excess errors) > +PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O2 -flt= o -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) > PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -O3 -g = (test for excess errors) > PASS: rust/compile/torture/all_doc_comment_line_blocks.rs -Os (te= st for excess errors) > > Etc., and in total: > > =3D=3D=3D rust Summary for unix =3D=3D=3D > > # of expected passes [-4990-]{+6718+} > # of expected failures [-39-]{+51+} > > > Gr=C3=BC=C3=9Fe > Thomas > > > > We hope this helps > > indicate to users that the compiler is not yet ready, but can still be > > experimented with :) > > > > We plan on removing that flag as soon as possible, but in the meantime, > > we think it will help not creating divide within the Rust ecosystem, as > > well as not waste Rust crate maintainers' time. > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955