From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 63AAB3858404; Thu, 15 Sep 2022 06:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63AAB3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62b.google.com with SMTP id bj12so39663472ejb.13; Wed, 14 Sep 2022 23:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=eunglMcgNavnlTtrm8oUwCpfsPCgPXhzBuOZF3va7qM=; b=kk/L0AuN+aYvNSy5sTiG+wloZ64/xOEkHaYTB7prXLgL7AIZ++K1qJZcaP3s9VnLFJ PmjdZ1L84JOGiFNEX8yxFLs26ShUPofMC1ZqTEl5STd9Xqv1C7EincsMsbRCkniV86d7 MqR2X5x7CvqXNTM5B5oavZ1KiITZGhifAnLbMM5r+JTMeQZ8YWygBQ+22m2kJ/318SaV 0Lojm2rF79/Oz7mTNrGR8JoPZt89frj5WbQFdU+ZEZTo78ROKhG+qOvAX/fvZ0Ndvn4v 0JkM3AnysgRBHHFL2M3VJxELdbRaQZFVvVYQCW0wkxAcy9qdS3zOnfGCRFt5h/KnUiY+ NvSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=eunglMcgNavnlTtrm8oUwCpfsPCgPXhzBuOZF3va7qM=; b=QIAXXI5FndKX2771xcQXRH45DYGkUTFC0/hcrWRuvV5yAMZa+XSm+ZihKeeMjwre9v bNzHzD2FQ4WxEiB3YXbLLlOSyKEUW4XrukWSNPGf0sFXkyaA3erJJq6RLzAwb0myh0hA Wckslf1nFfKHrUaWPAFchFlVAsYpe9l0PPC1vP5JA0nUp7AghzXJKY2UzG8Ae8xLSomm oMhhDuxcLoiAjqRZ/V4osXh2GQUfovoINzW4bg0EifMPZCCdxJoZlIQfxw5gHtZE+OzK /xniBW/zOGFedsppZwAOKyC2reHjgaKgFDxagfKXOhpWpY2Zk3gkhhcOTtl5V9ut6Cu3 76Cw== X-Gm-Message-State: ACgBeo2+g5J/9FUn8W0M1Dps19jFsRIutbse1xs16DzFaMJ/QH1TRYIr koLraBnY2uHpSkrCqwrHXTZBzfFuqBfqzi1VP/M= X-Google-Smtp-Source: AA6agR6LqN308LwQJGrEfnguUJbze9zPWtlsb3jctthw8/pOsUA3aYpfVDSA0HgeRyMLnvfgEgnd+3Cy8h4YYQYnUAE= X-Received: by 2002:a17:907:7632:b0:76f:f6e7:36cf with SMTP id jy18-20020a170907763200b0076ff6e736cfmr29393905ejc.442.1663223008956; Wed, 14 Sep 2022 23:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20220824115956.737931-1-philip.herron@embecosm.com> <20220824115956.737931-35-philip.herron@embecosm.com> <877d26lyg4.fsf@euler.schwinge.homeip.net> In-Reply-To: <877d26lyg4.fsf@euler.schwinge.homeip.net> From: Richard Biener Date: Thu, 15 Sep 2022 08:23:17 +0200 Message-ID: Subject: Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt To: Thomas Schwinge Cc: philip.herron@embecosm.com, gcc-rust@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 14, 2022 at 6:20 PM Thomas Schwinge w= rote: > > Hi! > > On 2022-09-14T15:39:47+0200, Richard Biener via Gcc-patches wrote: > > On Wed, Aug 24, 2022 at 2:13 PM wrote: > >> > >> From: Philip Herron > >> > >> We have some rust specific langugage options note -fwrapv is enabled b= y > >> default in the code. We are trying to respect options such as > >> -Wunused-result which we get by porting over c++ no-discard for rust's > >> must-use attribute, so we have enabled these by default directly here. > > > > LGTM > > Actually, NACK. ;-) > > See > "gccrs setting warn_unused_variable breaks thousands of non-Rust tests". > The 'Init(1)' in 'gcc/rust/lang.opt' are in conflict with any (default) > 'Init(0)' in other '*.opt' files -- remember that all '*.opt' files are > processed together by GCC's "options machinery", and thus > 'gcc/rust/lang.opt' may (and here, does) affect non-Rust front end code. Ah, I wondered about the duplicates adding to the list of supported FEs, I = guess that the awk script should check for obvious mismatches in other settings? > I do have a patch series adding a 'LangInit(@var{language}, @var{value})' > option property, and patches to use this in a lot of places (here and in > other front ends' '*.opt' files), where currently we implement such logic > in '*.cc' files; '[...]_init_options_struct' functions via > 'LANG_HOOKS_INIT_OPTIONS_STRUCT' (those then largely become empty and may > be removed). I assume this idea to be uncontroversial; I "just" need to > get it polished and submitted... > > > Gr=C3=BC=C3=9Fe > Thomas > > > >> gcc/rust/lang.opt | 118 +++++++++++++++++++++++++++++++++++++++++++++= + > >> 1 file changed, 118 insertions(+) > >> create mode 100644 gcc/rust/lang.opt > >> > >> diff --git a/gcc/rust/lang.opt b/gcc/rust/lang.opt > >> new file mode 100644 > >> index 00000000000..1f6855ede1d > >> --- /dev/null > >> +++ b/gcc/rust/lang.opt > >> @@ -0,0 +1,118 @@ > >> +; Options for the Rust front end. > >> +; Copyright (C) 2003-2022 Free Software Foundation, Inc. > >> +; > >> +; This file is part of GCC. > >> +; > >> +; GCC is free software; you can redistribute it and/or modify it unde= r > >> +; the terms of the GNU General Public License as published by the Fre= e > >> +; Software Foundation; either version 3, or (at your option) any late= r > >> +; version. > >> +; > >> +; GCC is distributed in the hope that it will be useful, but WITHOUT = ANY > >> +; WARRANTY; without even the implied warranty of MERCHANTABILITY or > >> +; FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public Licen= se > >> +; for more details. > >> +; > >> +; You should have received a copy of the GNU General Public License > >> +; along with GCC; see the file COPYING3. If not see > >> +; . > >> + > >> +; See the GCC internals manual for a description of this file's forma= t. > >> + > >> +; Please try to keep this file in ASCII collating order. > >> + > >> +; Describes command-line options used by this frontend > >> + > >> +Language > >> +Rust > >> + > >> +I > >> +Rust Joined Separate > >> +; Documented in c.opt > >> + > >> +L > >> +Rust Joined Separate > >> +; Not documented > >> + > >> +Wall > >> +Rust > >> +; Documented in c.opt > >> + > >> +Wunused-variable > >> +Rust Var(warn_unused_variable) Init(1) Warning > >> +; documented in common.opt > >> + > >> +Wunused-const-variable > >> +Rust Warning Alias(Wunused-const-variable=3D, 2, 0) > >> +Warn when a const variable is unused. > >> + > >> +Wunused-const-variable=3D > >> +Rust Joined RejectNegative UInteger Var(warn_unused_const_variable) I= nit(1) Warning LangEnabledBy(Rust,Wunused-variable, 1, 0) IntegerRange(0, 2= ) > >> +Warn when a const variable is unused. > >> + > >> +Wunused-result > >> +Rust Var(warn_unused_result) Init(1) Warning > >> +Warn if a caller of a function, marked with attribute warn_unused_res= ult, does not use its return value. > >> + > >> +frust-crate=3D > >> +Rust Joined RejectNegative > >> +-frust-crate=3D Set the crate name for the compilat= ion > >> + > >> +frust-debug > >> +Rust Var(flag_rust_debug) > >> +Dump various Rust front end internals. > >> + > >> +frust-dump- > >> +Rust Joined RejectNegative > >> +-frust-dump- Dump Rust frontend internal information. > >> + > >> +frust-max-recursion-depth=3D > >> +Rust RejectNegative Type(int) Var(rust_max_recursion_depth) Init(64) > >> +-frust-max-recursion-depth=3Dinteger > >> + > >> +frust-mangling=3D > >> +Rust Joined RejectNegative Enum(frust_mangling) Var(flag_rust_manglin= g) > >> +-frust-mangling=3D[legacy|v0] Choose which version to use for nam= e mangling > >> + > >> +Enum > >> +Name(frust_mangling) Type(int) UnknownError(unknown rust mangling opt= ion %qs) > >> + > >> +EnumValue > >> +Enum(frust_mangling) String(legacy) Value(0) > >> + > >> +EnumValue > >> +Enum(frust_mangling) String(v0) Value(1) > >> + > >> +frust-cfg=3D > >> +Rust Joined RejectNegative > >> +-frust-cfg=3D Set a config expansion option > >> + > >> +frust-edition=3D > >> +Rust Joined RejectNegative Enum(frust_edition) Var(flag_rust_edition) > >> +-frust-edition=3D[2015|2018|2021] Choose which edition to= use when compiling rust code > >> + > >> +Enum > >> +Name(frust_edition) Type(int) UnknownError(unknown rust edition %qs) > >> + > >> +EnumValue > >> +Enum(frust_edition) String(2015) Value(0) > >> + > >> +EnumValue > >> +Enum(frust_edition) String(2018) Value(1) > >> + > >> +EnumValue > >> +Enum(frust_edition) String(2021) Value(2) > >> + > >> +frust-embed-metadata > >> +Rust Var(flag_rust_embed_metadata) > >> +Flag to enable embeding metadata directly into object files > >> + > >> +frust-metadata-output=3D > >> +Rust Joined RejectNegative > >> +-frust-metadata-output=3D Path to output crate metadata > >> + > >> +o > >> +Rust Joined Separate > >> +; Documented in common.opt > >> + > >> +; This comment is to ensure we retain the blank line above. > >> -- > >> 2.25.1 > >> > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955