From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id ECDB53858CDA; Thu, 14 Sep 2023 10:14:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECDB53858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5009d4a4897so1350394e87.0; Thu, 14 Sep 2023 03:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694686447; x=1695291247; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q1pRtTe2Y+xmriYqMl+jxmWJehWB+SpFq9/aVSMjhNc=; b=ETbi+ev9d94btRXUx+KsADVh37Qdxe3pJc1yhL9O2zqqz5g6b9d6Bf0tTYqxXK9tX6 MLqxC3fD6G4wWYwdACZATjXTkMDCumCQzVElZm082W3nGaAuAt5HQx4YPmfThx+il0rU cMprcSUktEkxL+Sz5eZOEWGuZFL6qZ7rMFxOChyySP0VfysrFd4pH6w1zJKdtXom0V9X cYR8QMzvuB7fIKGdExWgM2Hs+mxs1bH3dbqaPYgVqLvPuCFRQy5euJ4w2QMRc4ww5SZC iEpdeJv3Z+sKO0Swd2+c3Zn6eLAqtf6j4G8Qe2p2RM01VlswdMuLtfjfO/yvxI0vmWmT 56Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694686447; x=1695291247; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q1pRtTe2Y+xmriYqMl+jxmWJehWB+SpFq9/aVSMjhNc=; b=PfzWYxJRGmGXKpnVd4ZxRAXqr+LgTlMCzK9J6AVFb0soFqoxVCFFUVM9N4NipLM+12 szdCXBrF+/hWf4LSCTKhYbdmLA1RONTfVWvKt4miG0dl3dcg6uZU14yUyVAQxBGX8/DH YW/54kS5vISv/fsWIcnNBrcjvFe9KYU2coNZYjqvZee5hxmaq5AlzESPQCPmnmT/30cj n66dTUaWDAIjapqyQg/KLoeTcWBycOlzpH8mPwGw1ZjqF0wX1xuFNIDkbzUyCC4Wl0Ys PcSK4outlHmqEHh0w/pMDt54p5efK2RoVrHTGlQ06g7SVa37UJgN6wcynGFKpSonYYj3 K5PQ== X-Gm-Message-State: AOJu0YxW3FxTqEA3E5hZUy0vi7LNgl4XPiqsX/qyRU9naUTeuZB+fc/J dWkur9P4z220pkXhRgdghfLBRHuY39IhGGZVh7IkDUvj X-Google-Smtp-Source: AGHT+IHkN1jWOMtecwfcGfArHC/WWr5mgQ02joctrMuDI0FMeqaxMGzvgcUhnpLadqRVxBc/+/iUoel/W/L8xY8rzbU= X-Received: by 2002:a05:6512:1595:b0:4fb:744e:17db with SMTP id bp21-20020a056512159500b004fb744e17dbmr5284217lfb.1.1694686447015; Thu, 14 Sep 2023 03:14:07 -0700 (PDT) MIME-Version: 1.0 References: <606cbf6f-1c99-9beb-1e98-809cb57df1c6@embecosm.com> <1694634574.b90urzerf1.astroid@pulse.none> In-Reply-To: <1694634574.b90urzerf1.astroid@pulse.none> From: Richard Biener Date: Thu, 14 Sep 2023 12:12:03 +0200 Message-ID: Subject: Re: [PATCHSET] Reintroduce targetrustm hooks To: Iain Buclaw Cc: Arthur Cohen , gcc-patches@gcc.gnu.org, "gcc-rust@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 13, 2023 at 10:14=E2=80=AFPM Iain Buclaw via Gcc-patches wrote: > > Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm: > > Alright, was not expecting to mess up this patchset so bad so here we g= o: > > > > This patchset reintroduces proper targetrustm hooks without the old > > problematic mess of macros we had, which had been removed for the first > > merge of gccrs upstream. > > > > Tested on x86-64 GNU Linux, and has also been present in our developmen= t > > repository for a long time - added by this pull-request from Iain [1] > > which was merged in October 2022. > > > > Ok for trunk? > > > > [PATCH 01/14] rust: Add skeleton support and documentation for > > [PATCH 02/14] rust: Reintroduce TARGET_RUST_CPU_INFO hook > > [PATCH 03/14] rust: Reintroduce TARGET_RUST_OS_INFO hook > > [PATCH 04/14] rust: Implement TARGET_RUST_CPU_INFO for i[34567]86-*-* > > [PATCH 05/14] rust: Implement TARGET_RUST_OS_INFO for *-*-darwin* > > [PATCH 06/14] rust: Implement TARGET_RUST_OS_INFO for *-*-freebsd* > > [PATCH 07/14] rust: Implement TARGET_RUST_OS_INFO for *-*-netbsd* > > [PATCH 08/14] rust: Implement TARGET_RUST_OS_INFO for *-*-openbsd* > > [PATCH 09/14] rust: Implement TARGET_RUST_OS_INFO for *-*-solaris2*. > > [PATCH 10/14] rust: Implement TARGET_RUST_OS_INFO for *-*-dragonfly* > > [PATCH 11/14] rust: Implement TARGET_RUST_OS_INFO for *-*-vxworks* > > [PATCH 12/14] rust: Implement TARGET_RUST_OS_INFO for *-*-fuchsia*. > > [PATCH 13/14] rust: Implement TARGET_RUST_OS_INFO for > > [PATCH 14/14] rust: Implement TARGET_RUST_OS_INFO for *-*-*linux*. > > > > Thanks for eventually getting round to this. > > As the co-author of this patch series, I'm not going to look at it. > > FWIW, these being Rust-specific target changes isolated to just > Rust-specific files, you should have the automony to commit without > needing any request for review - at least this is my understanding when > have made D-specific target changes in the past that have not touched > common back-end headers. > > I'll let someone else confirm and check over the shared parts touched by > the patch however. I confirm. I briefly went over the shared parts and they look OK. Thanks, Richard. > For reviewers, this is pretty much a mirror of the D front-end's CPU and > OS-specific target hooks (D has built-in version identifiers, not > built-in attributes, but both Rust and D are otherwise the same in the > kind of information exposed by them). > > > [1]: https://github.com/Rust-GCC/gccrs/pull/1543 > > > > The other GitHub pull request that added these is here. > > https://github.com/Rust-GCC/gccrs/pull/1596 > > Regards, > Iain.