From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 499E73856B67; Tue, 6 Dec 2022 11:04:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 499E73856B67 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22b.google.com with SMTP id s10so2785434ljg.1; Tue, 06 Dec 2022 03:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v0KkUqq+KipBtqafu0UyT8X1wRpXf0JWlReYZsCDZ6U=; b=M09iK40Cqkqi0m0Lc+hCnKpGedjOhWqUMdHwqn5APXBQJuiZE/ULPJqTlaLataAYdy KWdHxKfKuGurkfiSj9ig5YuVa0417uzwdmcM96jA9LxA4jtsBL0/XzXmINqIwuY7s4OD 8eF3vgIjDpuhUcaYGsG85j9wcdPATtksoAf/TU3OdkhrQntp96QDZHatXnQkwrvCz969 E/s+SZRwVzReQhs4fQzF/aCqGVL8n6kDvD+KMFJUJhSZ4JtjMc7JTwpMYB+bTxBmbvbO XFjQWb6QNJn1vwSiaL/NwIdQY6EWwhlpZb1pRmByOmAiZs91ZlZIG3Ydbho//8XQ/2kM ei4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v0KkUqq+KipBtqafu0UyT8X1wRpXf0JWlReYZsCDZ6U=; b=M6Ea9UMxZh/EOt8rQN5J8Y1fn1YmZJSVwH3MWw1HobLL0jkoZBbOBmiv0scVOb3LK3 Z/bZlEMACJtKu2gRZfW8tmoBRyMOLUfFieSXkixkXyf8e5O9MGTIks4i8MGxizEPTt2v VEZIbQQapq36Q5aPtqUKBfTHgWGG2FJhSBmMopQOkl8Qb3xVB9tHAIh87rRHaR0nvB3O D3WUgwFi6mbFnoyWwXHFCZME/C/0n9lbhRnw+kTjXy3P7GyPazHyzZCB8N3DeRtO5AT6 My20KpzXke8E82KqIgnApl3XLLbcC2k1gOwwPitYGTgNmF7NgGEmBkrVq5SY7a0Iup/2 M55w== X-Gm-Message-State: ANoB5pmvkTQsCABokCp+pKVlm13HBHbq0K8qj3HMsmx+874kMYmwe461 VywoW1FnqjXnGGhubPH17oMKSxaiAKLVMr1vE2s= X-Google-Smtp-Source: AA0mqf5Bln7HXY5nQaPIJWY1aYKAf6F9cyt5AGD4TVgcqltGofkEDNufy4M/Z8/CCcYULC9rkCjh5f2NsFGUYGF7QKE= X-Received: by 2002:a2e:84d6:0:b0:279:7acc:9d1a with SMTP id q22-20020a2e84d6000000b002797acc9d1amr20530133ljh.297.1670324649434; Tue, 06 Dec 2022 03:04:09 -0800 (PST) MIME-Version: 1.0 References: <20221206101417.778807-1-arthur.cohen@embecosm.com> In-Reply-To: <20221206101417.778807-1-arthur.cohen@embecosm.com> From: Richard Biener Date: Tue, 6 Dec 2022 12:03:56 +0100 Message-ID: Subject: Re: Rust front-end patches v4 To: arthur.cohen@embecosm.com Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 6, 2022 at 11:11 AM wrote: > > This patchset contains the fixed version of our most recent patchset. We > have fixed most of the issues noted in the previous round of reviews, and are > keeping some for later as they would otherwise create too many conflicts with > our updated development branch. > > Similarly to the previous round of patches, this patchset does not contain any > new features - only fixes for the reviews of the v3. New features will follow > shortly once that first patchset is merged. > > Once again, thank you to all the contributors who made this possible and > especially to Philip Herron for his dedication to the project. Thanks a lot - this is OK to merge now, thanks for your patience and I'm looking forward for the future improvements. Thanks, Richard. > You can see the current status of our work on our branch: > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master > > Patch status table: > > An 'x' in the first column indicates a patch has been reviewed. > One in the second column indicates that a patch has been approved. > > |0001-Use-DW_ATE_UTF-for-the-Rust-char-type.patch |x|x| > |0002-gccrs-Add-necessary-hooks-for-a-Rust-front-end-tests.patch|x|x| > |0003-gccrs-Add-Debug-info-testsuite.patch | | | > |0004-gccrs-Add-link-cases-testsuite.patch | | | > |0005-gccrs-Add-general-compilation-test-cases.patch | | | > |0006-gccrs-Add-execution-test-cases.patch | | | > |0007-gccrs-Add-gcc-check-target-check-rust.patch |x| | > |0008-gccrs-Add-Rust-front-end-base-AST-data-structures.patch | | | > |0009-gccrs-Add-definitions-of-Rust-Items-in-AST-data-stru.patch| | | > |0010-gccrs-Add-full-definitions-of-Rust-AST-data-structur.patch| | | > |0011-gccrs-Add-Rust-AST-visitors.patch | | | > |0012-gccrs-Add-Lexer-for-Rust-front-end.patch |x| | > |0013-gccrs-Add-Parser-for-Rust-front-end-pt.1.patch | | | > |0014-gccrs-Add-Parser-for-Rust-front-end-pt.2.patch | | | > |0015-gccrs-Add-expansion-pass-for-the-Rust-front-end.patch | | | > |0016-gccrs-Add-name-resolution-pass-to-the-Rust-front-end.patch| | | > |0017-gccrs-Add-declarations-for-Rust-HIR.patch | | | > |0018-gccrs-Add-HIR-definitions-and-visitor-framework.patch | | | > |0019-gccrs-Add-AST-to-HIR-lowering-pass.patch | | | > |0020-gccrs-Add-wrapper-for-make_unique.patch | | | > |0021-gccrs-Add-port-of-FNV-hash-used-during-legacy-symbol.patch| | | > |0022-gccrs-Add-Rust-ABI-enum-helpers.patch | | | > |0023-gccrs-Add-Base62-implementation.patch | | | > |0024-gccrs-Add-implementation-of-Optional.patch | | | > |0025-gccrs-Add-attributes-checker.patch | | | > |0026-gccrs-Add-helpers-mappings-canonical-path-and-lang-i.patch| | | > |0027-gccrs-Add-type-resolution-and-trait-solving-pass.patch | | | > |0028-gccrs-Add-Rust-type-information.patch | | | > |0029-gccrs-Add-remaining-type-system-transformations.patch | | | > |0030-gccrs-Add-unsafe-checks-for-Rust.patch | | | > |0031-gccrs-Add-const-checker.patch | | | > |0032-gccrs-Add-privacy-checks.patch | | | > |0033-gccrs-Add-dead-code-scan-on-HIR.patch | | | > |0034-gccrs-Add-unused-variable-scan.patch | | | > |0035-gccrs-Add-metadata-output-pass.patch | | | > |0036-gccrs-Add-base-for-HIR-to-GCC-GENERIC-lowering.patch | | | > |0037-gccrs-Add-HIR-to-GCC-GENERIC-lowering-for-all-nodes.patch |x|x| > |0038-gccrs-Add-HIR-to-GCC-GENERIC-lowering-entry-point.patch |x|x| > |0039-gccrs-These-are-wrappers-ported-from-reusing-gccgo.patch | | | > |0040-gccrs-Add-GCC-Rust-front-end-Make-lang.in.patch |x| | > |0041-gccrs-Add-config-lang.in.patch |x|x| > |0042-gccrs-Add-lang-spec.h.patch | | | > |0043-gccrs-Add-lang.opt.patch |x| | > |0044-gccrs-Add-compiler-driver.patch | | | > |0045-gccrs-Compiler-proper-interface-kicks-off-the-pipeli.patch| | | > |0046-gccrs-Add-README-CONTRIBUTING-and-compiler-logo.patch | | | > > Patches 34 to 39 and 44 to 45 interact with common GCC APIs: > > 0034-gccrs-Add-unused-variable-scan.patch > 0035-gccrs-Add-metadata-output-pass.patch > 0036-gccrs-Add-base-for-HIR-to-GCC-GENERIC-lowering.patch > 0037-gccrs-Add-HIR-to-GCC-GENERIC-lowering-for-all-nodes.patch > 0038-gccrs-Add-HIR-to-GCC-GENERIC-lowering-entry-point.patch > 0039-gccrs-These-are-wrappers-ported-from-reusing-gccgo.patch > 0044-gccrs-Add-compiler-driver.patch > 0045-gccrs-Compiler-proper-interface-kicks-off-the-pipeli.patch > > Patch 02 and 07 contain test infrastructure changes: > > 0002-gccrs-Add-necessary-hooks-for-a-Rust-front-end-tests.patch > 0007-gccrs-Add-gcc-check-target-check-rust.patch > > Patch 03 to 06 contain Rust test cases: > > 0003-gccrs-Add-Debug-info-testsuite.patch > 0004-gccrs-Add-link-cases-testsuite.patch > 0005-gccrs-Add-general-compilation-test-cases.patch > 0006-gccrs-Add-execution-test-cases.patch > > Patches 08 to 46 contain 'gcc/rust/' specific changes which will be hard > to review for someone not familiar with the codebase. These changes include > various transformations on our HIR, or checks specific to the Rust programming > language. > >