public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Arthur Cohen <cohenarthur.dev@gmail.com>
To: Philip Herron <philip.herron@embecosm.com>
Cc: Mark Wielaard <mark@klomp.org>,
	gcc-rust@gcc.gnu.org,  Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [PATCH] Fix byte char and byte string lexing code
Date: Thu, 23 Sep 2021 16:10:59 +0200	[thread overview]
Message-ID: <CAKNo5ARVKRpr378OsNRP5xU4QxpL9f98qtEbdGLSikUALfTQ+Q@mail.gmail.com> (raw)
In-Reply-To: <CAB2u+n2vGM32BKmb0yJnZMJirxPtKFzximSH8YU4M_SiKpHOnw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2499 bytes --]

> Something I was thinking about outside of the scope of that patch was
about the utf8 how do they get represented? Is it some kind of wchar_t?

Do you mean in C++ or in rustc? In rustc, they are represented as Unicode
Scalar Values which are 4 bytes wide.

From the docs over here: [https://doc.rust-lang.org/std/primitive.char.html]

So I'm assuming they could be represented as `int32_t`s which would also
make sense for the check

Cheers,
Arthur

Le jeu. 23 sept. 2021 à 13:43, Philip Herron <philip.herron@embecosm.com> a
écrit :

> Hi guys,
>
> Thanks, Thomas for raising the PR it is currently being merged. We will
> raise the next PR to get bootstrapable builds working which will be really
> nice there is a GitHub automation for that at the moment.
>
> Something I was thinking about outside of the scope of that patch was
> about the utf8 how do they get represented? Is it some kind of wchar_t?
>
> Thanks again
>
> --Phil
>
> On Wed, 22 Sept 2021 at 21:37, Mark Wielaard <mark@klomp.org> wrote:
>
>> Hi Thomas,
>>
>> On Wed, Sep 22, 2021 at 11:48:56AM +0200, Thomas Schwinge wrote:
>> > That's <https://github.com/Rust-GCC/gccrs/pull/343>.
>> > [...]
>> > That's <https://github.com/Rust-GCC/gccrs/pull/344>.
>>
>> Ah, sorry, I don't really track the github issues and had missed
>> those. But good to see the analysis matches.
>>
>> > Both these related to <https://github.com/Rust-GCC/gccrs/issues/336>
>> > "GCC '--enable-bootstrap' build".
>>
>> To make --enable-bootstrap possible (wow, that takes a long time...)
>> you'll also need:
>> https://gcc.gnu.org/pipermail/gcc-rust/2021-September/000178.html
>>
>> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=rust-mangle-unreachable
>>
>> With this and that patch applied there are no more warnings building
>> the rust frontend, so a --enable-bootstrap (-Werror) build completes
>> successfully.
>>
>> > >
>> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=bytecharstring
>> >
>> > Thanks, that's now: <https://github.com/Rust-GCC/gccrs/pull/687>
>> > "Fix byte char and byte string lexing code".
>>
>> Thanks,
>>
>> Mark
>>
>> --
>> Gcc-rust mailing list
>> Gcc-rust@gcc.gnu.org
>> https://gcc.gnu.org/mailman/listinfo/gcc-rust
>>
> --
> Gcc-rust mailing list
> Gcc-rust@gcc.gnu.org
> https://gcc.gnu.org/mailman/listinfo/gcc-rust
>


-- 
Arthur Cohen
+33 6 10 15 73 74
cohenarthur.dev@gmail.com
https://github.com/cohenarthur

[-- Attachment #2: Type: text/html, Size: 4706 bytes --]

  reply	other threads:[~2021-09-23 14:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 22:54 Mark Wielaard
2021-09-22  9:48 ` Thomas Schwinge
2021-09-22 20:37   ` Mark Wielaard
2021-09-23 11:43     ` Philip Herron
2021-09-23 14:10       ` Arthur Cohen [this message]
2021-09-23 20:53         ` byte/char string representation (Was: [PATCH] Fix byte char and byte string lexing code) Mark Wielaard
2021-09-24 11:01           ` Philip Herron
2021-09-25 11:53             ` Mark Wielaard
2021-09-30 10:46               ` Philip Herron
2021-10-03 22:04                 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKNo5ARVKRpr378OsNRP5xU4QxpL9f98qtEbdGLSikUALfTQ+Q@mail.gmail.com \
    --to=cohenarthur.dev@gmail.com \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=mark@klomp.org \
    --cc=philip.herron@embecosm.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).