From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id B51433858D35 for ; Thu, 23 Sep 2021 14:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B51433858D35 Received: by mail-lf1-x12e.google.com with SMTP id t10so27274602lfd.8 for ; Thu, 23 Sep 2021 07:09:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C1tcWkQwcQ6qZrD3n+IBe0vUcIeOWogV4X5WSN/5vc8=; b=kDVy0IoTcoWyiU5TGe3tB78uGU+MSvZ+hsZ5IPeOwy13xGhSSXcO92V4nUo8DbghLr bq3C6h4EjzjirCk7C+nRsltbR2BIZiRhoJg0P4hLydmBR8hNr2VeDKYskyXfKgIAyyYj ElMHSlCo47bZnQ49siqlnnv0OcUxk6kDjeYIb/YIGbCfCkbqgsi7FNvQD9oYRdQ0iK2P FEZ9iHe3Wvv3ZkMV405EGQX1JW2XaqP8CCPoFKc+dF+KQwqSx7plvmUg0zdyJER2/hYW Dav30qNZsMTQhunifxv/LhYgijaDeawW0WUEkOF0JnDGdLBnTHoPzgRvwSQRywDPmiUP 8X0w== X-Gm-Message-State: AOAM531tn7lipLTMHZFqPu6qppMibL5P6GqRZDuWlqSDzGcUvEA1VO4h ghDOo/PJimHhFyn3BGjoyoBaC5TKelL1FvImbg== X-Google-Smtp-Source: ABdhPJygtrRhEFZFMxEQNhdnULJ4KSyoaUdowmvO2v1QVN5I0NeD5tBAXKkg2pdBPjUwZzkWReY0mjaG/WAe8t4lQFk= X-Received: by 2002:a2e:5345:: with SMTP id t5mr5384763ljd.193.1632406189736; Thu, 23 Sep 2021 07:09:49 -0700 (PDT) MIME-Version: 1.0 References: <20210921225430.166550-1-mark@klomp.org> <87k0j9ym7r.fsf@euler.schwinge.homeip.net> In-Reply-To: From: Arthur Cohen Date: Thu, 23 Sep 2021 16:10:59 +0200 Message-ID: Subject: Re: [PATCH] Fix byte char and byte string lexing code To: Philip Herron Cc: Mark Wielaard , gcc-rust@gcc.gnu.org, Thomas Schwinge Content-Type: multipart/alternative; boundary="0000000000001188ce05ccaa2fab" X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 14:10:00 -0000 --0000000000001188ce05ccaa2fab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Something I was thinking about outside of the scope of that patch was about the utf8 how do they get represented? Is it some kind of wchar_t? Do you mean in C++ or in rustc? In rustc, they are represented as Unicode Scalar Values which are 4 bytes wide. >From the docs over here: [https://doc.rust-lang.org/std/primitive.char.html= ] So I'm assuming they could be represented as `int32_t`s which would also make sense for the check Cheers, Arthur Le jeu. 23 sept. 2021 =C3=A0 13:43, Philip Herron a =C3=A9crit : > Hi guys, > > Thanks, Thomas for raising the PR it is currently being merged. We will > raise the next PR to get bootstrapable builds working which will be reall= y > nice there is a GitHub automation for that at the moment. > > Something I was thinking about outside of the scope of that patch was > about the utf8 how do they get represented? Is it some kind of wchar_t? > > Thanks again > > --Phil > > On Wed, 22 Sept 2021 at 21:37, Mark Wielaard wrote: > >> Hi Thomas, >> >> On Wed, Sep 22, 2021 at 11:48:56AM +0200, Thomas Schwinge wrote: >> > That's . >> > [...] >> > That's . >> >> Ah, sorry, I don't really track the github issues and had missed >> those. But good to see the analysis matches. >> >> > Both these related to >> > "GCC '--enable-bootstrap' build". >> >> To make --enable-bootstrap possible (wow, that takes a long time...) >> you'll also need: >> https://gcc.gnu.org/pipermail/gcc-rust/2021-September/000178.html >> >> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=3Drust-mangle-u= nreachable >> >> With this and that patch applied there are no more warnings building >> the rust frontend, so a --enable-bootstrap (-Werror) build completes >> successfully. >> >> > > >> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=3Dbytecharstrin= g >> > >> > Thanks, that's now: >> > "Fix byte char and byte string lexing code". >> >> Thanks, >> >> Mark >> >> -- >> Gcc-rust mailing list >> Gcc-rust@gcc.gnu.org >> https://gcc.gnu.org/mailman/listinfo/gcc-rust >> > -- > Gcc-rust mailing list > Gcc-rust@gcc.gnu.org > https://gcc.gnu.org/mailman/listinfo/gcc-rust > --=20 Arthur Cohen +33 6 10 15 73 74 cohenarthur.dev@gmail.com https://github.com/cohenarthur --0000000000001188ce05ccaa2fab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Something I was thinking abo= ut outside of the scope=20 of that patch was about the utf8 how do they get represented? Is it some kind of wchar_t?

Do you mean in C++ or in rustc? In rustc, th= ey are represented as Unicode Scalar Values which are 4 bytes wide.

=
From the docs over here: [https://doc.rust-lang.org/std/primitive.char.html]
So I'm assuming they could be represented as `int32_t`s whi= ch would also make sense for the check

Cheers,
Arthur=

Le=C2=A0jeu. 23 sept. 2021 =C3=A0=C2=A013:43, Philip Herron <philip.herron@embecosm.com> a= =C3=A9crit=C2=A0:
Hi guys,

Thanks, Thomas f= or raising the PR it is currently being merged. We will raise the next PR t= o get bootstrapable builds working which will be really nice there is a Git= Hub automation for that at the moment.

Something I= was thinking about outside of the scope of that patch was about the utf8 h= ow do they get represented? Is it some kind of wchar_t?

T= hanks again

--Phil

On Wed, 22 Sept 2021= at 21:37, Mark Wielaard <mark@klomp.org> wrote:
Hi Thomas,

On Wed, Sep 22, 2021 at 11:48:56AM +0200, Thomas Schwinge wrote:
> That's <https://github.com/Rust-GCC/gccrs/pull= /343>.
> [...]
> That's <https://github.com/Rust-GCC/gccrs/pull= /344>.

Ah, sorry, I don't really track the github issues and had missed
those. But good to see the analysis matches.

> Both these related to <https://github.com/Rust-G= CC/gccrs/issues/336>
> "GCC '--enable-bootstrap' build".

To make --enable-bootstrap possible (wow, that takes a long time...)
you'll also need:
https://gcc.gnu.org/pipermail/gcc-r= ust/2021-September/000178.html
https://code.wilde= beest.org/git/user/mjw/gccrs/commit/?h=3Drust-mangle-unreachable

With this and that patch applied there are no more warnings building
the rust frontend, so a --enable-bootstrap (-Werror) build completes
successfully.

> > https://code.wild= ebeest.org/git/user/mjw/gccrs/commit/?h=3Dbytecharstring
>
> Thanks, that's now: <https://github.com/Rust-G= CC/gccrs/pull/687>
> "Fix byte char and byte string lexing code".

Thanks,

Mark

--
Gcc-rust mailing list
Gcc-rust@gcc.gnu.= org
https://gcc.gnu.org/mailman/listinfo/gcc-rust
--
Gcc-rust mailing list
Gcc-rust@gcc.gnu.= org
https://gcc.gnu.org/mailman/listinfo/gcc-rust


--
--0000000000001188ce05ccaa2fab--