From: Mark Wielaard <mark@klomp.org>
To: Marc <dkm@kataplop.net>
Cc: gcc-rust@gcc.gnu.org
Subject: Re: [PATCH] Suppress warning in rust-ast-lower-type.h ASTLowerGenericParam.visit.
Date: Tue, 29 Jun 2021 00:47:07 +0200 [thread overview]
Message-ID: <YNpRa9VLiSOGYWjB@wildebeest.org> (raw)
In-Reply-To: <87pmw53apr.fsf@arrakis.kataplop.net>
On Tue, Jun 29, 2021 at 12:06:56AM +0200, Marc wrote:
> Hi,
>
> > Translating the AST LifetimeType to the HIR LifetimeType causes a warning:
> > warning: ‘ltt’ may be used uninitialized
>
> Was wondering why this is needed as the switch case covers all enum
> variants, how can ltt be uninitialized ? I have the same fix locally but
> was thinking something else was causing the error...
LifetimeType is a plain enum, which aren't really their own types,
they are really just ints with fancy names. We could make them enum
class, which is a strong type. Then the compiler would know the switch
really covers all enum (class) variants. But then we have to provide
the right scope/type everywhere we use them in the code (which might
be a good idea, but is more typing).
Cheers,
Mark
next prev parent reply other threads:[~2021-06-28 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 21:41 Mark Wielaard
2021-06-28 22:06 ` Marc
2021-06-28 22:47 ` Mark Wielaard [this message]
2021-06-28 23:41 ` Mark Wielaard
2021-06-29 6:28 ` Marc
2021-06-29 9:10 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNpRa9VLiSOGYWjB@wildebeest.org \
--to=mark@klomp.org \
--cc=dkm@kataplop.net \
--cc=gcc-rust@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).