From: Mark Wielaard <mark@klomp.org>
To: The Other <simplytheother@gmail.com>
Cc: gcc-rust@gcc.gnu.org
Subject: Re: [PATCH] Get rid of get_locus_slow
Date: Thu, 26 Aug 2021 21:19:44 +0200 [thread overview]
Message-ID: <YSfpUMQVLrT9SMzD@wildebeest.org> (raw)
In-Reply-To: <12501AC4-F3A0-4A4E-8984-7F3318009241@gmail.com>
On Thu, Aug 26, 2021 at 10:31:06AM +0800, The Other wrote:
> The original point of the distinction between get_locus_slow() and
> get_locus() was to avoid the overhead of virtual function calls
> whenever possible, but still have a way to access locations from
> abstract base classes like Expr.
If only we had Traits :)
> As such, I’d at least make the overridden calls ‘final override’ in
> the hope that the compiler can optimise out the virtual call.
Yes, makes sense. I'll sent an updated patch.
Thanks,
Mark
next prev parent reply other threads:[~2021-08-26 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 0:09 Mark Wielaard
2021-08-26 2:31 ` The Other
2021-08-26 19:19 ` Mark Wielaard [this message]
2021-08-26 19:25 ` [PATCHv2] " Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSfpUMQVLrT9SMzD@wildebeest.org \
--to=mark@klomp.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=simplytheother@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).