From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 68F433858C35 for ; Fri, 9 Feb 2024 10:03:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68F433858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68F433858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707473035; cv=none; b=klrw67Ozm4abjrJ6XsdTEI/ZAe8S/88rF3tbJw6WeDHmU2Ql35au7YweSuQmyXMREIeK5/oeJM5yyGABakpVEKOmkr/IYeK6dEfIUjGA2J2wup3/g/ePRlCDyTljwZfTK3te0qbz0X0ZgNhTLmTAiMuc616tGlSd1iV0BbtDSgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707473035; c=relaxed/simple; bh=FvEhjgjVh6b9C9FvcwgNk1GrHUR+BteRIbE/jTyx7o0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=tZlVDgZaGgye7TzkFPD68QkzZ1/ye/eHS8j3Jjsy6KmlWiIbE/t/H7Rzav3jh3mfH4N4fPEhMYeqbyZQHAebcvKBItMlxinGYoh3bCDZNqULQRvOVYl99TNvafKl7dgg5byKRX4m6eYqknhyWb4w7glDj0Ff7CYaBiUX6XHqbEk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707473025; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=6Jj7BMTrx6GmsHWG7s1tzk9JBjDc84XyVAJcevfoQyc=; b=CO9E+c/mVIW9/+xQYkcmpyfW3hifJlUANQrk7Myfpj8jEvPX6xEdxkV5SA3GxHUfvnpALP +6tfdtERVaH4Wmryz6nk0U4cgFwsIWzNKN3+RjvZXCq00eAEVAy5eXHBy3Mz628ZYqOc7M st9JlqS8bsb1xXNiE/uiEeQlA0RMO78= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-Au1sBKjYPWKSaERVyJlJ7A-1; Fri, 09 Feb 2024 05:03:43 -0500 X-MC-Unique: Au1sBKjYPWKSaERVyJlJ7A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F36663C0C125; Fri, 9 Feb 2024 10:03:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B44344015466; Fri, 9 Feb 2024 10:03:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 419A3dlV640375 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 9 Feb 2024 11:03:40 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 419A3dm2640374; Fri, 9 Feb 2024 11:03:39 +0100 Date: Fri, 9 Feb 2024 11:03:38 +0100 From: Jakub Jelinek To: arthur.cohen@embecosm.com Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org, Philip Herron Subject: Re: [COMMITTED 13/25] gccrs: remove old generics hack to reuse generic symbols from previous seg Message-ID: Reply-To: Jakub Jelinek References: <20240207114419.1100894-2-arthur.cohen@embecosm.com> <20240207114419.1100894-14-arthur.cohen@embecosm.com> MIME-Version: 1.0 In-Reply-To: <20240207114419.1100894-14-arthur.cohen@embecosm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote: > From: Philip Herron > > This patch introduces one regression because generics are getting better > understood over time. The code here used to apply generics with the same > symbol from previous segments which was a bit of a hack with out limited > inference variable support. The regression looks like it will be related > to another issue which needs to default integer inference variables much > more aggresivly to default integer. > > Fixes #2723 > > gcc/rust/ChangeLog: > > * typecheck/rust-hir-type-check-path.cc (TypeCheckExpr::resolve_segments): remove hack > > gcc/testsuite/ChangeLog: > > * rust/compile/issue-1773.rs: Moved to... > * rust/compile/issue-1773.rs.bak: ...here. Please don't use such suffixes in the testsuite. Either delete the testcase, or xfail it somehow until the bug is fixed. Jakub