From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id 8F63C3856967 for ; Thu, 26 Oct 2023 10:07:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F63C3856967 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F63C3856967 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::543 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698314828; cv=none; b=CBVRgWt0mGCM4WqFj/oCaBsasMOBrPPAfoANrAvG68GwsUDcqGW6YeM6KGPxP/l6ZJuudQUZDKkFTih6SlaMNJN2G0c/wzyiwC6HulDFo10UTkiwri9Yf4a++kQ/7/qG8ivX5vg19x9hxx1DbBADTWadhH+nPapbhwW4I4uK0hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698314828; c=relaxed/simple; bh=ydr7IauLnSwIm6UUTLhwZHDLzeoEOerHMA0irbOWI+E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CxQU+st650u1+62K0wNXVR+jdF/WZNULDfPGTSwu47HC76iQGQvydPw1MINyBvOR5qxdOTaQKywdAuA0h15qXqJjs9TTIJxNzGfY0ykhZNO9nTIuG5Pyb8KNUlX3Y5SkKHMl37358cclEJcXSswq637YPMh2wFKLeeNAkKEFzG8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x543.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so3867949a12.1 for ; Thu, 26 Oct 2023 03:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1698314825; x=1698919625; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oQeMaLCftX/ZahAWFKo6yYj6E347WHK0+X4dVFZdoMM=; b=Y9H3YDEeis42KfW2jrS03FrAJIagiOAvV9aAX/8mL3p8WC93Deic/hgySyN0JMCuHp 1Y3B1oKPv7ecMXCOiXDe4XvPjWoRck/fbkR9z4X7PsNtEt4kQx3hHhCc/AnZMBeZqwxt vQu5w/dSbge1NbbEEp7pPoTGbVRAKQBi3biPi1SFZpQQm8fcRB+pc84H9+RVfdGRqY1K sjvpYchpL9r1bcd6nEc5TLjs/IlWLCy3pT674gyyrAoho2AvHLvGLSO5yOp0t2T1v8JV iSbHPOzNGtFMnFzw1iHQnnOIMkTrEnntABesv7LRNdHk+MYflSSo7sZlXUnhCD7RI4yu yIFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698314825; x=1698919625; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oQeMaLCftX/ZahAWFKo6yYj6E347WHK0+X4dVFZdoMM=; b=gCj8v7ASTNgYoM7Nwbxos8R+7byhtlNdqf1W98SYHYpqNQAgJT4kd1cQJj2pMWpZcr DS62tKEj9cuVlAif+eQvkMOTo+VW7Vht/uZ/l+lOosqh/gP4cwSzUeFuAZ8daLFY2XFx coJe0AiAPpWF7K1d98KAlBpmqeJLB8q7Ai+N96jIFk6LieZoD8WfoSxsLib5BsWLzauP 357B6cAfkPFBqdgCWK1CFj6+4oo/HghOSfzEuFw6vyPt9uzsjPIckEBzIwwGFuGYys2O hxIz9m0pPv3g9mTTwrh6dnhLbfIJmPUf8/zU4joGFGtGgoRg6I7aTNjGzYnSDJTXAypJ xNGQ== X-Gm-Message-State: AOJu0YwNPrK+KMwLvHVP0V00wtQpGGnecGGmiTHDWwsweAnSJa6fmXyK Ance2VIxScbJxeZsEIT4cina X-Google-Smtp-Source: AGHT+IF94gahxkFvuNlRm+Hl7EhwenXNcyPrLIRUmOES3VyK1P9F0gGgCTp2hiEQwf55T9FRlXSijA== X-Received: by 2002:a17:907:2d0a:b0:9b2:bdbb:f145 with SMTP id gs10-20020a1709072d0a00b009b2bdbbf145mr2464444ejc.34.1698314825142; Thu, 26 Oct 2023 03:07:05 -0700 (PDT) Received: from ?IPV6:2a04:cec0:1900:d3bb:5bff:fb0f:b460:fca? ([2a04:cec0:1900:d3bb:5bff:fb0f:b460:fca]) by smtp.gmail.com with ESMTPSA id m1-20020a170906580100b009ae3e6c342asm11495761ejq.111.2023.10.26.03.07.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 03:07:04 -0700 (PDT) Message-ID: Date: Thu, 26 Oct 2023 14:07:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] build: Add libgrust as compilation modules Content-Language: en-US To: Thomas Schwinge , Pierre-Emmanuel Patry Cc: gcc-rust@gcc.gnu.org, gcc-patches@gcc.gnu.org, Richard Biener References: <20231025110658.1232737-1-arthur.cohen@embecosm.com> <20231025110658.1232737-5-arthur.cohen@embecosm.com> <87sf5y1iuf.fsf@euler.schwinge.homeip.net> From: Arthur Cohen In-Reply-To: <87sf5y1iuf.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thomas, On 10/25/23 23:40, Thomas Schwinge wrote: > Hi! > > On 2023-10-25T13:06:48+0200, Arthur Cohen wrote: >> From: Pierre-Emmanuel Patry >> >> Define the libgrust directory as a host compilation module as well as >> for targets. > > I don't see a response to Richard's comments: > . > Re "doesn't build libgrust if [Rust is not enabled]", I suppose (but have > not checked) this works for the *target* libgrust module via > 'gcc/rust/config-lang.in:target_libs' requesting 'target-libgrust' only > if the Rust language is enabled? I don't know what enables/disables the > *host* libgrust build? > > > My comments: > > don't seem to have been addressed? Sorry about that! The fixup commits you mentioned should have been integrated already to the commits I pushed. I seem to have messed something up in my branch, as your last comment should have been addressed too - I'll resend clean commits where all of this is checked. > > > Also, don't you first have to get in "build: Regenerate build files" > before the 'gcc/rust/config-lang.in:target_libs' change, to avoid > breaking bisection? > > Maybe, after all, don't have a separate "build: Regenerate build files" > commit, but instead do the regeneration as part of the commits adding the > source files, in usual GCC style? Alright, that sounds good. > > And then, the 'contrib/gcc_update' change that's currently in > "libgrust: Add entry for maintainers and stub changelog file" should be > part of the commit that actually adds the files referenced therein. Okay! Thanks for the review. I'll address these shortly. > > > Grüße > Thomas > > >> ChangeLog: >> >> * Makefile.def: Add libgrust as host & target module. >> * configure.ac: Add libgrust to host tools list. >> >> gcc/rust/ChangeLog: >> >> * config-lang.in: Add libgrust as a target module for the rust >> language. >> >> Signed-off-by: Pierre-Emmanuel Patry >> --- >> Makefile.def | 2 ++ >> configure.ac | 3 ++- >> gcc/rust/config-lang.in | 2 ++ >> 3 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Makefile.def b/Makefile.def >> index 15c068e4ac4..929a6f0a08e 100644 >> --- a/Makefile.def >> +++ b/Makefile.def >> @@ -149,6 +149,7 @@ host_modules= { module= libcc1; extra_configure_flags=--enable-shared; }; >> host_modules= { module= gotools; }; >> host_modules= { module= libctf; bootstrap=true; }; >> host_modules= { module= libsframe; bootstrap=true; }; >> +host_modules= { module= libgrust; }; >> >> target_modules = { module= libstdc++-v3; >> bootstrap=true; >> @@ -192,6 +193,7 @@ target_modules = { module= libgm2; lib_path=.libs; }; >> target_modules = { module= libgomp; bootstrap= true; lib_path=.libs; }; >> target_modules = { module= libitm; lib_path=.libs; }; >> target_modules = { module= libatomic; bootstrap=true; lib_path=.libs; }; >> +target_modules = { module= libgrust; }; >> >> // These are (some of) the make targets to be done in each subdirectory. >> // Not all; these are the ones which don't have special options. >> diff --git a/configure.ac b/configure.ac >> index 692dc716343..b2a5511bab1 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -133,7 +133,7 @@ build_tools="build-texinfo build-flex build-bison build-m4 build-fixincludes" >> >> # these libraries are used by various programs built for the host environment >> #f >> -host_libs="intl libiberty opcodes bfd readline tcl tk itcl libgui zlib libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf libsframe" >> +host_libs="intl libiberty opcodes bfd readline tcl tk itcl libgui zlib libbacktrace libcpp libcody libdecnumber gmp mpfr mpc isl libiconv libctf libsframe libgrust " >> >> # these tools are built for the host environment >> # Note, the powerpc-eabi build depends on sim occurring before gdb in order to >> @@ -164,6 +164,7 @@ target_libraries="target-libgcc \ >> target-libada \ >> target-libgm2 \ >> target-libgo \ >> + target-libgrust \ >> target-libphobos \ >> target-zlib" >> >> diff --git a/gcc/rust/config-lang.in b/gcc/rust/config-lang.in >> index aac66c9b962..8f071dcb0bf 100644 >> --- a/gcc/rust/config-lang.in >> +++ b/gcc/rust/config-lang.in >> @@ -29,4 +29,6 @@ compilers="rust1\$(exeext)" >> >> build_by_default="no" >> >> +target_libs="target-libffi target-libbacktrace target-libgrust" >> + >> gtfiles="\$(srcdir)/rust/rust-lang.cc" >> -- >> 2.42.0 > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955