From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8B9B03858D20 for ; Fri, 28 Oct 2022 16:29:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B9B03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666974546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQPebjOT24iNghYR1SL1/tdvvwOGyXsL5eY8TSiVL+M=; b=XY4Rsa2+u0YR8Ql1zE2k3jPKCnMud//scPcEhlG44b3+msyYr5G4RmUFdSdLUAA+MGheQ+ gtenlhYjnSd6KL/NJsk1vZvzMM5t7zub7eH5otJ6bzfTe4GOFmtySHuUAL318P78PC/1ND 3GvsXNHIvDNEfZlKl5SEQKyQCjNV8Cw= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-371-7CQY43jEOP6yluTnMIVJUw-1; Fri, 28 Oct 2022 12:29:04 -0400 X-MC-Unique: 7CQY43jEOP6yluTnMIVJUw-1 Received: by mail-qv1-f71.google.com with SMTP id l6-20020ad44446000000b004bb60364075so3205343qvt.13 for ; Fri, 28 Oct 2022 09:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pQPebjOT24iNghYR1SL1/tdvvwOGyXsL5eY8TSiVL+M=; b=G1A3HKj+A9eRbjwhrrCApwVXcCe1j/MjvQ+4pLnraWF9Lrey081pHza+lGJTo2be+l Xyo3vCPAMuDmxlwUJ7MfTapoyf70zRgikGfuvode7hGm69vZyh3j+AE+gdpZwZNS1kjs 67G9hs+1pjtJ8Vw3N0KygHPrQ0G/27qJmd51QWHCaPlYmYz6i+KYOwhW9BO8KVr1Fwgz SNHRP1lcHwsojyxMAsew+divwbY1QbyFDa7oLov7Y80tRKMdrKveEWmyMEYFODY+nTn3 ojnB4hdA7LQJtMEuCF3LhWfZd4nq6+k/HAHcnj4jAZVTWlMvJ3Hge1e6ZojErW0wDp/p yPzg== X-Gm-Message-State: ACrzQf1geq1PtnJmEaa0EY1zaDhotbWEVcANQt2LOyMd0JYaTxg8kJBg FCOpXqzcuM9EdmcoVVjvOxunBdkc5W5Igb2RUoT0GhDfm8R2rn26Gw9kUVWlQ/AMQ1Z7Lqp9+/r CqGjsDKzfpCbFIQ== X-Received: by 2002:a05:620a:22ce:b0:6fa:b77:1c4f with SMTP id o14-20020a05620a22ce00b006fa0b771c4fmr61370qki.432.1666974544342; Fri, 28 Oct 2022 09:29:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7+pwSKmwmfaYfs4GJKlw4DFj3lyF+BXIPmhdbtuE2rX/c2LuElfEZWMQAo36VX4CTWrxSv7w== X-Received: by 2002:a05:620a:22ce:b0:6fa:b77:1c4f with SMTP id o14-20020a05620a22ce00b006fa0b771c4fmr61354qki.432.1666974544111; Fri, 28 Oct 2022 09:29:04 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id w10-20020a05620a444a00b006f9e103260dsm3340816qkp.91.2022.10.28.09.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 09:29:03 -0700 (PDT) Message-ID: Subject: Re: Rust frontend patches v3 From: David Malcolm To: Arthur Cohen , gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org Date: Fri, 28 Oct 2022 12:29:02 -0400 In-Reply-To: <86d6f635-8270-ddd3-56a6-a53741dcaf30@embecosm.com> References: <20221026081811.602573-1-arthur.cohen@embecosm.com> <65f8a9e4-68ae-9f43-c5c7-32dde62a14c3@embecosm.com> <86d6f635-8270-ddd3-56a6-a53741dcaf30@embecosm.com> User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2022-10-28 at 17:20 +0200, Arthur Cohen wrote: >=20 >=20 > On 10/28/22 15:06, David Malcolm wrote: > > On Fri, 2022-10-28 at 13:48 +0200, Arthur Cohen wrote: > > > Hi David, > > >=20 > > > On 10/26/22 23:15, David Malcolm wrote: > > > > On Wed, 2022-10-26 at 10:17 +0200, > > > > arthur.cohen@embecosm.com=C2=A0wrote: > > > > > This is the fixed version of our previous patch set for gccrs > > > > > - > > > > > We've > > > > > adressed > > > > > the comments raised in our previous emails. [...snip...] > >=20 > > I'm guessing that almost all of gccrs testing so far has been on > > relatively small examples, so that even if the GC considers > > collecting, > > the memory usage might not have exceeded the threshold for actually > > doing the mark-and-sweep collection, and so no collection has been > > happening during your testing. > >=20 > > In case you haven't tried yet, you might want to try adding: > > =C2=A0=C2=A0 --param=3Dggc-min-expand=3D0 --param=3Dggc-min-heapsize=3D= 0 > > which IIRC forces the GC to actually do its mark-and-sweep > > collection > > at every potential point where it might collect. >=20 > That's very helpful, thanks a lot. I've ran our testsuite with these > and=20 > found no issues, but we might consider adding that to our CI setup to > make sure. Great! Though as noted, for libgccjit it slows the testsuite down *massively*, so you might want to bear that in mind. I'm doing it for libgccjit because libgccjit looks like a "frontend" to the rest of the GCC codebase, but it's a deeply weird one, and so tends to uncover weird issues :-/ Dave >=20 > Kindly, >=20 > Arthur >=20 > > I use these params in libgccjit's test suite; it massively slows > > things > > down, but it makes any GC misuse crash immediately even on minimal > > test > > cases, rather than hiding problems until you have a big (and thus > > nasty) test case. > >=20 > > Hope this is helpful > > Dave > >=20 > >=20 > > >=20 > > > > Hope this is constructive > > > > Dave > > > >=20 > > >=20 > > > Thanks a lot for the input, > > >=20 > > > All the best, > > >=20 > > > Arthur > > >=20 > > >=20 > > >=20 > > >=20 > >=20