From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
To: Thomas Schwinge <thomas@codesourcery.com>,
Arthur Cohen <arthur.cohen@embecosm.com>,
gcc-rust@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: Iain Sandoe <iain@sandoe.co.uk>
Subject: Re: libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056]
Date: Thu, 4 Jan 2024 16:43:43 +0100 [thread overview]
Message-ID: <bc46cc9a-e86e-4266-ad11-9026e6a10704@embecosm.com> (raw)
In-Reply-To: <87h6kfsazx.fsf@euler.schwinge.homeip.net>
[-- Attachment #1.1.1: Type: text/plain, Size: 552 bytes --]
Hello Thomas,
On 12/18/23 17:58, Thomas Schwinge wrote:
>> --- a/libgrust/configure.ac
>> +++ b/libgrust/configure.ac
>
>> -# AM_ENABLE_MULTILIB(, ..)
>> +AM_ENABLE_MULTILIB(, ..)
>
> Such a change was applied eventually, and is necessary for target builds
> -- but potentially harmful for host builds. OK to push the attached
> "libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056]"?
These changes make sense, I'm fine with those being pushed.
Regards,
--
Patry Pierre-Emmanuel
Compiler Engineer - Embecosm
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2513 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 665 bytes --]
next prev parent reply other threads:[~2024-01-04 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:06 [PATCH v2 1/4] libgrust: Add entry for maintainers and stub changelog file Arthur Cohen
2023-10-25 11:06 ` [PATCH v2 2/4] libgrust: Add libproc_macro and build system Arthur Cohen
2023-10-26 8:21 ` Thomas Schwinge
2023-10-27 7:51 ` Iain Sandoe
2023-10-27 14:20 ` Thomas Schwinge
2023-10-27 20:32 ` Disable target libgrust if we're not building target libstdc++ (was: [PATCH v2 2/4] libgrust: Add libproc_macro and build system) Thomas Schwinge
2023-12-18 16:58 ` libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056] " Thomas Schwinge
2024-01-04 15:43 ` Pierre-Emmanuel Patry [this message]
2023-12-15 9:53 ` [PATCH v2 2/4] libgrust: Add libproc_macro and build system Thomas Schwinge
2024-01-16 15:07 ` Jason Merrill
2023-10-25 11:06 ` [PATCH v2 3/4] build: Add libgrust as compilation modules Arthur Cohen
2023-10-25 11:09 ` [PATCH v2 4/4] build: Regenerate build files Arthur Cohen
2023-10-25 21:40 ` [PATCH v2 3/4] build: Add libgrust as compilation modules Thomas Schwinge
2023-10-26 12:07 ` Arthur Cohen
2023-10-27 10:24 ` Only build host libgrust if the Rust language is enabled (was: [PATCH v2 3/4] build: Add libgrust as compilation modules) Thomas Schwinge
2023-10-25 11:06 ` [PATCH v2 4/4] build: Regenerate build files Arthur Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc46cc9a-e86e-4266-ad11-9026e6a10704@embecosm.com \
--to=pierre-emmanuel.patry@embecosm.com \
--cc=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).