[Bug rust/108631] New: gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[Bug rust/108631] New: gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108631

            Bug ID: 108631
           Summary: gcc/rust/backend/rust-constexpr.cc:2099:33: error: too
                    few arguments to function ‘tree_node*
                    Rust::Compile::unshare_constructor(tree, const char*,
                    int, const char*)’ with
                    --enable-gather-detailed-mem-stats
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rust
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: cohenarthur at gcc dot gnu.org, dkm at gcc dot gnu.org,
                    gcc-rust at gcc dot gnu.org
  Target Milestone: ---

With --enable-gather-detailed-mem-stats enabled I get since
r13-5533-ge66fec8e6ba35e:

../../gcc/rust/backend/rust-constexpr.cc: In function ‘tree_node*
Rust::Compile::eval_constant_expression(const constexpr_ctx*, tree, bool,
bool*, bool*, tree_node**)’:
../../gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 2099 |         r = unshare_constructor (r);
      |             ~~~~~~~~~~~~~~~~~~~~^~~
../../gcc/rust/backend/rust-constexpr.cc:87:1: note: declared here
   87 | unshare_constructor (tree t MEM_STAT_DECL);
      | ^~~~~~~~~~~~~~~~~~~
../../gcc/rust/backend/rust-constexpr.cc:2149:40: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 2149 |             init = unshare_constructor (init);
      |                    ~~~~~~~~~~~~~~~~~~~~^~~~~~
../../gcc/rust/backend/rust-constexpr.cc:87:1: note: declared here
   87 | unshare_constructor (tree t MEM_STAT_DECL);
      | ^~~~~~~~~~~~~~~~~~~
../../gcc/rust/backend/rust-constexpr.cc: In function ‘tree_node*
Rust::Compile::eval_store_expression(const constexpr_ctx*, tree, bool, bool*,
bool*)’:
../../gcc/rust/backend/rust-constexpr.cc:2933:30: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 2933 |   init = unshare_constructor (init);
      |          ~~~~~~~~~~~~~~~~~~~~^~~~~~
../../gcc/rust/backend/rust-constexpr.cc:87:1: note: declared here
   87 | unshare_constructor (tree t MEM_STAT_DECL);
      | ^~~~~~~~~~~~~~~~~~~
../../gcc/rust/backend/rust-constexpr.cc: In function ‘tree_node*
Rust::Compile::eval_call_expression(const constexpr_ctx*, tree, bool, bool*,
bool*)’:
../../gcc/rust/backend/rust-constexpr.cc:3555:45: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 3555 |                   arg = unshare_constructor (arg);
      |                         ~~~~~~~~~~~~~~~~~~~~^~~~~
../../gcc/rust/backend/rust-constexpr.cc:87:1: note: declared here
   87 | unshare_constructor (tree t MEM_STAT_DECL);
      | ^~~~~~~~~~~~~~~~~~~
../../gcc/rust/backend/rust-constexpr.cc: In function ‘long int
Rust::Compile::find_array_ctor_elt(tree, tree, bool)’:
../../gcc/rust/backend/rust-constexpr.cc:4282:49: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 4282 |                   e.value = unshare_constructor (value);
      |                             ~~~~~~~~~~~~~~~~~~~~^~~~~~~
../../gcc/rust/backend/rust-constexpr.cc:4170:1: note: declared here
 4170 | unshare_constructor (tree t MEM_STAT_DECL)
      | ^~~~~~~~~~~~~~~~~~~
../../gcc/rust/backend/rust-constexpr.cc:4298:49: error: too few arguments to
function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int,
const char*)’
 4298 |                   e.value = unshare_constructor (value);
      |                             ~~~~~~~~~~~~~~~~~~~~^~~~~~~
../../gcc/rust/backend/rust-constexpr.cc:4170:1: note: declared here
 4170 | unshare_constructor (tree t MEM_STAT_DECL)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/108631] gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108631

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 54384
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54384&action=edit
Patch candidate

Please check what you get with -fmem-report with the suggested patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/108631] gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[cohenarthur at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108631

Arthur Cohen <cohenarthur at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-02-09
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Arthur Cohen <cohenarthur at gcc dot gnu.org> ---
Patch looks good to me Martin, thank you. Will you push it directly?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/108631] gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108631

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Arthur Cohen from comment #2)
> Patch looks good to me Martin, thank you. Will you push it directly?

Do you see reasonable allocations when you run -fmem-report w/
--enable-gather-detailed-mem-stats? Please push it yourself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug rust/108631] gcc/rust/backend/rust-constexpr.cc:2099:33: error: too few arguments to function ‘tree_node* Rust::Compile::unshare_constructor(tree, const char*, int, const char*)’ with --enable-gather-detailed-mem-stats

[cohenarthur at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108631

Arthur Cohen <cohenarthur at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |cohenarthur at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.