From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-rust@gcc.gnu.org
Subject: [Bug rust/114629] rust-ast-resolve-expr contains bloated code for funny_error
Date: Tue, 09 Apr 2024 00:11:24 +0000 [thread overview]
Message-ID: <bug-114629-35322-D8dbCrK0vh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114629-35322@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114629
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Pierre-Emmanuel Patry from comment #2)
> I can see the problem with the message, but I don't think we can remove the
> behavior as we have to match rustc's behavior. The compiler has to ICE when
> meeting this identifier. I suggest changing the message to rustc's one "It
> looks like you're trying to break rust; would you like some ICE?" and
> removing the "gcc" identifier check.
Really this sounds like a bad idea to copy 100% of what rustc does. Instead we
should follow the rust language specification (hopefully that actually exists).
While you are at it, it would be useful to add a link to the rust langauge
specification (like there is for almost all other languages [I see objective-C
is not listed]) to https://gcc.gnu.org/readings.html .
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2024-04-09 0:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 15:38 [Bug rust/114629] New: " roland.illig at gmx dot de
2024-04-07 19:11 ` [Bug rust/114629] " pinskia at gcc dot gnu.org
2024-04-07 23:44 ` sjames at gcc dot gnu.org
2024-04-08 7:58 ` pierre-emmanuel.patry at embecosm dot com
2024-04-08 8:47 ` rguenth at gcc dot gnu.org
2024-04-08 9:45 ` iains at gcc dot gnu.org
2024-04-09 0:11 ` pinskia at gcc dot gnu.org [this message]
2024-04-09 7:18 ` Jakub Dupak
2024-04-09 0:52 ` pinskia at gcc dot gnu.org
2024-04-09 7:07 ` dkm at gcc dot gnu.org
2024-04-09 10:57 ` iains at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-114629-35322-D8dbCrK0vh@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).