[Bug rust/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[Bug rust/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[cohenarthur at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

Arthur Cohen <cohenarthur at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkm at gcc dot gnu.org,
                   |                            |gcc-rust at gcc dot gnu.org
          Component|bootstrap                   |rust

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
          Component|rust                        |bootstrap

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Toplevel makefile is consider bootstrap component rather than rust ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[cohenarthur at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #9 from Arthur Cohen <cohenarthur at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #8)
> Toplevel makefile is consider bootstrap component rather than rust ...

Ah, sorry Andrew, I thought the component was referring to the origin of the
issue. Just wanted to be able to find it in the list of Rust-related issues.
Sorry!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Arthur Cohen from comment #9)
> Ah, sorry Andrew, I thought the component was referring to the origin of the
> issue. Just wanted to be able to find it in the list of Rust-related issues.
> Sorry!

One way to do this is to use `personal tags` though they only show up for your
account and not another account. This might be one of the few cases where rust
related issues are not in the rust components.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |collin.funk1 at gmail dot com

--- Comment #11 from Sam James <sjames at gcc dot gnu.org> ---
commit r15-1436-gc6a9ab8c920f29
Author: Collin Funk <collin.funk1@gmail.com>
Date:   Thu Jun 13 17:53:55 2024 -0700

    build: Fix missing variable quotes

    When dlopen and pthread_create are in libc the variable is
    set to "none required", therefore running configure will show
    the following errors:

    ./configure: line 8997: test: too many arguments
    ./configure: line 8999: test: too many arguments
    ./configure: line 9003: test: too many arguments
    ./configure: line 9005: test: =: unary operator expected

    gcc/configure also has a similar problem on
    gcc_cv_as_mips_explicit_relocs:

    ./gcc/configure: line 30242: test: =: unary operator expected

    ChangeLog:

            * configure.ac: Quote variable result of AC_SEARCH_LIBS.
            * configure: Regenerate.

    gcc/ChangeLog:

            * configure.ac: Add missing quotation of variable
            gcc_cv_as_mips_explicit_relocs.
            * configure: Regenerate.

    Signed-off-by: Collin Funk <collin.funk1@gmail.com>

But the crate vs create needs fixing still.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by YunQiang Su <syq@gcc.gnu.org>:

https://gcc.gnu.org/g:8088374a868aacab4dff208ec3e3fde790a1d9a3

commit r15-1446-g8088374a868aacab4dff208ec3e3fde790a1d9a3
Author: YunQiang Su <syq@gcc.gnu.org>
Date:   Wed Jun 19 22:30:22 2024 +0800

    Build: Fix typo ac_cv_search_pthread_crate

    The correct variable name is
      ac_cv_search_pthread_create

    ChangeLog:
            PR bootstrap/115453
            * configure.ac: Fix typo ac_cv_search_pthread_crate.
            * configure: Regnerate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[syq at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

YunQiang Su <syq at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from YunQiang Su <syq at gcc dot gnu.org> ---
It has been fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[collin.funk1 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #14 from Collin Funk <collin.funk1 at gmail dot com> ---
(In reply to Sam James from comment #11)
> But the crate vs create needs fixing still.

Oops. Sorry, I thought a correct patch here was being used not mine. If I had
known I would have submitted a fixed patch.

(In reply to YunQiang Su from comment #13)
> It has been fixed.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[mark at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

Mark Wielaard <mark at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at gcc dot gnu.org

--- Comment #15 from Mark Wielaard <mark at gcc dot gnu.org> ---
Something seems to have gone slightly wrong when regenerating the configure
files.
The gcc-autoregen bot is unhappy:
https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen

https://builder.sourceware.org/buildbot/#/builders/269/builds/5952

Sourceware

    Buildersgcc-autoregen5952git diffstdio

        Anonymous

git diff --exit-code
 in dir /home/builder/shared/bb2-2/worker/gcc-autoregen/build (timeout 1200
secs)
 watching logfiles {}
 argv: [b'git', b'diff', b'--exit-code']
 environment:
  BUILDMASTER=builder.sourceware.org
  BUILDMASTER_PORT=9989
  CCACHE_DIR=/home/builder/shared/autotools/ccache
  CCACHE_LIBDIR=/usr/lib/ccache
  HOME=/home/builder
  HOSTNAME=cf526139a6b4
  IMAGE_NAME=autotools
  LC_CTYPE=C.UTF-8
 
PATH=/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
  PWD=/home/builder/shared/bb2-2/worker/gcc-autoregen/build
  WORKERNAME=bb2-2
 using PTY: False
diff --git a/configure b/configure
index 6e95b27d9df..03dad4d362d 100755
--- a/configure
+++ b/configure
@@ -19746,7 +19746,7 @@ config.status
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"

-Copyright (C)  Free Software Foundation, Inc.
+Copyright (C) 2012 Free Software Foundation, Inc.
 This config.status script is free software; the Free Software Foundation
 gives unlimited permission to copy, distribute and modify it."

diff --git a/gcc/configure b/gcc/configure
index b536af664d3..a8fc4bb34aa 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -30239,7 +30239,7 @@ else
 fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result:
$gcc_cv_as_mips_explicit_relocs_pcrel" >&5
 $as_echo "$gcc_cv_as_mips_explicit_relocs_pcrel" >&6; }
-if test "x$gcc_cv_as_mips_explicit_relocs_pcrel" = "xyes"; then
+if test $gcc_cv_as_mips_explicit_relocs_pcrel = yes; then

 $as_echo "#define MIPS_EXPLICIT_RELOCS MIPS_EXPLICIT_RELOCS_PCREL"
>>confdefs.h

@@ -30498,7 +30498,7 @@ fi
     { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler and linker for
explicit JALR relocation" >&5
 $as_echo_n "checking assembler and linker for explicit JALR relocation... "
>&6; }
     gcc_cv_as_ld_jalr_reloc=no
-    if test $gcc_cv_as_mips_explicit_relocs = yes; then
+    if test "x$gcc_cv_as_mips_explicit_relocs" = "xyes"; then
       if test $in_tree_ld = yes ; then
         if test "$gcc_cv_gld_major_version" -eq 2 -a
"$gcc_cv_gld_minor_version" -ge 20 -o "$gcc_cv_gld_major_version" -gt 2 \
            && test $in_tree_ld_is_elf = yes; then
program finished with exit code 1
elapsedTime=0.410978

I am not sure what exactly could have caused this difference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[collin.funk1 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #16 from Collin Funk <collin.funk1 at gmail dot com> ---
(In reply to Mark Wielaard from comment #15)
> -Copyright (C)  Free Software Foundation, Inc.
> +Copyright (C) 2012 Free Software Foundation, Inc.

I thought I used the correct Autoconf version, but I guess not. I think this
should go away if you regenerate with Autoconf 2.69 (released in 2012).

> -if test "x$gcc_cv_as_mips_explicit_relocs_pcrel" = "xyes"; then
> +if test $gcc_cv_as_mips_explicit_relocs_pcrel = yes; then

I think my commit was amended to include this. Therefore the configure script
must be generated again.

Sorry for the confusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug bootstrap/115453] [15 regression] Noise from new dlopen, pthread configure checks since r15-1177-g75299e4fe50aa8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115453

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by YunQiang Su <syq@gcc.gnu.org>:

https://gcc.gnu.org/g:bea447a2982f3094aa3423b5045cea929f4f4700

commit r15-1466-gbea447a2982f3094aa3423b5045cea929f4f4700
Author: Collin Funk <collin.funk1@gmail.com>
Date:   Wed Jun 19 16:36:50 2024 -0700

    build: Fix missing variable quotes and typo

    When dlopen and pthread_create are in libc the variable is
    set to "none required", therefore running configure will show
    the following errors:

    ./configure: line 8997: test: too many arguments
    ./configure: line 8999: test: too many arguments
    ./configure: line 9003: test: too many arguments
    ./configure: line 9005: test: =: unary operator expected

    ChangeLog:

            PR bootstrap/115453
            * configure.ac: Quote variable result of AC_SEARCH_LIBS.  Fix
            typo ac_cv_search_pthread_crate.
            * configure: Regenerate.

    Signed-off-by: Collin Funk <collin.funk1@gmail.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.