From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 3BC763858D38 for ; Tue, 21 Nov 2023 14:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BC763858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3BC763858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700576428; cv=none; b=kXOYOL0FDVF+cxUsDthJKF060Ehb3cyglDvZX/nUvL1GUZoipcQHNu671CyDwd4DIlr/8hJ1jc4fNAisn2hLfdSl7jNxHZW6kunDu4kB7/6LmofgMqUXIqOJbnGrZDXYtS9c9to5c618B2Z3xJpftbObLhwVUpPu0cE1P1+xxSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700576428; c=relaxed/simple; bh=T0Yl76QggL3eGq3+Y/+G2olOPxfnEt9HAcsOvesBxYs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=W5SLCQ8n3sUAqh11r/cXuaP5xoRDQsRHpKB6tAVsAhMHkZUzzoIIqVnsJ3puKyjhV19pwGpH2J9pNoM2b2cxt8Z6stI74qcfS6dO9X0w2q6xDglWwPuVbCMFEeQC7oUxYTK0k5OkoVpReLGy1nzDxoVPMmCuF4P8nySrms6QbVM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-507cee17b00so7303370e87.2 for ; Tue, 21 Nov 2023 06:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700576425; x=1701181225; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gLC36wtga4/LXcFohmLJph1a1kw2DweG7hD646puOhc=; b=g1GEESaxkFEKUSTpeZW/Uuxb60BT5x4lWDusG4E8VN9sWzex3gPYrIbOteZaHVDoO9 ojSR5At6zLNUrsE7U0wmhj58HiXHWG+NaHw12SrbjmdLMzATtRaT26wMtyXPpwyZttxQ kO+7gwUnM6OAh7vwC6Gct3lbkmUyhebLrZ5Gvnm4bHTmZsDmwZgJY57D3QgN203puWeV zQTxariLFkMY6QdVhtwjF0B/POFeU0UZwZ7PtQ0tJPG01Vct6jEp2TKvmDDGpurNpRXH zzDR/+hjfZ8K11XNI8Zsu6Ubw4flIGlkQdRpQi8jfMHQHIqZHwYKyyIMcwpdbfnW7+Qh NFqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700576425; x=1701181225; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gLC36wtga4/LXcFohmLJph1a1kw2DweG7hD646puOhc=; b=QQ1SMQfCf28WJUgNO/04dO7jJW2r/iDzTO8lgA7VHYN2UzUjOBslpSe3Q0+8bMm/jt QdWqAxcjaLp1MPoMoJlKgcIk2qdczXlc2S1m1LSYEl7MiZUY3ZXr1ZccOnRH41n15VtE eIGJIWoNFS3251v9fquamQaDozeM1YGJBqpOwNHplLGL1KWb2YSPzdbu7IxLGCGzJQUB qnPSZyeinQ+1BfBfxK43syvvGxv2WIO9oa3eesSljHoGYVobgE6ZAz/NQA7aK14tw6QC ZJHG5crT8VMiIfkvOLt9WO4J/Vw1I1GamEE3o+By4/LCnI9I9aXOw7BSjl/Kf93r3A7I gxOw== X-Gm-Message-State: AOJu0YxNq5eIPSLXTI+h2GkjRGJQc2C5VILrEhgU8tjUq2f7zVAPjOw8 Ctwzmep09yS91Ea8MVCgNUx/ X-Google-Smtp-Source: AGHT+IEYxruM5EeO3TzTAsdBz8rqO8NQZ7szRS0uZPnwfopXoioB6C8s0muUZlw5KlxbzH33gsPe8A== X-Received: by 2002:a19:ae11:0:b0:509:44fb:eb63 with SMTP id f17-20020a19ae11000000b0050944fbeb63mr7367309lfc.26.1700576424492; Tue, 21 Nov 2023 06:20:24 -0800 (PST) Received: from ?IPV6:2a04:cec2:9:3267:2948:fbd1:6cbc:29f1? ([2a04:cec2:9:3267:2948:fbd1:6cbc:29f1]) by smtp.gmail.com with ESMTPSA id p1-20020aa7cc81000000b0052ff9bae873sm4847820edt.5.2023.11.21.06.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 06:20:24 -0800 (PST) Message-ID: Date: Tue, 21 Nov 2023 16:20:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: GCC/Rust libgrust-v2/to-submit branch To: Thomas Schwinge , Pierre-Emmanuel Patry Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org References: <20230920120311.14892-1-arthur.cohen@embecosm.com> <20230920120311.14892-3-arthur.cohen@embecosm.com> <871qek608j.fsf@euler.schwinge.homeip.net> <87wmv7ztkf.fsf@euler.schwinge.homeip.net> <871qcktqxd.fsf@euler.schwinge.homeip.net> Content-Language: en-US From: Arthur Cohen In-Reply-To: <871qcktqxd.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thomas! A newer version of the library has been force-pushed to the branch `libgrust-v2/to-submit`. On 11/20/23 15:55, Thomas Schwinge wrote: > Hi! > > Arthur and Pierre-Emmanuel have prepared a GCC/Rust libgrust-v2/to-submit > branch: . > In that one, most of the issues raised have been addressed, and which > I've now successfully "tested" in my different GCC configurations, > requiring just one additional change (see end of this email). I'm using > "tested" in quotes here, as libgrust currently is still missing its > eventual content, and still is without actual users, so we may still be > up for surprises later on. ;-) > > On 2023-10-27T22:41:52+0200, I wrote: >> On 2023-09-27T00:25:16+0200, I wrote: >>> don't we also directly need to >>> incorporate here a few GCC/Rust master branch follow-on commits, like: >>> >>> - commit 171ea4e2b3e202067c50f9c206974fbe1da691c0 "fixup: Fix bootstrap build" >>> - commit 61cbe201029658c32e5c360823b9a1a17d21b03c "fixup: Fix missing build dependency" >> >> I've not yet run into the need for these two. Let's please leave these >> out of the upstream submission for now, until we understand what exactly >> these are necessary for. > > (Still the same.) Do you mean that we should remove the content of these commits from the submission? If so, I believe it's now done. > >> However: >> >>> - commit 6a8b207b9ef7f9038e0cae7766117428783825d8 "libgrust: Add dependency to libstdc++" >> >> ... this one definitely is necessary right now; see discussion in >> >> "Disable target libgrust if we're not building target libstdc++". > > This one still isn't in the GCC/Rust libgrust-v2/to-submit branch -- but > having now tested that branch, I'm now no longer seeing the respective > build failure. Isn't that change "libgrust: Add dependency to libstdc++" > still necessary, conceptually? (Maybe we're just lucky, currently?) > I'll be sure to re-test in my different GCC configurations once libgrust > gains actual content and use. (..., which might then re-expose the > original problem?) This commit was integrated into another one: fb31093105e build: Add libgrust as compilation modules (on libgrust-v2/to-submit as of 2 minutes ago) > >> And: >> >>> (Not sure if all of these are necessary and/or if that's the complete >>> list; haven't looked up the corresponding GCC/Rust GitHub PRs.) >>> >>>> --- a/gcc/rust/config-lang.in >>>> +++ b/gcc/rust/config-lang.in >>> >>>> +target_libs="target-libffi target-libbacktrace target-libgrust" >>> >>> Please don't add back 'target-libffi' and 'target-libbacktrace' here; >>> just 'target-libgrust'. (As is present in GCC/Rust master branch, and >>> per commit 7411eca498beb13729cc2acec77e68250940aa81 >>> "Rust: Don't depend on unused 'target-libffi', 'target-libbacktrace'".) >> >> ... that change is necessary, too. > > That's still unchanged in the GCC/Rust libgrust-v2/to-submit branch; > please apply to 'gcc/rust/config-lang.in': > > -target_libs="target-libffi target-libbacktrace target-libgrust" > +target_libs=target-libgrust > > Then, still should re-order the commits so that (re)generation of > auto-generated files comes before use of libgrust (so that later > bisection doesn't break), and move the 'contrib/gcc_update' update into > the commit that adds the auto-generated files. Do you mean that the regeneration should happen before the commit adding the proc_macro library? Or that when we keep going and adding more commits on top of this, we need to make sure the regeneration commit happens before any code starts using/depending on libgrust/? And alright, we'll move the changes to contrib/gcc_update into the regeneration commit. All the best, and thanks again for testing :) Arthur > > > Grüße > Thomas > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955