* PING^1 [PATCH 05/52] rust: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE [not found] ` <2433deffaba4159f49ecaa4fc50e2a065c271aad.1717134752.git.linkw@linux.ibm.com> @ 2024-06-12 9:35 ` Kewen.Lin 2024-06-21 1:48 ` PING^2 " Kewen.Lin 0 siblings, 1 reply; 2+ messages in thread From: Kewen.Lin @ 2024-06-12 9:35 UTC (permalink / raw) To: gcc-patches; +Cc: arthur.cohen, herron.philip, gcc-rust Hi, Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653339.html BR, Kewen on 2024/6/3 11:00, Kewen Lin wrote: > Joseph pointed out "floating types should have their mode, > not a poorly defined precision value" in the discussion[1], > as he and Richi suggested, the existing macros > {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE will be replaced with a > hook mode_for_floating_type. To be prepared for that, this > patch is to replace use of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE > in rust with TYPE_PRECISION of {float,{,long_}double}_type_node. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-May/651209.html > > gcc/rust/ChangeLog: > > * rust-gcc.cc (float_type): Use TYPE_PRECISION of > {float,double,long_double}_type_node to replace > {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE. > --- > gcc/rust/rust-gcc.cc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-gcc.cc > index f17e19a2dfc..38169c08985 100644 > --- a/gcc/rust/rust-gcc.cc > +++ b/gcc/rust/rust-gcc.cc > @@ -411,11 +411,11 @@ tree > float_type (int bits) > { > tree type; > - if (bits == FLOAT_TYPE_SIZE) > + if (bits == TYPE_PRECISION (float_type_node)) > type = float_type_node; > - else if (bits == DOUBLE_TYPE_SIZE) > + else if (bits == TYPE_PRECISION (double_type_node)) > type = double_type_node; > - else if (bits == LONG_DOUBLE_TYPE_SIZE) > + else if (bits == TYPE_PRECISION (long_double_type_node)) > type = long_double_type_node; > else > { ^ permalink raw reply [flat|nested] 2+ messages in thread
* PING^2 [PATCH 05/52] rust: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE 2024-06-12 9:35 ` PING^1 [PATCH 05/52] rust: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE Kewen.Lin @ 2024-06-21 1:48 ` Kewen.Lin 0 siblings, 0 replies; 2+ messages in thread From: Kewen.Lin @ 2024-06-21 1:48 UTC (permalink / raw) To: arthur.cohen, gcc-rust; +Cc: herron.philip, gcc-patches Hi! Gentle ping^2: https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653339.html BR, Kewen on 2024/6/12 17:35, Kewen.Lin wrote: > Hi, > > Gentle ping: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653339.html > > BR, > Kewen > > on 2024/6/3 11:00, Kewen Lin wrote: >> Joseph pointed out "floating types should have their mode, >> not a poorly defined precision value" in the discussion[1], >> as he and Richi suggested, the existing macros >> {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE will be replaced with a >> hook mode_for_floating_type. To be prepared for that, this >> patch is to replace use of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE >> in rust with TYPE_PRECISION of {float,{,long_}double}_type_node. >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-May/651209.html >> >> gcc/rust/ChangeLog: >> >> * rust-gcc.cc (float_type): Use TYPE_PRECISION of >> {float,double,long_double}_type_node to replace >> {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE. >> --- >> gcc/rust/rust-gcc.cc | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/rust/rust-gcc.cc b/gcc/rust/rust-gcc.cc >> index f17e19a2dfc..38169c08985 100644 >> --- a/gcc/rust/rust-gcc.cc >> +++ b/gcc/rust/rust-gcc.cc >> @@ -411,11 +411,11 @@ tree >> float_type (int bits) >> { >> tree type; >> - if (bits == FLOAT_TYPE_SIZE) >> + if (bits == TYPE_PRECISION (float_type_node)) >> type = float_type_node; >> - else if (bits == DOUBLE_TYPE_SIZE) >> + else if (bits == TYPE_PRECISION (double_type_node)) >> type = double_type_node; >> - else if (bits == LONG_DOUBLE_TYPE_SIZE) >> + else if (bits == TYPE_PRECISION (long_double_type_node)) >> type = long_double_type_node; >> else >> { > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-21 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1717134752.git.linkw@linux.ibm.com>
[not found] ` <2433deffaba4159f49ecaa4fc50e2a065c271aad.1717134752.git.linkw@linux.ibm.com>
2024-06-12 9:35 ` PING^1 [PATCH 05/52] rust: Replace uses of {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE Kewen.Lin
2024-06-21 1:48 ` PING^2 " Kewen.Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).