public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Arthur Cohen <arthur.cohen@embecosm.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Subject: Re: Rust front-end patches v4
Date: Tue, 13 Dec 2022 14:40:36 +0100	[thread overview]
Message-ID: <e7ba5be1-1611-8063-e45d-d40e4a696989@embecosm.com> (raw)
In-Reply-To: <9d59ae0f-048f-dc32-6309-c8134467bbb7@embecosm.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 7710 bytes --]

We've also added one more commit, which only affects files inside the 
Rust front-end folder. This commit adds an experimental flag, which 
blocks the compilation of Rust code when not used. We hope this helps 
indicate to users that the compiler is not yet ready, but can still be 
experimented with :)

We plan on removing that flag as soon as possible, but in the meantime, 
we think it will help not creating divide within the Rust ecosystem, as 
well as not waste Rust crate maintainers' time.

Thanks again,

Arthur

On 12/13/22 14:26, Arthur Cohen wrote:
> Hi everyone,
> 
> I have pushed the commits onto master. Thanks again for all the reviews 
> and support.
> 
> Thank you, and congratulations, to all the contributors.
> 
> All the best,
> 
> Arthur
> 
> On 12/6/22 12:03, Richard Biener via Gcc-rust wrote:
>> On Tue, Dec 6, 2022 at 11:11 AM <arthur.cohen@embecosm.com> wrote:
>>>
>>> This patchset contains the fixed version of our most recent patchset. We
>>> have fixed most of the issues noted in the previous round of reviews, 
>>> and are
>>> keeping some for later as they would otherwise create too many 
>>> conflicts with
>>> our updated development branch.
>>>
>>> Similarly to the previous round of patches, this patchset does not 
>>> contain any
>>> new features - only fixes for the reviews of the v3. New features 
>>> will follow
>>> shortly once that first patchset is merged.
>>>
>>> Once again, thank you to all the contributors who made this possible and
>>> especially to Philip Herron for his dedication to the project.
>>
>> Thanks a lot - this is OK to merge now, thanks for your patience and I'm
>> looking forward for the future improvements.
>>
>> Thanks,
>> Richard.
>>
>>> You can see the current status of our work on our branch:
>>> https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master
>>>
>>> Patch status table:
>>>
>>> An 'x' in the first column indicates a patch has been reviewed.
>>> One in the second column indicates that a patch has been approved.
>>>
>>> |0001-Use-DW_ATE_UTF-for-the-Rust-char-type.patch               |x|x|
>>> |0002-gccrs-Add-necessary-hooks-for-a-Rust-front-end-tests.patch|x|x|
>>> |0003-gccrs-Add-Debug-info-testsuite.patch                      | | |
>>> |0004-gccrs-Add-link-cases-testsuite.patch                      | | |
>>> |0005-gccrs-Add-general-compilation-test-cases.patch            | | |
>>> |0006-gccrs-Add-execution-test-cases.patch                      | | |
>>> |0007-gccrs-Add-gcc-check-target-check-rust.patch               |x| |
>>> |0008-gccrs-Add-Rust-front-end-base-AST-data-structures.patch   | | |
>>> |0009-gccrs-Add-definitions-of-Rust-Items-in-AST-data-stru.patch| | |
>>> |0010-gccrs-Add-full-definitions-of-Rust-AST-data-structur.patch| | |
>>> |0011-gccrs-Add-Rust-AST-visitors.patch                         | | |
>>> |0012-gccrs-Add-Lexer-for-Rust-front-end.patch                  |x| |
>>> |0013-gccrs-Add-Parser-for-Rust-front-end-pt.1.patch            | | |
>>> |0014-gccrs-Add-Parser-for-Rust-front-end-pt.2.patch            | | |
>>> |0015-gccrs-Add-expansion-pass-for-the-Rust-front-end.patch     | | |
>>> |0016-gccrs-Add-name-resolution-pass-to-the-Rust-front-end.patch| | |
>>> |0017-gccrs-Add-declarations-for-Rust-HIR.patch                 | | |
>>> |0018-gccrs-Add-HIR-definitions-and-visitor-framework.patch     | | |
>>> |0019-gccrs-Add-AST-to-HIR-lowering-pass.patch                  | | |
>>> |0020-gccrs-Add-wrapper-for-make_unique.patch                   | | |
>>> |0021-gccrs-Add-port-of-FNV-hash-used-during-legacy-symbol.patch| | |
>>> |0022-gccrs-Add-Rust-ABI-enum-helpers.patch                     | | |
>>> |0023-gccrs-Add-Base62-implementation.patch                     | | |
>>> |0024-gccrs-Add-implementation-of-Optional.patch                | | |
>>> |0025-gccrs-Add-attributes-checker.patch                        | | |
>>> |0026-gccrs-Add-helpers-mappings-canonical-path-and-lang-i.patch| | |
>>> |0027-gccrs-Add-type-resolution-and-trait-solving-pass.patch    | | |
>>> |0028-gccrs-Add-Rust-type-information.patch                     | | |
>>> |0029-gccrs-Add-remaining-type-system-transformations.patch     | | |
>>> |0030-gccrs-Add-unsafe-checks-for-Rust.patch                    | | |
>>> |0031-gccrs-Add-const-checker.patch                             | | |
>>> |0032-gccrs-Add-privacy-checks.patch                            | | |
>>> |0033-gccrs-Add-dead-code-scan-on-HIR.patch                     | | |
>>> |0034-gccrs-Add-unused-variable-scan.patch                      | | |
>>> |0035-gccrs-Add-metadata-output-pass.patch                      | | |
>>> |0036-gccrs-Add-base-for-HIR-to-GCC-GENERIC-lowering.patch      | | |
>>> |0037-gccrs-Add-HIR-to-GCC-GENERIC-lowering-for-all-nodes.patch |x|x|
>>> |0038-gccrs-Add-HIR-to-GCC-GENERIC-lowering-entry-point.patch   |x|x|
>>> |0039-gccrs-These-are-wrappers-ported-from-reusing-gccgo.patch  | | |
>>> |0040-gccrs-Add-GCC-Rust-front-end-Make-lang.in.patch           |x| |
>>> |0041-gccrs-Add-config-lang.in.patch                            |x|x|
>>> |0042-gccrs-Add-lang-spec.h.patch                               | | |
>>> |0043-gccrs-Add-lang.opt.patch                                  |x| |
>>> |0044-gccrs-Add-compiler-driver.patch                           | | |
>>> |0045-gccrs-Compiler-proper-interface-kicks-off-the-pipeli.patch| | |
>>> |0046-gccrs-Add-README-CONTRIBUTING-and-compiler-logo.patch     | | |
>>>
>>> Patches 34 to 39 and 44 to 45 interact with common GCC APIs:
>>>
>>> 0034-gccrs-Add-unused-variable-scan.patch
>>> 0035-gccrs-Add-metadata-output-pass.patch
>>> 0036-gccrs-Add-base-for-HIR-to-GCC-GENERIC-lowering.patch
>>> 0037-gccrs-Add-HIR-to-GCC-GENERIC-lowering-for-all-nodes.patch
>>> 0038-gccrs-Add-HIR-to-GCC-GENERIC-lowering-entry-point.patch
>>> 0039-gccrs-These-are-wrappers-ported-from-reusing-gccgo.patch
>>> 0044-gccrs-Add-compiler-driver.patch
>>> 0045-gccrs-Compiler-proper-interface-kicks-off-the-pipeli.patch
>>>
>>> Patch 02 and 07 contain test infrastructure changes:
>>>
>>> 0002-gccrs-Add-necessary-hooks-for-a-Rust-front-end-tests.patch
>>> 0007-gccrs-Add-gcc-check-target-check-rust.patch
>>>
>>> Patch 03 to 06 contain Rust test cases:
>>>
>>> 0003-gccrs-Add-Debug-info-testsuite.patch
>>> 0004-gccrs-Add-link-cases-testsuite.patch
>>> 0005-gccrs-Add-general-compilation-test-cases.patch
>>> 0006-gccrs-Add-execution-test-cases.patch
>>>
>>> Patches 08 to 46 contain 'gcc/rust/' specific changes which will be hard
>>> to review for someone not familiar with the codebase. These changes 
>>> include
>>> various transformations on our HIR, or checks specific to the Rust 
>>> programming
>>> language.
>>>
>>>
> 

-- 
Arthur Cohen <arthur.cohen@embecosm.com>

Toolchain Engineer

Embecosm GmbH

Geschäftsführer: Jeremy Bennett
Niederlassung: Nürnberg
Handelsregister: HR-B 36368
www.embecosm.de

Fürther Str. 27
90429 Nürnberg


Tel.: 091 - 128 707 040
Fax: 091 - 128 707 077

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  parent reply	other threads:[~2022-12-13 13:37 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 10:13 arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 01/46] Use DW_ATE_UTF for the Rust 'char' type arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 02/46] gccrs: Add necessary hooks for a Rust front-end testsuite arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 03/46] gccrs: Add Debug info testsuite arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 04/46] gccrs: Add link cases testsuite arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 05/46] gccrs: Add general compilation test cases arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 06/46] gccrs: Add execution " arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 07/46] gccrs: Add gcc-check-target check-rust arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 08/46] gccrs: Add Rust front-end base AST data structures arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 09/46] gccrs: Add definitions of Rust Items in " arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 10/46] gccrs: Add full definitions of Rust " arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 11/46] gccrs: Add Rust AST visitors arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 12/46] gccrs: Add Lexer for Rust front-end arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 13/46] gccrs: Add Parser for Rust front-end pt.1 arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 14/46] gccrs: Add Parser for Rust front-end pt.2 arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 15/46] gccrs: Add expansion pass for the Rust front-end arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 16/46] gccrs: Add name resolution pass to " arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 17/46] gccrs: Add declarations for Rust HIR arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 18/46] gccrs: Add HIR definitions and visitor framework arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 19/46] gccrs: Add AST to HIR lowering pass arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 20/46] gccrs: Add wrapper for make_unique arthur.cohen
2022-12-07  8:50   ` Arsen Arsenović
2022-12-07  9:14     ` Thomas Schwinge
2022-12-06 10:13 ` [PATCH Rust front-end v4 21/46] gccrs: Add port of FNV hash used during legacy symbol mangling arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 22/46] gccrs: Add Rust ABI enum helpers arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 23/46] gccrs: Add Base62 implementation arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 24/46] gccrs: Add implementation of Optional arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 25/46] gccrs: Add attributes checker arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 26/46] gccrs: Add helpers mappings canonical path and lang items arthur.cohen
2022-12-06 10:13 ` [PATCH Rust front-end v4 27/46] gccrs: Add type resolution and trait solving pass arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 28/46] gccrs: Add Rust type information arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 29/46] gccrs: Add remaining type system transformations arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 30/46] gccrs: Add unsafe checks for Rust arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 31/46] gccrs: Add const checker arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 32/46] gccrs: Add privacy checks arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 33/46] gccrs: Add dead code scan on HIR arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 34/46] gccrs: Add unused variable scan arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 35/46] gccrs: Add metadata output pass arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 36/46] gccrs: Add base for HIR to GCC GENERIC lowering arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 37/46] gccrs: Add HIR to GCC GENERIC lowering for all nodes arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 38/46] gccrs: Add HIR to GCC GENERIC lowering entry point arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 39/46] gccrs: These are wrappers ported from reusing gccgo arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 40/46] gccrs: Add GCC Rust front-end Make-lang.in arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 41/46] gccrs: Add config-lang.in arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 42/46] gccrs: Add lang-spec.h arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 43/46] gccrs: Add lang.opt arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 44/46] gccrs: Add compiler driver arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 45/46] gccrs: Compiler proper interface kicks off the pipeline arthur.cohen
2022-12-06 10:14 ` [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo arthur.cohen
2022-12-09 10:18   ` Martin Liška
2022-12-13  1:43     ` Joseph Myers
2022-12-13 12:59       ` Martin Liška
2022-12-13 18:46         ` Joseph Myers
2022-12-06 11:03 ` Rust front-end patches v4 Richard Biener
2022-12-06 11:09   ` John Paul Adrian Glaubitz
2022-12-06 11:40     ` Arthur Cohen
2022-12-06 11:57       ` John Paul Adrian Glaubitz
2022-12-06 12:40         ` Mark Wielaard
2022-12-06 11:41   ` Iain Buclaw
2022-12-10  6:39   ` Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust (was: Rust front-end patches v4) Thomas Schwinge
2022-12-10  7:37     ` Add stub 'gcc/rust/ChangeLog' (was: Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust) Thomas Schwinge
2022-12-13 13:26   ` Rust front-end patches v4 Arthur Cohen
2022-12-13 13:30     ` Martin Liška
2022-12-13 13:53       ` Arthur Cohen
2022-12-13 13:40     ` Arthur Cohen [this message]
2022-12-14 22:58       ` Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common' option (was: Rust front-end patches v4) Thomas Schwinge
2022-12-15  7:53         ` Richard Biener
2022-12-15 10:14           ` Thomas Schwinge
2022-12-15 11:16             ` Jakub Jelinek
2022-12-15 11:39               ` Iain Buclaw
2022-12-15 11:50                 ` Jakub Jelinek
2022-12-15 15:01                   ` Thomas Schwinge
2022-12-15 15:17                     ` Jakub Jelinek
2022-12-16 14:10                       ` Add '-Wno-complain-wrong-lang', and use it in 'gcc/testsuite/lib/target-supports.exp:check_compile' and elsewhere (was: Make '-frust-incomplete-and-experimental-compiler-do-not-use' a 'Common' option) Thomas Schwinge
2022-12-16 21:24                         ` Iain Buclaw
2023-01-11 11:41                         ` [PING] Add '-Wno-complain-wrong-lang', and use it in 'gcc/testsuite/lib/target-supports.exp:check_compile' and elsewhere Thomas Schwinge
2023-01-11 12:31                           ` Jakub Jelinek
2023-02-21 10:21                             ` [PING, v2] " Thomas Schwinge
2023-02-21 23:20                               ` Joseph Myers
2022-12-09 13:24 ` Rust front-end patches v4 Martin Liška
2022-12-10 21:44   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7ba5be1-1611-8063-e45d-d40e4a696989@embecosm.com \
    --to=arthur.cohen@embecosm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-rust@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).