Re: [PATCH 2/2] gccrs: fixup: Fix missing build dependency

[Arthur Cohen <arthur.cohen@embecosm.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 3036 bytes --]

Hi Richard,

On 1/11/24 15:23, Richard Biener wrote:
> On Thu, 11 Jan 2024, Arthur Cohen wrote:
> 
>> From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
>>
>> Fix the missing dependency between the gcc and libgrust.
>>
>> ChangeLog:
>>
>> 	* Makefile.def: Add a dependency to libgrust for all-gcc.
>> 	* Makefile.in: Regenerate the file.
>>
>> Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
>> ---
>>   Makefile.def |  1 +
>>   Makefile.in  | 10 ++++++++++
>>   2 files changed, 11 insertions(+)
>>
>> diff --git a/Makefile.def b/Makefile.def
>> index 1a256db5518..19954e7d731 100644
>> --- a/Makefile.def
>> +++ b/Makefile.def
>> @@ -375,6 +375,7 @@ dependencies = { module=configure-gcc; on=all-ld; };
>>   dependencies = { module=configure-gcc; on=all-gold; };
>>   dependencies = { module=configure-gcc; on=all-libiconv; };
>>   dependencies = { module=all-gcc; on=all-libiberty; hard=true; };
>> +dependencies = { module=all-gcc; on=all-libgrust; };
> 
> That looks wrong?  Why is libgrust both a host and a target module?
> Is that really necessary?  IIRC the rust frontend isn't written in
> rust?

libgrust is both a host and target module as it implements some of the 
parser functionality - we had to split it from the frontend so that 
users of the procedural macro library could use it. So both the host and 
target link to that little bit of parser. Does that make sense?

Best,

Arthur

> 
> The other patch is OK to push.
> 
>>   dependencies = { module=all-gcc; on=all-gettext; };
>>   dependencies = { module=all-gcc; on=all-mpfr; };
>>   dependencies = { module=all-gcc; on=all-mpc; };
>> diff --git a/Makefile.in b/Makefile.in
>> index 263b979609b..edb0c8a9a42 100644
>> --- a/Makefile.in
>> +++ b/Makefile.in
>> @@ -67558,6 +67558,16 @@ all-stagetrain-gcc: all-stagetrain-libiberty
>>   all-stagefeedback-gcc: all-stagefeedback-libiberty
>>   all-stageautoprofile-gcc: all-stageautoprofile-libiberty
>>   all-stageautofeedback-gcc: all-stageautofeedback-libiberty
>> +all-gcc: maybe-all-libgrust
>> +all-stage1-gcc: maybe-all-stage1-libgrust
>> +all-stage2-gcc: maybe-all-stage2-libgrust
>> +all-stage3-gcc: maybe-all-stage3-libgrust
>> +all-stage4-gcc: maybe-all-stage4-libgrust
>> +all-stageprofile-gcc: maybe-all-stageprofile-libgrust
>> +all-stagetrain-gcc: maybe-all-stagetrain-libgrust
>> +all-stagefeedback-gcc: maybe-all-stagefeedback-libgrust
>> +all-stageautoprofile-gcc: maybe-all-stageautoprofile-libgrust
>> +all-stageautofeedback-gcc: maybe-all-stageautofeedback-libgrust
>>   all-gcc: maybe-all-gettext
>>   all-stage1-gcc: maybe-all-stage1-gettext
>>   all-stage2-gcc: maybe-all-stage2-gettext
>>
> 

-- 
Arthur Cohen <arthur.cohen@embecosm.com>

Toolchain Engineer

Embecosm GmbH

Geschäftsführer: Jeremy Bennett
Niederlassung: Nürnberg
Handelsregister: HR-B 36368
www.embecosm.de

Fürther Str. 27
90429 Nürnberg


Tel.: 091 - 128 707 040
Fax: 091 - 128 707 077

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]