From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 04CDD385481F for ; Wed, 23 Jun 2021 16:26:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 04CDD385481F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x329.google.com with SMTP id o33-20020a05600c5121b02901e360c98c08so2626826wms.5 for ; Wed, 23 Jun 2021 09:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=cv+neWJkoEXN4pQN/kESwVLAXVg4VbU7dokHxetnIBM=; b=EHa/rliNTfVmimnnR5FOzqXkFo8oVStPLcDh3XB38r5cwBJe45g3orojSjHdkeppJ7 OkTA8Qz6lOJMJd7wDlDWWUzm8VPRI/ZepXFiMr9yd/bHCkdMEYfBj1Y7BC8t4PT7mTaD 4tVzKF9q5R2jpgvW8ylR812OGWbe2C2FUvRYFkRWEJn5Xd9W7ATBMMaqyYkXOAaTxLEJ LNkUZJNANNCxIsATcHFFX0EVQ2lSiTbiKGaGbVTB3GC8Gl0avb5x2i4hDUHPNrJXGMKG 5G1RJMbt6oafxdeX7yBx/rRmTkB3+dlywKNcTZ6UjtjYIWk/zjM/sSjFmgQmaqZebUg/ F9IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=cv+neWJkoEXN4pQN/kESwVLAXVg4VbU7dokHxetnIBM=; b=NkaB+6dOudlZMO0ygToMZsQWuLiCdKUtwkltcfmuW8MeOTohvULwPujRql7oDKYeu/ aYsLEW2saSMEwU+CLe1zwC+1cnxAVu711pYQsM/ie8qMY/YTpJQOUCLTfbbfVRX28465 3/r9y3MQnBkBIdQnkI3MrzyH/oHONyK8rQMzxO1Qf4Xnb2UV/YV18CT1BIX1Ra/DWimh Z6k+SiPQDVGegSVmtIJLhb/4V/R/YoWEo0809ZDkoXTliQ9bYKQs/lXE8Xpo8D4PPv24 CD+zrknDRD9rY4JPvO1vxI4Wd95arna3xQ/0m/HHu+wgFIuwCSecv2Vz4kk3jr3WDO0w /1Pw== X-Gm-Message-State: AOAM531RcHnx4niWGCEthV8N5XDBixTQGQx/OuL6zvALznPt6cPiqbk6 A4HRPUVi9Hu79hl4vjZMppI/PznvRF+xGA== X-Google-Smtp-Source: ABdhPJzNJYpLvxymMoq2PhfOJJ+LZmUEVC34zeUQ7b0A8fl0ypyH+Pg1WLNVgauIUWv2rmm1zJyP2w== X-Received: by 2002:a1c:4c0c:: with SMTP id z12mr670577wmf.0.1624465576764; Wed, 23 Jun 2021 09:26:16 -0700 (PDT) Received: from [192.168.0.40] ([86.14.124.218]) by smtp.gmail.com with ESMTPSA id l12sm508477wro.32.2021.06.23.09.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 09:26:16 -0700 (PDT) Subject: Re: tuple indexes To: Mark Wielaard , gcc-rust@gcc.gnu.org References: <2f353271-7ee6-ab21-e862-69582a503627@embecosm.com> <8e2ce8ca-ff1d-4b25-d3bf-f4f523edef03@embecosm.com> From: Philip Herron Message-ID: Date: Wed, 23 Jun 2021 17:26:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4015zKTUVFi6zWQ8nvMjLWB84Q4VyPjPQ" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 16:26:19 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4015zKTUVFi6zWQ8nvMjLWB84Q4VyPjPQ Content-Type: multipart/mixed; boundary="udgkrllf59V4BEvklj56UcvBi8nuDoCFB"; protected-headers="v1" From: Philip Herron To: Mark Wielaard , gcc-rust@gcc.gnu.org Message-ID: Subject: Re: tuple indexes References: <2f353271-7ee6-ab21-e862-69582a503627@embecosm.com> <8e2ce8ca-ff1d-4b25-d3bf-f4f523edef03@embecosm.com> In-Reply-To: --udgkrllf59V4BEvklj56UcvBi8nuDoCFB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 23/06/2021 17:06, Mark Wielaard wrote: > Hi Philip, > > On Wed, 2021-06-23 at 10:55 +0100, Philip Herron wrote: >> Small update, I think part of this issue is that the support for >> unit-structs is not there yet in the compiler, so if you remove the un= it >> tuple struct and move the other struct definitions outside of the bloc= k >> the test case works: https://godbolt.org/z/nb84sEaE4 >> >> It might be enough to help with testing your tuple index fixes. > Very nice. That workaround helps me get unblocked, except for testing > empty struct tuples (unit-structs). But I have a patch for that, and > even included a testcase to proof the parser now handles them. See > attached. > > Cheers, > > Mark This was a good find. Your patch is now being merged: https://github.com/Rust-GCC/gccrs/pull/521 Thanks --Phil --udgkrllf59V4BEvklj56UcvBi8nuDoCFB-- --4015zKTUVFi6zWQ8nvMjLWB84Q4VyPjPQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEET83ATZOayqRjyL0Cr7gxHEFOdpkFAmDTYKcFAwAAAAAACgkQr7gxHEFOdpn0 7wv8CBbbSk8ro5OJR6ItVGNpJAYZqkfXZhpHwFz+K/z+nEkqRfvqRpuKg2N4VO0JmMcddBVyWJ4h nBwhxzHL7o5iWl2zYBfUKy8oay2OT5Mw7a4cOycfLDmdX+JnkLrlrRl72mbg3mSCvhDqrLNX0xa+ V6QjJNexZbbd/esx8NJ5wFCfeJOfrOsKd5/Yfo4DoAPna5IcFqFbnALK6/Fwh0ZMo0jGzHpDDQ/8 wzW1nlcM9swM+z8lvbsX49YOriuwqLYshhV4182dcYyYaYuArAazI4yX4Yk5Vlmp7wAsPrZz3e18 rakPNLPfa1m7bVFnjt2XnXAAxmUiZPc6IMItBWZorRrbY/WnShx+z7TBWYlVneCZlh+o4Lkwr1Nz D53nOpok1fJ/XCnUIfH8ywoTE6nt541iLBvHjbAoSGu8G1MUcaordIxyxxhHTWbRvyRecuWAvMLA Po2u3vDD5F8SxpYVD1YrEdtKI8vEX0aPJLwr/hiGaW7duyYERim3icEJY+zE =jgjb -----END PGP SIGNATURE----- --4015zKTUVFi6zWQ8nvMjLWB84Q4VyPjPQ--