From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 63A693861876 for ; Thu, 15 Feb 2024 12:12:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63A693861876 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 63A693861876 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707999177; cv=none; b=p5o1eoP9shhBjmT2LuqRTQNFjeTFcl/U85jWeyoI3F3o8lOMMsO9qbuPs6Apv+w+/06QtjFXZyeUdbADZ8FoyUnRMDccFb5FYX79CPDhM5lrjbLy9kr0ZUjBRqxr5C9UMnB6j96h7ajBa9nNwe/Ve3z1qQvuKwSrotYLazvAzyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707999177; c=relaxed/simple; bh=sxekGSFXdLqaCDWyJxh0SW7M5XVv+d/pkX6gvKKG65k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=m8kvTc4MdW3bfe2y8poh18iu9UMKegBvKaPnoMh8zJ6uDQWTGc7UvVRFVl/2+aJTPQ/5q3UnBZUz/Zqvil26z082zy7bro5X2+YYGZ5aTv7RlJUbikb0/f9L5p1+b66sm8xRRM8qrp3q6vo7VGDgVAqoJQraC0hCH95RAHzAtsg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a3d01a9a9a2so74388466b.1 for ; Thu, 15 Feb 2024 04:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1707999173; x=1708603973; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xjOf7g1P3zWiwxgJYUb5tSK/cAx37/PomxjLbP8mbeA=; b=E1HgzO3BYDwqX4wKLR0WhYGdC0aeliD/5rImQ/QwpUdZ/aGL72rRdW1plPPfoUOL+n Uqby7jIwLWozSdRoRnvm+EVaf6WSj6EtMmeTaeTsHKySNoJ8s5FyrbFze6014Z9euFry unYLGxRjsABKI8jYlpcyR/eFr5ukpkh4NlfJCdAHTfojMTmUi++Voox/VFdeDGzJdreP P1eS88godHbyrXADcwGBfviq55+YTJloiltIJOFYmNkK8h2j4Bs0APss2YuoPjdiRlsz 63vMmlJF95P7uJwljxb8SQ3hreBFRA8S54f69xXI/yBXVSUA+QdNSL6EDQEwThpUm+Ym hObw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707999173; x=1708603973; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjOf7g1P3zWiwxgJYUb5tSK/cAx37/PomxjLbP8mbeA=; b=WDxlO3T/q/hpGkcmpp3cgm7q5LMXRSN1yESIr5gBrf7adMh5ukfFmx2Lz/hx2Rq5Cb NTvqW7CjWhIZQMSuMN40m7+/kdWR00Unic3rCeISJpVQ7k8eR35+spd5WE7NaEExkeCS Fczt247ELOdQgm6tEMjlgQT908ydxeUcmWC2EtRdGKcLsU3eXAVH4fvJwOqkCzKxHm9H 8JjM0Au2w3CEsea066TKXOBCO5pa+Fn+yHstWLcUP7xRy2QAAvXT5kurliZ2QOSUqmxb xaj2Ce/VUZas3Z9d3l3XDrfvSLrQSVF4QL/kphfdu77CD2DucUQ/XZgFEXoBDq9qGfPz W/qQ== X-Forwarded-Encrypted: i=1; AJvYcCVxJbn5sGR6bnTZwoy4v+ztADvY1B+L7wdvInQf09EEQTfzVaPzAgiHGJsB+3nIUpCXl5GEW5pcSIS2jZOyZMR87jykng== X-Gm-Message-State: AOJu0YxFY2qv+03gstV6bCkLCXanzDcMaP5Qt0KpqcKDDkmRpFRNwEkx j0cUIzIuQVCWFTcE4a1M1YyusbGvDbfin+scZ/T0dAX0fKmJwv/zIToZimE1Pg== X-Google-Smtp-Source: AGHT+IEOzMv0jzTUREnDq3/WPpbSG8Macs+2/dN/mFyMNu/yqihGjW3t/LMyyD+N8tcWBF3inCZieA== X-Received: by 2002:a17:906:7c7:b0:a3c:a75e:7e3a with SMTP id m7-20020a17090607c700b00a3ca75e7e3amr1103793ejc.47.1707999173013; Thu, 15 Feb 2024 04:12:53 -0800 (PST) Received: from ?IPV6:2a04:cec2:24:7d2:6e98:c7bb:44d0:2155? ([2a04:cec2:24:7d2:6e98:c7bb:44d0:2155]) by smtp.gmail.com with ESMTPSA id vb7-20020a170907d04700b00a3cfe376116sm481390ejc.57.2024.02.15.04.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 04:12:52 -0800 (PST) Message-ID: Date: Thu, 15 Feb 2024 14:12:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead To: Jakub Jelinek , Philip Herron Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org References: <20240207114419.1100894-2-arthur.cohen@embecosm.com> <20240207114419.1100894-14-arthur.cohen@embecosm.com> Content-Language: en-US From: Arthur Cohen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jakub, On 2/15/24 10:10, Jakub Jelinek wrote: > On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote: >> On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote: >>> From: Philip Herron >>> >>> This patch introduces one regression because generics are getting better >>> understood over time. The code here used to apply generics with the same >>> symbol from previous segments which was a bit of a hack with out limited >>> inference variable support. The regression looks like it will be related >>> to another issue which needs to default integer inference variables much >>> more aggresivly to default integer. >>> >>> Fixes #2723 >>> >>> gcc/rust/ChangeLog: >>> >>> * typecheck/rust-hir-type-check-path.cc (TypeCheckExpr::resolve_segments): remove hack >>> >>> gcc/testsuite/ChangeLog: >>> >>> * rust/compile/issue-1773.rs: Moved to... >>> * rust/compile/issue-1773.rs.bak: ...here. >> >> Please don't use such suffixes in the testsuite. >> Either delete the testcase, or xfail it somehow until the bug is fixed. > > To be precise, I have scripts to look for backup files in the tree (*~, > *.bak, *.orig, *.rej etc.) and this stands in the way several times a day. > > Here is a fix for that in patch form, tested on x86_64-linux with > make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs' > Ok for trunk? > > 2024-02-15 Jakub Jelinek > > * rust/compile/issue-1773.rs.bak: Rename to ... > * rust/compile/issue-1773.rs: ... this. Add dg-skip-if directive. > > diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak b/gcc/testsuite/rust/compile/issue-1773.rs > similarity index 89% > rename from gcc/testsuite/rust/compile/issue-1773.rs.bak > rename to gcc/testsuite/rust/compile/issue-1773.rs > index a4542aea00b..468497a4792 100644 > --- a/gcc/testsuite/rust/compile/issue-1773.rs.bak > +++ b/gcc/testsuite/rust/compile/issue-1773.rs > @@ -1,4 +1,5 @@ > #[lang = "sized"] > +// { dg-skip-if "" { *-*-* } } > pub trait Sized {} > > trait Foo { > > Jakub > Looks good to me, thanks for taking the time! OK for trunk. Best, Arthur