Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard <mark@klomp.org>]

Hi,

On Wed, 2022-02-23 at 11:35 +0100, Mark Wielaard wrote:
> So, this works as expected. Note that it reports issues not just for
> debian-i386, but also for some other arches (all debian based). The
> i386 issues are not new. But the others do seem to be caused by the
> latest commit. I haven't investigated why yet though.
> 
> The buildbot links also point to the log and sum files that might be
> useful to inspect.

So there were 3 issues:

- The debian-i386 build had pre-existing failures that weren't
  reported before.
- The recent commits introduced some tests which failed, and then
  some code changes that fixed those tests so they succeeded.
  IMHO the buildbot was correct to flag those because they are real
  failures, even though they were fixed 2 commits later. This makes
  e.g. bisecting issues a bit of a pain. So I would like to see us
  commit in the "correct order".
- The buildbot test was incorrect when /bin/sh wasn't bash (as on
  the debian builders, where it is dash).
  test $? == 1 should have been $? -eq 1
  Fixed.

Cheers,

Mark