Re: [PATCHSET] Reintroduce targetrustm hooks

[Arthur Cohen <cohenarthur.dev@gmail.com>]

Pushed the patches to trunk.

Thank you both for the review.

Kindly,

Arthur

On 9/14/23 12:12, Richard Biener via Gcc-rust wrote:
> On Wed, Sep 13, 2023 at 10:14 PM Iain Buclaw via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm:
>>> Alright, was not expecting to mess up this patchset so bad so here we go:
>>>
>>> This patchset reintroduces proper targetrustm hooks without the old
>>> problematic mess of macros we had, which had been removed for the first
>>> merge of gccrs upstream.
>>>
>>> Tested on x86-64 GNU Linux, and has also been present in our development
>>> repository for a long time - added by this pull-request from Iain [1]
>>> which was merged in October 2022.
>>>
>>> Ok for trunk?
>>>
>>> [PATCH 01/14] rust: Add skeleton support and documentation for
>>> [PATCH 02/14] rust: Reintroduce TARGET_RUST_CPU_INFO hook
>>> [PATCH 03/14] rust: Reintroduce TARGET_RUST_OS_INFO hook
>>> [PATCH 04/14] rust: Implement TARGET_RUST_CPU_INFO for i[34567]86-*-*
>>> [PATCH 05/14] rust: Implement TARGET_RUST_OS_INFO for *-*-darwin*
>>> [PATCH 06/14] rust: Implement TARGET_RUST_OS_INFO for *-*-freebsd*
>>> [PATCH 07/14] rust: Implement TARGET_RUST_OS_INFO for *-*-netbsd*
>>> [PATCH 08/14] rust: Implement TARGET_RUST_OS_INFO for *-*-openbsd*
>>> [PATCH 09/14] rust: Implement TARGET_RUST_OS_INFO for *-*-solaris2*.
>>> [PATCH 10/14] rust: Implement TARGET_RUST_OS_INFO for *-*-dragonfly*
>>> [PATCH 11/14] rust: Implement TARGET_RUST_OS_INFO for *-*-vxworks*
>>> [PATCH 12/14] rust: Implement TARGET_RUST_OS_INFO for *-*-fuchsia*.
>>> [PATCH 13/14] rust: Implement TARGET_RUST_OS_INFO for
>>> [PATCH 14/14] rust: Implement TARGET_RUST_OS_INFO for *-*-*linux*.
>>>
>>
>> Thanks for eventually getting round to this.
>>
>> As the co-author of this patch series, I'm not going to look at it.
>>
>> FWIW, these being Rust-specific target changes isolated to just
>> Rust-specific files, you should have the automony to commit without
>> needing any request for review - at least this is my understanding when
>> have made D-specific target changes in the past that have not touched
>> common back-end headers.
>>
>> I'll let someone else confirm and check over the shared parts touched by
>> the patch however.
> 
> I confirm.  I briefly went over the shared parts and they look OK.
> 
> Thanks,
> Richard.
> 
>> For reviewers, this is pretty much a mirror of the D front-end's CPU and
>> OS-specific target hooks (D has built-in version identifiers, not
>> built-in attributes, but both Rust and D are otherwise the same in the
>> kind of information exposed by them).
>>
>>> [1]: https://github.com/Rust-GCC/gccrs/pull/1543
>>>
>>
>> The other GitHub pull request that added these is here.
>>
>> https://github.com/Rust-GCC/gccrs/pull/1596
>>
>> Regards,
>> Iain.